Muon: tickboxes for Time Zero and First good data

[Anders Markvardsen]

Change interface to add category

Use values from datafile x (default is ticked)

Time zero: 0.55

First Good Data: 0.11

You grey out Time zero and First good data if not ticked.

Options should be preserved also after exiting the interface, and when you load the next run on the same instrument. If change instrument return to default and tick the tickbox.

[Nick Draper]

Moved to r2.6 at the end of r2.5

[Nick Draper]

Robert's old tickets returned to you for assessment.

Are they still valid, duplicates?

[Nick Draper]

Moved to backlog at the code freeze for R2.6

[Arturs Bekasovs]

Updated the GUI.

Added checkboxes and changed the layout a bit so they fit better.

Removed unused method.

Refs #6693

Changeset: 7e80a3317d13e2ae90e7b1b441516cf636a31245

[Arturs Bekasovs]

Added logic for the new check-boxes.

Refs #6693

Changeset: 5703688b0c989279979aef1976893188fd7e8e02

[Arturs Bekasovs]

Refactored the thing a bit.

In order to set values in boxes in a single place.

Refs #6693

Changeset: e120a7413252449ff339980928cfcd5c739a892d

[Arturs Bekasovs]

Auto-save values for new widgets.

This is done in a bit more clever way, which will potentially help us in the future if we will need to save other values.

Refs #6693

Changeset: 757af0a399219da722a558c6188795e9e368237e

[Arturs Bekasovs]

Removed unused class.

Refs #6693

Changeset: 0020f24804bd8d937d00ba26a654472a47ac0214

[Arturs Bekasovs]

Change default value to avoid confusion.

Refs #6693

Changeset: 79f1750203d802b3e8d2ef73c6fc90c5d55d79f4

[Arturs Bekasovs]

Merge remote-tracking branch 'origin/master' into feature/6693_muon_auto_checkboxes

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/MuonAnalysis.cpp

Refs #6693

Changeset: 0ae9969719c802064594f471a9749d9c7ae51d6b

[Arturs Bekasovs]

Tester:

Please don't get scared by the size of the test description, it's all VERY easy, I just want to make sure all the corner-cases are handled correctly.

Two new check-boxes were added to the interface. One for Time Zero and one for First Good Data. When check-box is checked, the value loaded from data file should be used instead of user-specified one.

In Muon Analysis, please check the following for BOTH check-boxes:

Basic usability

1. Open MuonAnalysis. By default, "From datafile" option should be enabled.
2. Load some data file. Value in the box should be updated.
3. Plot and make sure value is actually used.
4. Uncheck the "From datafile". The corresponding box should get enabled, but the value should stay the same.
5. Change the value and make sure that it is used when plotting.
6. Again, check the "From datafile". Verify that the box is reset to the loaded value and disabled.

Auto-update

Check that auto-update works in the following cases:

1. When "From datafile" is not used and you change the value.
2. When you check "From datafile" check-box and value is reset.

Check that plot is not updated when you uncheck "From datafile", because in that case value is not changed and there is no need to replot.

Changing the data file

According to the description, when you change the data file to the one with the SAME instrument, the following should happen:

1. If "From datafile" is used, the value should be updated. This could be verified by e.g. switching from argus0026577.nxs to argus0031800.nxs in AutoTestData.
2. If "From datafile" is NOT used, the value user has set should not be changed.

Alternatively, when instrument does get changed, both "From datafile" check-boxes should be set, and the correct values should be loaded.

Auto-save

Check that previous values for both boxes and check-boxes are restored when you close and re-open the Muon Analysis.

[Arturs Bekasovs]

Adjusted the height of the controls to match the other ones.

Refs #6693

Changeset: 1d3144ade6f93d3335a421b4e5ffdc62679f8723

[Karl Palmen]

The graph updates on pressing the return key after changing the value and immediately if the checkbox is set.

I am unable to test Changing The Data File part 1. This might be because I can't find a file of the same instrument with different values for the checkbox or that feature is not working. I need an example of two files of different values to perform this test.

All other features work OK.

[Karl Palmen]

Arturs has indentified two file for the remaining test.

[Karl Palmen]

The two files have a difference for the first good data and that works, but the zero is the same 0.22 for those two files and all other ARGUS files I find. I'll pass the test and if anyone finds a update failure of the zero, that can be reported as a separate ticket.

[Karl Palmen]

Merge remote-tracking branch 'origin/feature/6693_muon_auto_checkboxes'

Full changeset: ​7ebaedc88be3e0e9f1ce23a66c32b010141864ac

[Stuart Campbell]

This ticket has been transferred to github issue ​7539