Ticket #6697 (closed: fixed)
Create helper class for non-orthogonal capability
| Reported by: | Michael Reuter | Owned by: | Michael Reuter |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 2.5 |
| Component: | VATES | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6315 | Tester: | Stuart Campbell |
Description
The non-orthogonal capability that Kitware implemented for us needs to be implemented. This will be a helper class that will contain the main functionality. It will then be used be the necessary classes.
Change History
comment:2 Changed 8 years ago by Michael Reuter
Refs #6697. Testing the basis metadata.
Changeset: 1d57f9006e37faad44e12b3596e92904b2cba86c
comment:3 Changed 8 years ago by Michael Reuter
Refs #6697. Fix compiler issue.
Changeset: 9b1681c489dd658f3d62067aa61456b291bda425
comment:4 Changed 8 years ago by Michael Reuter
Refs #6697. Using helper in rebinning classes.
Changeset: 3c7706f328fd998a804d56f168fa72c4de0505ed
comment:5 Changed 8 years ago by Michael Reuter
Refs #6697. Updating to correct matrix and fixing test.
Changeset: 22b7cf54646f3342622f41ddb6ab57f6bd3f5d1b
comment:6 Changed 8 years ago by Michael Reuter
Refs #6697. Creating test workspace with needed information.
Changeset: db2b33b50ba8bcff829b1c45f077ed7ed83a65c4
comment:7 Changed 8 years ago by Michael Reuter
Refs #6697. Changing method signature.
The helper class now needs a workspace name. This is in preparation for getting necessary information from the workspace to calculate the skew matrix and basis for the non-orthogonal axes.
Changeset: c1977db94f28b811bb4a6d8e1c5c4104a1e01693
comment:8 Changed 8 years ago by Michael Reuter
Refs #6697. Forgot to add coord matrix to workspace in test.
Changeset: c3f6b5d6c3cf061f07fb7af8e89ce18dde54657d
comment:9 Changed 8 years ago by Michael Reuter
Refs #6697. Adding code for calculating skew matrix.
Changeset: 6bf3d9b4a95f9e3e13c861376c0cfe202c2f4402
comment:10 Changed 8 years ago by Michael Reuter
Refs #6697. Adding skew basis vector calculation.
Changeset: 4a78b07404c6058f00c12a7152d279063c775064
comment:11 Changed 8 years ago by Michael Reuter
Refs #6697. Changing procedure to cover non-unity transforms.
Changeset: 6d88ed3834316f6030facbc3bc2a4978443ab3ca
comment:12 Changed 8 years ago by Michael Reuter
Refs #6697. Adding tests for other covered cases.
Changeset: 210def699138e0c95dd7c60e06373f559445b0b2
comment:13 Changed 8 years ago by Michael Reuter
Refs #6697. Fixing and adding hardcoded examples.
Changeset: e38ebcf50a48886fc101542ca95ab23cef6dcebb
comment:14 Changed 8 years ago by Michael Reuter
Refs #6697. Adding some doxygen.
Changeset: b7abb79303d0931ed786283e6aa82677a6dd5dcf
comment:15 Changed 8 years ago by Michael Reuter
Refs #6697. Add warning message if WS info not present.
Changeset: 8507bf57011a18f22d02343febe193bd5d322b2b
comment:16 Changed 7 years ago by Michael Reuter
Refs #6697. Dealing with workspace tag.
The non-orthogonal viewing needs to look at the resulting rebinned workspace. Made the tag a part of the class so that it could be reconstructed when needed.
Changeset: a1a89601c4cd1725b5e6198b233e70fd348ddb09
comment:17 Changed 7 years ago by Michael Reuter
Refs #6697. Look at correct workspace type.
Changeset: e48559c58fcce55395940565be956393f03f93b6
comment:18 Changed 7 years ago by Michael Reuter
Refs #6697. Adding skeleton for new class.
Changeset: 0b62cbfa3ed0ef6575d8caf2403e9c5aa9e70285
comment:19 Changed 7 years ago by Michael Reuter
Refs #6697. Adding code where the work gets done.
Changeset: 8842152dabc852ec4b4b356b1a3adb5fe0650a8f
comment:20 Changed 7 years ago by Michael Reuter
Refs #6697. Adding more working code, but using some hardcoded values.
Changeset: b2586f3447fbcfd08d4ec9fb9cdf75b04d942b9c
comment:21 Changed 7 years ago by Michael Reuter
Refs #6697. Create test for simple data.
Changeset: e9ffd56e3d48e76bd233d2c0308ef5102d6e5ab1
comment:22 Changed 7 years ago by Michael Reuter
Refs #6697. Testing the basis metadata.
Changeset: 1d57f9006e37faad44e12b3596e92904b2cba86c
comment:23 Changed 7 years ago by Michael Reuter
Refs #6697. Fix compiler issue.
Changeset: 9b1681c489dd658f3d62067aa61456b291bda425
comment:24 Changed 7 years ago by Michael Reuter
Refs #6697. Using helper in rebinning classes.
Changeset: 3c7706f328fd998a804d56f168fa72c4de0505ed
comment:25 Changed 7 years ago by Michael Reuter
Refs #6697. Updating to correct matrix and fixing test.
Changeset: 22b7cf54646f3342622f41ddb6ab57f6bd3f5d1b
comment:26 Changed 7 years ago by Michael Reuter
Refs #6697. Creating test workspace with needed information.
Changeset: db2b33b50ba8bcff829b1c45f077ed7ed83a65c4
comment:27 Changed 7 years ago by Michael Reuter
Refs #6697. Changing method signature.
The helper class now needs a workspace name. This is in preparation for getting necessary information from the workspace to calculate the skew matrix and basis for the non-orthogonal axes.
Changeset: c1977db94f28b811bb4a6d8e1c5c4104a1e01693
comment:28 Changed 7 years ago by Michael Reuter
Refs #6697. Forgot to add coord matrix to workspace in test.
Changeset: c3f6b5d6c3cf061f07fb7af8e89ce18dde54657d
comment:29 Changed 7 years ago by Michael Reuter
Refs #6697. Adding code for calculating skew matrix.
Changeset: 6bf3d9b4a95f9e3e13c861376c0cfe202c2f4402
comment:30 Changed 7 years ago by Michael Reuter
Refs #6697. Adding skew basis vector calculation.
Changeset: 4a78b07404c6058f00c12a7152d279063c775064
comment:31 Changed 7 years ago by Michael Reuter
Refs #6697. Changing procedure to cover non-unity transforms.
Changeset: 6d88ed3834316f6030facbc3bc2a4978443ab3ca
comment:32 Changed 7 years ago by Michael Reuter
Refs #6697. Adding tests for other covered cases.
Changeset: 210def699138e0c95dd7c60e06373f559445b0b2
comment:33 Changed 7 years ago by Michael Reuter
Refs #6697. Fixing and adding hardcoded examples.
Changeset: e38ebcf50a48886fc101542ca95ab23cef6dcebb
comment:34 Changed 7 years ago by Michael Reuter
Refs #6697. Adding some doxygen.
Changeset: b7abb79303d0931ed786283e6aa82677a6dd5dcf
comment:35 Changed 7 years ago by Michael Reuter
Refs #6697. Add warning message if WS info not present.
Changeset: 8507bf57011a18f22d02343febe193bd5d322b2b
comment:36 Changed 7 years ago by Michael Reuter
Refs #6697. Dealing with workspace tag.
The non-orthogonal viewing needs to look at the resulting rebinned workspace. Made the tag a part of the class so that it could be reconstructed when needed.
Changeset: a1a89601c4cd1725b5e6198b233e70fd348ddb09
comment:37 Changed 7 years ago by Michael Reuter
Refs #6697. Look at correct workspace type.
Changeset: e48559c58fcce55395940565be956393f03f93b6
comment:38 Changed 7 years ago by Michael Reuter
Refs #6697. Changing to new call for W matrix.
Changeset: 913a0c09a1bb2d43104e4c94eb9cee7e61f61c64
comment:39 Changed 7 years ago by Michael Reuter
Refs #6697. Adding skeleton for new class.
Changeset: 0b62cbfa3ed0ef6575d8caf2403e9c5aa9e70285
comment:40 Changed 7 years ago by Michael Reuter
Refs #6697. Adding code where the work gets done.
Changeset: 8842152dabc852ec4b4b356b1a3adb5fe0650a8f
comment:41 Changed 7 years ago by Michael Reuter
Refs #6697. Adding more working code, but using some hardcoded values.
Changeset: b2586f3447fbcfd08d4ec9fb9cdf75b04d942b9c
comment:42 Changed 7 years ago by Michael Reuter
Refs #6697. Create test for simple data.
Changeset: e9ffd56e3d48e76bd233d2c0308ef5102d6e5ab1
comment:43 Changed 7 years ago by Michael Reuter
Refs #6697. Testing the basis metadata.
Changeset: 1d57f9006e37faad44e12b3596e92904b2cba86c
comment:44 Changed 7 years ago by Michael Reuter
Refs #6697. Fix compiler issue.
Changeset: 9b1681c489dd658f3d62067aa61456b291bda425
comment:45 Changed 7 years ago by Michael Reuter
Refs #6697. Using helper in rebinning classes.
Changeset: 3c7706f328fd998a804d56f168fa72c4de0505ed
comment:46 Changed 7 years ago by Michael Reuter
Refs #6697. Updating to correct matrix and fixing test.
Changeset: 22b7cf54646f3342622f41ddb6ab57f6bd3f5d1b
comment:47 Changed 7 years ago by Michael Reuter
Refs #6697. Creating test workspace with needed information.
Changeset: db2b33b50ba8bcff829b1c45f077ed7ed83a65c4
comment:48 Changed 7 years ago by Michael Reuter
Refs #6697. Changing method signature.
The helper class now needs a workspace name. This is in preparation for getting necessary information from the workspace to calculate the skew matrix and basis for the non-orthogonal axes.
Changeset: c1977db94f28b811bb4a6d8e1c5c4104a1e01693
comment:49 Changed 7 years ago by Michael Reuter
Refs #6697. Forgot to add coord matrix to workspace in test.
Changeset: c3f6b5d6c3cf061f07fb7af8e89ce18dde54657d
comment:50 Changed 7 years ago by Michael Reuter
Refs #6697. Adding code for calculating skew matrix.
Changeset: 6bf3d9b4a95f9e3e13c861376c0cfe202c2f4402
comment:51 Changed 7 years ago by Michael Reuter
Refs #6697. Adding skew basis vector calculation.
Changeset: 4a78b07404c6058f00c12a7152d279063c775064
comment:52 Changed 7 years ago by Michael Reuter
Refs #6697. Changing procedure to cover non-unity transforms.
Changeset: 6d88ed3834316f6030facbc3bc2a4978443ab3ca
comment:53 Changed 7 years ago by Michael Reuter
Refs #6697. Adding tests for other covered cases.
Changeset: 210def699138e0c95dd7c60e06373f559445b0b2
comment:54 Changed 7 years ago by Michael Reuter
Refs #6697. Fixing and adding hardcoded examples.
Changeset: e38ebcf50a48886fc101542ca95ab23cef6dcebb
comment:55 Changed 7 years ago by Michael Reuter
Refs #6697. Adding some doxygen.
Changeset: b7abb79303d0931ed786283e6aa82677a6dd5dcf
comment:56 Changed 7 years ago by Michael Reuter
Refs #6697. Add warning message if WS info not present.
Changeset: 8507bf57011a18f22d02343febe193bd5d322b2b
comment:57 Changed 7 years ago by Michael Reuter
Refs #6697. Dealing with workspace tag.
The non-orthogonal viewing needs to look at the resulting rebinned workspace. Made the tag a part of the class so that it could be reconstructed when needed.
Changeset: a1a89601c4cd1725b5e6198b233e70fd348ddb09
comment:58 Changed 7 years ago by Michael Reuter
Refs #6697. Look at correct workspace type.
Changeset: e48559c58fcce55395940565be956393f03f93b6
comment:59 Changed 7 years ago by Michael Reuter
Refs #6697. Changing to new call for W matrix.
Changeset: 913a0c09a1bb2d43104e4c94eb9cee7e61f61c64
comment:61 Changed 7 years ago by Michael Reuter
- Status changed from accepted to verify
- Resolution set to fixed
To Test: This one requires a recently processed MDEventWorkspace via recent code (I think two weeks ago) on master. Also, it needs a dataset that has a underlying crystal structure that is non-orthogonal. If you can't create one, I can give you access to the one I've created. You'll need to rebin the data in the VSI in order to see the effect.
comment:63 Changed 7 years ago by Michael Reuter
Refs #6697. Adding skeleton for new class.
Changeset: 0b62cbfa3ed0ef6575d8caf2403e9c5aa9e70285
comment:64 Changed 7 years ago by Michael Reuter
Refs #6697. Adding code where the work gets done.
Changeset: 8842152dabc852ec4b4b356b1a3adb5fe0650a8f
comment:65 Changed 7 years ago by Michael Reuter
Refs #6697. Adding more working code, but using some hardcoded values.
Changeset: b2586f3447fbcfd08d4ec9fb9cdf75b04d942b9c
comment:66 Changed 7 years ago by Michael Reuter
Refs #6697. Create test for simple data.
Changeset: e9ffd56e3d48e76bd233d2c0308ef5102d6e5ab1
comment:67 Changed 7 years ago by Michael Reuter
Refs #6697. Testing the basis metadata.
Changeset: 1d57f9006e37faad44e12b3596e92904b2cba86c
comment:68 Changed 7 years ago by Michael Reuter
Refs #6697. Fix compiler issue.
Changeset: 9b1681c489dd658f3d62067aa61456b291bda425
comment:69 Changed 7 years ago by Michael Reuter
Refs #6697. Using helper in rebinning classes.
Changeset: 3c7706f328fd998a804d56f168fa72c4de0505ed
comment:70 Changed 7 years ago by Michael Reuter
Refs #6697. Updating to correct matrix and fixing test.
Changeset: 22b7cf54646f3342622f41ddb6ab57f6bd3f5d1b
comment:71 Changed 7 years ago by Michael Reuter
Refs #6697. Creating test workspace with needed information.
Changeset: db2b33b50ba8bcff829b1c45f077ed7ed83a65c4
comment:72 Changed 7 years ago by Michael Reuter
Refs #6697. Changing method signature.
The helper class now needs a workspace name. This is in preparation for getting necessary information from the workspace to calculate the skew matrix and basis for the non-orthogonal axes.
Changeset: c1977db94f28b811bb4a6d8e1c5c4104a1e01693
comment:73 Changed 7 years ago by Michael Reuter
Refs #6697. Forgot to add coord matrix to workspace in test.
Changeset: c3f6b5d6c3cf061f07fb7af8e89ce18dde54657d
comment:74 Changed 7 years ago by Michael Reuter
Refs #6697. Adding code for calculating skew matrix.
Changeset: 6bf3d9b4a95f9e3e13c861376c0cfe202c2f4402
comment:75 Changed 7 years ago by Michael Reuter
Refs #6697. Adding skew basis vector calculation.
Changeset: 4a78b07404c6058f00c12a7152d279063c775064
comment:76 Changed 7 years ago by Michael Reuter
Refs #6697. Changing procedure to cover non-unity transforms.
Changeset: 6d88ed3834316f6030facbc3bc2a4978443ab3ca
comment:77 Changed 7 years ago by Michael Reuter
Refs #6697. Adding tests for other covered cases.
Changeset: 210def699138e0c95dd7c60e06373f559445b0b2
comment:78 Changed 7 years ago by Michael Reuter
Refs #6697. Fixing and adding hardcoded examples.
Changeset: e38ebcf50a48886fc101542ca95ab23cef6dcebb
comment:79 Changed 7 years ago by Michael Reuter
Refs #6697. Adding some doxygen.
Changeset: b7abb79303d0931ed786283e6aa82677a6dd5dcf
comment:80 Changed 7 years ago by Michael Reuter
Refs #6697. Add warning message if WS info not present.
Changeset: 8507bf57011a18f22d02343febe193bd5d322b2b
comment:81 Changed 7 years ago by Michael Reuter
Refs #6697. Dealing with workspace tag.
The non-orthogonal viewing needs to look at the resulting rebinned workspace. Made the tag a part of the class so that it could be reconstructed when needed.
Changeset: a1a89601c4cd1725b5e6198b233e70fd348ddb09
comment:82 Changed 7 years ago by Michael Reuter
Refs #6697. Look at correct workspace type.
Changeset: e48559c58fcce55395940565be956393f03f93b6
comment:83 Changed 7 years ago by Michael Reuter
Refs #6697. Changing to new call for W matrix.
Changeset: 913a0c09a1bb2d43104e4c94eb9cee7e61f61c64
comment:84 Changed 7 years ago by Michael Reuter
Refs #6697. Adding skeleton for new class.
Changeset: 0b62cbfa3ed0ef6575d8caf2403e9c5aa9e70285
comment:85 Changed 7 years ago by Michael Reuter
Refs #6697. Adding code where the work gets done.
Changeset: 8842152dabc852ec4b4b356b1a3adb5fe0650a8f
comment:86 Changed 7 years ago by Michael Reuter
Refs #6697. Adding more working code, but using some hardcoded values.
Changeset: b2586f3447fbcfd08d4ec9fb9cdf75b04d942b9c
comment:87 Changed 7 years ago by Michael Reuter
Refs #6697. Create test for simple data.
Changeset: e9ffd56e3d48e76bd233d2c0308ef5102d6e5ab1
comment:88 Changed 7 years ago by Michael Reuter
Refs #6697. Testing the basis metadata.
Changeset: 1d57f9006e37faad44e12b3596e92904b2cba86c
comment:89 Changed 7 years ago by Michael Reuter
Refs #6697. Fix compiler issue.
Changeset: 9b1681c489dd658f3d62067aa61456b291bda425
comment:90 Changed 7 years ago by Michael Reuter
Refs #6697. Using helper in rebinning classes.
Changeset: 3c7706f328fd998a804d56f168fa72c4de0505ed
comment:91 Changed 7 years ago by Michael Reuter
Refs #6697. Updating to correct matrix and fixing test.
Changeset: 22b7cf54646f3342622f41ddb6ab57f6bd3f5d1b
comment:92 Changed 7 years ago by Michael Reuter
Refs #6697. Creating test workspace with needed information.
Changeset: db2b33b50ba8bcff829b1c45f077ed7ed83a65c4
comment:93 Changed 7 years ago by Michael Reuter
Refs #6697. Changing method signature.
The helper class now needs a workspace name. This is in preparation for getting necessary information from the workspace to calculate the skew matrix and basis for the non-orthogonal axes.
Changeset: c1977db94f28b811bb4a6d8e1c5c4104a1e01693
comment:94 Changed 7 years ago by Michael Reuter
Refs #6697. Forgot to add coord matrix to workspace in test.
Changeset: c3f6b5d6c3cf061f07fb7af8e89ce18dde54657d
comment:95 Changed 7 years ago by Michael Reuter
Refs #6697. Adding code for calculating skew matrix.
Changeset: 6bf3d9b4a95f9e3e13c861376c0cfe202c2f4402
comment:96 Changed 7 years ago by Michael Reuter
Refs #6697. Adding skew basis vector calculation.
Changeset: 4a78b07404c6058f00c12a7152d279063c775064
comment:97 Changed 7 years ago by Michael Reuter
Refs #6697. Changing procedure to cover non-unity transforms.
Changeset: 6d88ed3834316f6030facbc3bc2a4978443ab3ca
comment:98 Changed 7 years ago by Michael Reuter
Refs #6697. Adding tests for other covered cases.
Changeset: 210def699138e0c95dd7c60e06373f559445b0b2
comment:99 Changed 7 years ago by Michael Reuter
Refs #6697. Fixing and adding hardcoded examples.
Changeset: e38ebcf50a48886fc101542ca95ab23cef6dcebb
comment:100 Changed 7 years ago by Michael Reuter
Refs #6697. Adding some doxygen.
Changeset: b7abb79303d0931ed786283e6aa82677a6dd5dcf
comment:101 Changed 7 years ago by Michael Reuter
Refs #6697. Add warning message if WS info not present.
Changeset: 8507bf57011a18f22d02343febe193bd5d322b2b
comment:102 Changed 7 years ago by Michael Reuter
Refs #6697. Dealing with workspace tag.
The non-orthogonal viewing needs to look at the resulting rebinned workspace. Made the tag a part of the class so that it could be reconstructed when needed.
Changeset: a1a89601c4cd1725b5e6198b233e70fd348ddb09
comment:103 Changed 7 years ago by Michael Reuter
Refs #6697. Look at correct workspace type.
Changeset: e48559c58fcce55395940565be956393f03f93b6
comment:104 Changed 7 years ago by Michael Reuter
Refs #6697. Changing to new call for W matrix.
Changeset: 913a0c09a1bb2d43104e4c94eb9cee7e61f61c64
comment:105 Changed 7 years ago by Peter Peterson
Moving tickets back to the release for later accounting.
comment:107 Changed 7 years ago by Stuart Campbell
Moving Paraview tickets back to main mantid milestone
comment:108 Changed 7 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:110 Changed 7 years ago by Michael Reuter
Refs #6697. Dealing with workspace tag.
The non-orthogonal viewing needs to look at the resulting rebinned workspace. Made the tag a part of the class so that it could be reconstructed when needed.
Changeset: a1a89601c4cd1725b5e6198b233e70fd348ddb09
comment:111 Changed 7 years ago by Michael Reuter
Refs #6697. Look at correct workspace type.
Changeset: e48559c58fcce55395940565be956393f03f93b6
comment:112 Changed 7 years ago by Michael Reuter
Refs #6697. Changing to new call for W matrix.
Changeset: 913a0c09a1bb2d43104e4c94eb9cee7e61f61c64
comment:113 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7543
