Ticket #6703 (closed: fixed)
Splitting Implementation for WISH
Reported by: | Owen Arnold | Owned by: | Owen Arnold |
---|---|---|---|
Priority: | major | Milestone: | Release 2.5 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | #6702 | |
Blocking: | Tester: | Nick Draper |
Description
Utilise the features introduced in #6702 for WISH. Other instruments may follow, but not under this ticket.
I'll start by using the suggestions from Dennis based on work on other instruments such as TOPAZ.
The following is from Dennis:
- I think SplitInto = 2,2,2 works better for finding peaks than the default 5,5,5 for ConvertToMD
- A SplitThreshold in the 20-50 range seems to work fairly well for finding weaker peaks. The defaults of 1000-1500 leave really large boxes around regions with weaker peaks and low counts overall.
- The default MaxRecursion depth of 20, corresponds to a smallest step size of about one-millionth of the total extent, with SplitInto=2,2,2. I don't think this resolution is justified, considering the instrument
resolution.
Change History
comment:1 Changed 8 years ago by Owen Arnold
- Status changed from new to accepted
- Owner set to Owen Arnold
comment:2 Changed 8 years ago by Owen Arnold
Tester:
There should be a new parameter file in the Instrument directory (WISH_Parameters.xml), which contains the new splitting parameters. Any convert my type conversion using Wish should now pick up these parameters and apply them. See #6702 for clarification.
The following script grabs the box settings on the actual output workspace and prints them. These should be identical to those in the parameters file.
Load(Filename='WISH00016748.raw',OutputWorkspace='2DWS') CropWorkspace(InputWorkspace='2DWS', OutputWorkspace='2DWS', StartWorkspaceIndex=0, EndWorkspaceIndex=100) wishMD = ConvertToMD(InputWorkspace='2DWS',QDimensions='Q3D',dEAnalysisMode='Elastic',MinValues='-3,-3,-3',MaxValues='3,3,3') bc = wishMD.getBoxController() print "SplitInto used:", for i in range(0, bc.getNDims()): print bc.getSplitInto(i), print print "SplitThreshold used:", print bc.getSplitThreshold() print "MaxRecursionDepth used:", print bc.getMaxDepth()
comment:3 Changed 8 years ago by Owen Arnold
refs #6703. Add param file.
Changeset: 901087c48cf5bf32c7bb4bec56cf24a93a7bf7fe
comment:4 Changed 8 years ago by Owen Arnold
Branch for testing is https://github.com/mantidproject/mantid/tree/feature/6703_wish_splitting
comment:5 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
comment:6 Changed 8 years ago by Owen Arnold
- Status changed from verify to reopened
- Resolution fixed deleted
comment:7 Changed 8 years ago by Owen Arnold
Need to updates system tests reference results against this ticket.
comment:9 Changed 8 years ago by Owen Arnold
The system test branch is https://github.com/mantidproject/systemtests/tree/6703_wish_splitting
comment:10 Changed 8 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
Failed system test appears to be passing now.
Addition not to Tester: There are TWO branches you MUST merge as part of this ticket. Both are called 6703_wish_splitting. They belong to the two independent mantid and systemtest repositories.
comment:11 Changed 8 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:13 Changed 8 years ago by Owen Arnold
refs #6703. Add param file.
Changeset: 901087c48cf5bf32c7bb4bec56cf24a93a7bf7fe
comment:14 Changed 8 years ago by Owen Arnold
refs #6703. Add param file.
Changeset: 901087c48cf5bf32c7bb4bec56cf24a93a7bf7fe
comment:15 Changed 8 years ago by Owen Arnold
refs #6703. Add param file.
Changeset: 901087c48cf5bf32c7bb4bec56cf24a93a7bf7fe
comment:16 Changed 8 years ago by Owen Arnold
refs #6703. Add param file.
Changeset: 901087c48cf5bf32c7bb4bec56cf24a93a7bf7fe
comment:17 Changed 8 years ago by Owen Arnold
refs #6703. Add param file.
Changeset: 901087c48cf5bf32c7bb4bec56cf24a93a7bf7fe
comment:18 Changed 8 years ago by Owen Arnold
refs #6703. Add param file.
Changeset: 901087c48cf5bf32c7bb4bec56cf24a93a7bf7fe
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7549