Ticket #6718 (closed: fixed)
LoadIsawPeaks algorithm is slow
| Reported by: | Vickie Lynch | Owned by: | Vickie Lynch |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | campbellsi@… | Blocked By: | |
| Blocking: | Tester: | Stuart Campbell |
Description
200 peaks takes 10-20 seconds
Change History
comment:2 Changed 8 years ago by Vickie Lynch
Refs #6718 valid-to date in old IDF
Changeset: 2b159c3713a6bc1c8752cfc17de0bfc220310a45
comment:3 Changed 8 years ago by Vickie Lynch
Refs #6718 use hints for map insert
Changeset: 1c63aedc06c54807c5f232ddccff239d5d27f8df
comment:4 Changed 8 years ago by Vickie Lynch
Refs #6718 valid-to date in old IDF
Changeset: 2b159c3713a6bc1c8752cfc17de0bfc220310a45
comment:5 Changed 8 years ago by Vickie Lynch
Refs #6718 use hints for map insert
Changeset: 1c63aedc06c54807c5f232ddccff239d5d27f8df
comment:6 Changed 8 years ago by Vickie Lynch
When I gave a hint of the beginning of the map, the time was reduced from 25.63 sec to 23.83. Using the end, it was 20.95. Allocating the map slightly increased the time to 21.03. Using a hint of the end in SpectraDetector map also, reduced the time to 18.13.
std::map<int, IDetector_const_sptr >::iterator it = m_detectorCache.end(); m_detectorCache.insert( it, std::map<int, IDetector_const_sptr >::value_type(det->getID(), det_sptr) );
m_detectorCache.get_allocator().allocate(children.size() * sizeof(std::map<int, IDetector_const_sptr >::value_type));
The time for LoadIsawPeaks is reduced by 30% and now getAllComponentsByName is my focus as the most time-consuming part.
comment:7 Changed 8 years ago by Vickie Lynch
- Status changed from accepted to verify
- Cc campbellsi@… added
- Resolution set to fixed
Hope that Stuart will test this ticket and make sure it is compatible with what his is doing in LoadInstrument.
comment:8 Changed 8 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:9 Changed 8 years ago by Stuart Campbell
Hi Vickie, Is there a good peaks file that I can use for testing ?
comment:10 Changed 8 years ago by Stuart Campbell
Original Time Taken = 6.60 seconds After fix = 5.65 seconds
comment:11 Changed 8 years ago by Vickie Lynch
Refs #6718 valid-to date in old IDF
Changeset: 2b159c3713a6bc1c8752cfc17de0bfc220310a45
comment:12 Changed 8 years ago by Vickie Lynch
Refs #6718 use hints for map insert
Changeset: 1c63aedc06c54807c5f232ddccff239d5d27f8df
comment:13 Changed 8 years ago by Vickie Lynch
Refs #6718 valid-to date in old IDF
Changeset: 2b159c3713a6bc1c8752cfc17de0bfc220310a45
comment:14 Changed 8 years ago by Vickie Lynch
Refs #6718 use hints for map insert
Changeset: 1c63aedc06c54807c5f232ddccff239d5d27f8df
comment:16 Changed 8 years ago by Vickie Lynch
Refs #6718 valid-to date in old IDF
Changeset: 2b159c3713a6bc1c8752cfc17de0bfc220310a45
comment:17 Changed 8 years ago by Vickie Lynch
Refs #6718 use hints for map insert
Changeset: 1c63aedc06c54807c5f232ddccff239d5d27f8df
comment:18 Changed 7 years ago by Vickie Lynch
Refs #6718 valid-to date in old IDF
Changeset: 2b159c3713a6bc1c8752cfc17de0bfc220310a45
comment:19 Changed 7 years ago by Vickie Lynch
Refs #6718 use hints for map insert
Changeset: 1c63aedc06c54807c5f232ddccff239d5d27f8df
comment:20 Changed 7 years ago by Vickie Lynch
Refs #6718 valid-to date in old IDF
Changeset: 2b159c3713a6bc1c8752cfc17de0bfc220310a45
comment:21 Changed 7 years ago by Vickie Lynch
Refs #6718 use hints for map insert
Changeset: 1c63aedc06c54807c5f232ddccff239d5d27f8df
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7564
