SANS: changes to SaveCanSAS1D

[Anders Markvardsen]

Change according to email from Steve below

Sorry, two more minor infringements of v1.0!

<SASinstrument> must have a <SASdetector> subgroup with a required <name> element:

<SASdetector>

<name>detector</name>

</SASdetector>

So in the case of both LOQ & SANS2D there will need to be two instances of SASdetector.

<SASprocess> requires a <SASprocessnote> element, even if it is empty:

<SASprocessnote/>

This is different to SASnote which SaveCanSAS1D is already writing.

Steve

From: King, Stephen (STFC,RAL,ISIS) Sent: 17 March 2013 12:25 To: Markvardsen, Anders (STFC,RAL,ISIS) Cc: Passos, Gesner (STFC,RAL,ISIS); Mantid Help; King, Stephen (STFC,RAL,ISIS) Subject: Urgent minor change to SaveCanSAS1D Importance: High

It has been brought to my attention that SaveCanSAS1D is not writing files that are fully-compliant with the SASXML schema!

Specifically, <Idata> is currently being written in the (admittedly seemingly logical) order: Q, Qdev, I, Idev.

The schema requires: Q, I, Idev,Qdev; ie, Qdev after Idev.

Please can this be fixed immediately.

[Anders Markvardsen]

fix for 6724. re #6724

Changeset: ca4b5ddafca8ad672e02b87d51b98d038d46360e

[Anders Markvardsen]

fix for 6724. re #6724

Changeset: ca4b5ddafca8ad672e02b87d51b98d038d46360e

[Anders Markvardsen]

Forgot to update the unit test. re #6724

Changeset: b7e9dac968c3631dd05436dd22d9733ff5d55c65

[Anders Markvardsen]

To test that the output now conform to the stylesheet e.g. do

1. Open ISIS sans interface

2. Open any mask file using the reload button, e.g. MASK.094AA from Data/LOQ in systemtests

3. Open any, using user file in 2, LOQ data

4. Do a 1D reduce for example

5. Tick the CanSAS tickbox towards the bottom right

6. Save result and check that it conform the stylesheet or that:

<SASinstrument> contain a <SASdetector> subgroup with a required <name> element:

<SASdetector>

<name></name>

</SASdetector>

<SASprocess> contains a <SASprocessnote> element

<SASprocessnote/>

<Idata> contains element in the order: Q, I, Idev,Qdev

[Anders Markvardsen]

Forgot to update the unit test. re #6724

Changeset: b7e9dac968c3631dd05436dd22d9733ff5d55c65

[Martyn Gigg]

Confirmed that the output now contains the extra elements and that the data is in the correct order.

Loading back in produces data that matches the saved workspace (all be it in point rather than histogram form)

[Anders Markvardsen]

fix for 6724. re #6724

Changeset: ca4b5ddafca8ad672e02b87d51b98d038d46360e

[Anders Markvardsen]

Forgot to update the unit test. re #6724

Changeset: b7e9dac968c3631dd05436dd22d9733ff5d55c65

[Anders Markvardsen]

fix for 6724. re #6724

Changeset: ca4b5ddafca8ad672e02b87d51b98d038d46360e

[Anders Markvardsen]

Forgot to update the unit test. re #6724

Changeset: b7e9dac968c3631dd05436dd22d9733ff5d55c65

[Anders Markvardsen]

fix for 6724. re #6724

Changeset: ca4b5ddafca8ad672e02b87d51b98d038d46360e

[Anders Markvardsen]

Forgot to update the unit test. re #6724

Changeset: b7e9dac968c3631dd05436dd22d9733ff5d55c65

[Anders Markvardsen]

fix for 6724. re #6724

Changeset: ca4b5ddafca8ad672e02b87d51b98d038d46360e

[Anders Markvardsen]

Forgot to update the unit test. re #6724

Changeset: b7e9dac968c3631dd05436dd22d9733ff5d55c65

[Anders Markvardsen]

fix for 6724. re #6724

Changeset: ca4b5ddafca8ad672e02b87d51b98d038d46360e

[Anders Markvardsen]

Forgot to update the unit test. re #6724

Changeset: b7e9dac968c3631dd05436dd22d9733ff5d55c65

[Stuart Campbell]

This ticket has been transferred to github issue ​7570