Ticket #6728 (closed: fixed)
Improve Tube Calibration
| Reported by: | Karl Palmen | Owned by: | Karl Palmen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | anders.markvardsen@… | Blocked By: | |
| Blocking: | Tester: | Martyn Gigg |
Description
Adjust the tube calibration python scripts to increase the number of tubes calibrated well. Bigger changes can me made if necessary or desirable.
Change History
comment:1 Changed 8 years ago by Karl Palmen
- Status changed from new to accepted
- Owner set to Karl Palmen
comment:2 Changed 8 years ago by Karl Palmen
Widen margin from 0.3 to 0.4 re #6728
The margin is the proportion of space between the expected positions of one peak and a neighboring peak a given peak may deviate from its expected position towards that neighbor.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 093e97ae2fa16bc7bc5daabc650ccea50798ddeb
comment:3 Changed 8 years ago by Karl Palmen
Move margin to fitParams object re #6728
This enables the margin to be set by the example script if necessary.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d01f2633c84203c55d492a179c288384cd02db5b
comment:4 Changed 8 years ago by Karl Palmen
Indicate missed shadow points in tube re #6728
When not all points are used for calibration, the ordinal number of missed points are now printed.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 1928fa68263f9c74dd497deff98e554aa588b208
comment:5 Changed 8 years ago by Karl Palmen
Adjusted expected positions in WISH example re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: aff7df463d95151a1f5edcaf7236f2c60e347447
comment:6 Changed 8 years ago by Karl Palmen
Add an example with wide margins re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 15652a4ef99ee62f8043c6bb7a61bc841baddba8
comment:7 Changed 8 years ago by Karl Palmen
Adjusted expected position for MAPS re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f64b52e872ba533d56099da7cb83c3a7b80c631f
comment:8 Changed 8 years ago by Karl Palmen
Widen margin from 0.3 to 0.4 re #6728
The margin is the proportion of space between the expected positions of one peak and a neighboring peak a given peak may deviate from its expected position towards that neighbor.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 093e97ae2fa16bc7bc5daabc650ccea50798ddeb
comment:9 Changed 8 years ago by Karl Palmen
Move margin to fitParams object re #6728
This enables the margin to be set by the example script if necessary.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d01f2633c84203c55d492a179c288384cd02db5b
comment:10 Changed 8 years ago by Karl Palmen
Indicate missed shadow points in tube re #6728
When not all points are used for calibration, the ordinal number of missed points are now printed.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 1928fa68263f9c74dd497deff98e554aa588b208
comment:11 Changed 8 years ago by Karl Palmen
Adjusted expected positions in WISH example re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: aff7df463d95151a1f5edcaf7236f2c60e347447
comment:12 Changed 8 years ago by Karl Palmen
Add an example with wide margins re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 15652a4ef99ee62f8043c6bb7a61bc841baddba8
comment:13 Changed 8 years ago by Karl Palmen
Adjusted expected position for MAPS re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f64b52e872ba533d56099da7cb83c3a7b80c631f
comment:14 Changed 8 years ago by Karl Palmen
To test I suggest you run the example scripts TubeCalibDemoMaps_All.py and TubeCalibDemoWish0.py in ...Code/Mantid/scripts/Calibration/Examples.
comment:15 Changed 8 years ago by Karl Palmen
- Status changed from accepted to verify
- Resolution set to fixed
Branch is feature/6728_improve_tube_calibration
comment:16 Changed 8 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:17 Changed 8 years ago by Martyn Gigg
- Status changed from verifying to closed
Tested the MERLIN & WISH examples and they seem to calibrate well. The peaks across all of the tubes are much more aligned on the instrument after the calibration has been run.
comment:18 Changed 8 years ago by Karl Palmen
Widen margin from 0.3 to 0.4 re #6728
The margin is the proportion of space between the expected positions of one peak and a neighboring peak a given peak may deviate from its expected position towards that neighbor.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 093e97ae2fa16bc7bc5daabc650ccea50798ddeb
comment:19 Changed 8 years ago by Karl Palmen
Move margin to fitParams object re #6728
This enables the margin to be set by the example script if necessary.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d01f2633c84203c55d492a179c288384cd02db5b
comment:20 Changed 8 years ago by Karl Palmen
Indicate missed shadow points in tube re #6728
When not all points are used for calibration, the ordinal number of missed points are now printed.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 1928fa68263f9c74dd497deff98e554aa588b208
comment:21 Changed 8 years ago by Karl Palmen
Adjusted expected positions in WISH example re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: aff7df463d95151a1f5edcaf7236f2c60e347447
comment:22 Changed 8 years ago by Karl Palmen
Add an example with wide margins re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 15652a4ef99ee62f8043c6bb7a61bc841baddba8
comment:23 Changed 8 years ago by Karl Palmen
Adjusted expected position for MAPS re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f64b52e872ba533d56099da7cb83c3a7b80c631f
comment:24 Changed 8 years ago by Karl Palmen
Widen margin from 0.3 to 0.4 re #6728
The margin is the proportion of space between the expected positions of one peak and a neighboring peak a given peak may deviate from its expected position towards that neighbor.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 093e97ae2fa16bc7bc5daabc650ccea50798ddeb
comment:25 Changed 8 years ago by Karl Palmen
Move margin to fitParams object re #6728
This enables the margin to be set by the example script if necessary.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d01f2633c84203c55d492a179c288384cd02db5b
comment:26 Changed 8 years ago by Karl Palmen
Indicate missed shadow points in tube re #6728
When not all points are used for calibration, the ordinal number of missed points are now printed.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 1928fa68263f9c74dd497deff98e554aa588b208
comment:27 Changed 8 years ago by Karl Palmen
Adjusted expected positions in WISH example re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: aff7df463d95151a1f5edcaf7236f2c60e347447
comment:28 Changed 8 years ago by Karl Palmen
Add an example with wide margins re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 15652a4ef99ee62f8043c6bb7a61bc841baddba8
comment:29 Changed 8 years ago by Karl Palmen
Adjusted expected position for MAPS re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f64b52e872ba533d56099da7cb83c3a7b80c631f
comment:30 Changed 8 years ago by Karl Palmen
Widen margin from 0.3 to 0.4 re #6728
The margin is the proportion of space between the expected positions of one peak and a neighboring peak a given peak may deviate from its expected position towards that neighbor.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 093e97ae2fa16bc7bc5daabc650ccea50798ddeb
comment:31 Changed 8 years ago by Karl Palmen
Move margin to fitParams object re #6728
This enables the margin to be set by the example script if necessary.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d01f2633c84203c55d492a179c288384cd02db5b
comment:32 Changed 8 years ago by Karl Palmen
Indicate missed shadow points in tube re #6728
When not all points are used for calibration, the ordinal number of missed points are now printed.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 1928fa68263f9c74dd497deff98e554aa588b208
comment:33 Changed 8 years ago by Karl Palmen
Adjusted expected positions in WISH example re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: aff7df463d95151a1f5edcaf7236f2c60e347447
comment:34 Changed 8 years ago by Karl Palmen
Add an example with wide margins re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 15652a4ef99ee62f8043c6bb7a61bc841baddba8
comment:35 Changed 8 years ago by Karl Palmen
Adjusted expected position for MAPS re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f64b52e872ba533d56099da7cb83c3a7b80c631f
comment:36 Changed 7 years ago by Karl Palmen
Widen margin from 0.3 to 0.4 re #6728
The margin is the proportion of space between the expected positions of one peak and a neighboring peak a given peak may deviate from its expected position towards that neighbor.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 093e97ae2fa16bc7bc5daabc650ccea50798ddeb
comment:37 Changed 7 years ago by Karl Palmen
Move margin to fitParams object re #6728
This enables the margin to be set by the example script if necessary.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d01f2633c84203c55d492a179c288384cd02db5b
comment:38 Changed 7 years ago by Karl Palmen
Indicate missed shadow points in tube re #6728
When not all points are used for calibration, the ordinal number of missed points are now printed.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 1928fa68263f9c74dd497deff98e554aa588b208
comment:39 Changed 7 years ago by Karl Palmen
Adjusted expected positions in WISH example re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: aff7df463d95151a1f5edcaf7236f2c60e347447
comment:40 Changed 7 years ago by Karl Palmen
Add an example with wide margins re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 15652a4ef99ee62f8043c6bb7a61bc841baddba8
comment:41 Changed 7 years ago by Karl Palmen
Adjusted expected position for MAPS re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f64b52e872ba533d56099da7cb83c3a7b80c631f
comment:42 Changed 7 years ago by Karl Palmen
Widen margin from 0.3 to 0.4 re #6728
The margin is the proportion of space between the expected positions of one peak and a neighboring peak a given peak may deviate from its expected position towards that neighbor.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 093e97ae2fa16bc7bc5daabc650ccea50798ddeb
comment:43 Changed 7 years ago by Karl Palmen
Move margin to fitParams object re #6728
This enables the margin to be set by the example script if necessary.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: d01f2633c84203c55d492a179c288384cd02db5b
comment:44 Changed 7 years ago by Karl Palmen
Indicate missed shadow points in tube re #6728
When not all points are used for calibration, the ordinal number of missed points are now printed.
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 1928fa68263f9c74dd497deff98e554aa588b208
comment:45 Changed 7 years ago by Karl Palmen
Adjusted expected positions in WISH example re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: aff7df463d95151a1f5edcaf7236f2c60e347447
comment:46 Changed 7 years ago by Karl Palmen
Add an example with wide margins re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: 15652a4ef99ee62f8043c6bb7a61bc841baddba8
comment:47 Changed 7 years ago by Karl Palmen
Adjusted expected position for MAPS re #6728
Signed-off-by: Karl Palmen <karl.palmen@…>
Changeset: f64b52e872ba533d56099da7cb83c3a7b80c631f
comment:48 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7574
