Ticket #6733 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Add Vesuvio to ISIS diffraction interface

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

From Sanghamitra Mukhopadhyay 

Can you please include Vesuvio in the “Indirect Diffraction” GUI in 
IDA ?  The diffraction mode in Vesuvio will take ‘filter out’ dataset
from the raw file and will reduce similarly as IRIS and TOSCA do.,
i.e., you have to use ‘indirectDiffractionReduction.py’


All back scattering spectra 3-134 will be used for diffraction. The
reduction will be in the spectroscopy mode like IRIS, but there will
not be any diffonly mode. So the interface will be more like TOSCA.
Please use only filter-out spectrum for these detectors.

I would like to see the script as well and to see what will be the
change when we add all detectors together (forward+backward ) but in
the foil out mode and separately in the foil in mode. If you please
keep those options open, that will be great. We may add all  detectors
for diffraction analysis after analysing those results.

Change History

comment:1 Changed 8 years ago by Martyn Gigg

  • Owner set to Martyn Gigg
  • Status changed from new to accepted

comment:2 Changed 8 years ago by Martyn Gigg

Allow zero analyzers in the parameter file. Refs #6733

Changeset: e21c11118d90a0c070020de14be57bc14503e935

comment:3 Changed 8 years ago by Martyn Gigg

Add Indirect Geometry Diffraction as technique for VESUVIO. Refs #6733

This means it only shows up in the diffraction GUI & not the convert to energy one.

Changeset: 72b7b21b1a16c87b2343e55f71d8f9a8b78a741a

comment:4 Changed 8 years ago by Martyn Gigg

Separate out file loading in indirect reduction steps. Refs #6733

Changeset: fd37e6d56c5bfb53d688bd9e36e0797091f1f77d

comment:5 Changed 8 years ago by Martyn Gigg

Allow loading mixed front/backward spectra. Refs #6733

Changeset: b077a56cbd2a67c58fd23d371a7266e6039d7cc0

comment:6 Changed 8 years ago by Martyn Gigg

LoadVesuvio now supports loading a single foil state. Refs #6733

Changeset: 44d851c05152ee7955ec28d2eb5bfdae830ea7db

comment:7 Changed 8 years ago by Martyn Gigg

Allow MSGReducer to pass on extra Load arguments. Refs #6733

Changeset: 44ef2e74821c2b58bffc5ffa96c328a30f5bd29c

comment:8 Changed 8 years ago by Martyn Gigg

Vesuvio will use the foil out from GUI for now. Refs #6733

Changeset: d963c0aa69e063e2753aaca486ee009c62b9bf19

comment:9 Changed 8 years ago by Martyn Gigg

Add system tests for ISIS indirect diffraction. Refs #6733

Note that the separate OSIRIS test has been merged in to the common file.

Changeset: 39eb3c776e67ebd73611a23ff0c41efc3c91c6cc

comment:10 Changed 8 years ago by Martyn Gigg

Update LoadVesuvioTest along with LoadVesuvio changes. Refs #6733

Changeset: d487a1054c2e11a30d76b8671ac39bcf723dfd71

comment:11 Changed 8 years ago by Martyn Gigg

Allow zero analyzers in the parameter file. Refs #6733

Changeset: e21c11118d90a0c070020de14be57bc14503e935

comment:12 Changed 8 years ago by Martyn Gigg

Add Indirect Geometry Diffraction as technique for VESUVIO. Refs #6733

This means it only shows up in the diffraction GUI & not the convert to energy one.

Changeset: 72b7b21b1a16c87b2343e55f71d8f9a8b78a741a

comment:13 Changed 8 years ago by Martyn Gigg

Separate out file loading in indirect reduction steps. Refs #6733

Changeset: fd37e6d56c5bfb53d688bd9e36e0797091f1f77d

comment:14 Changed 8 years ago by Martyn Gigg

Allow loading mixed front/backward spectra. Refs #6733

Changeset: b077a56cbd2a67c58fd23d371a7266e6039d7cc0

comment:15 Changed 8 years ago by Martyn Gigg

LoadVesuvio now supports loading a single foil state. Refs #6733

Changeset: 44d851c05152ee7955ec28d2eb5bfdae830ea7db

comment:16 Changed 8 years ago by Martyn Gigg

Allow MSGReducer to pass on extra Load arguments. Refs #6733

Changeset: 44ef2e74821c2b58bffc5ffa96c328a30f5bd29c

comment:17 Changed 8 years ago by Martyn Gigg

Vesuvio will use the foil out from GUI for now. Refs #6733

Changeset: d963c0aa69e063e2753aaca486ee009c62b9bf19

comment:18 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Branch: feature/6733_vesuvio_diffraction

Tester: This covers changes both the the main code repository and the systemtests repository. The same branch name exists in both and should be merged to master in each repository at the same time.

For the systemtests please run anything with Vesuvio in the name plus the new test IRISDiffspecDiffraction & ToscaDiffraction.

For the main code changes:

  • Open up MantidPlot->Interfaces->Indirect Diffraction
  • VESUVIO should now be in the list
  • Browse to find EVS14188 in systemtests/Data
  • Enter a 0.1,0.001,2.6 as the rebin parameters
  • Select plot type 'spectra'
  • Hit run

You should get a plot with several diffraction peaks.

comment:19 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:20 Changed 8 years ago by Martyn Gigg

Add system tests for ISIS indirect diffraction. Refs #6733

Note that the separate OSIRIS test has been merged in to the common file.

Changeset: 39eb3c776e67ebd73611a23ff0c41efc3c91c6cc

comment:21 Changed 8 years ago by Martyn Gigg

Update LoadVesuvioTest along with LoadVesuvio changes. Refs #6733

Changeset: d487a1054c2e11a30d76b8671ac39bcf723dfd71

comment:22 Changed 8 years ago by Martyn Gigg

Fix Vesuvio system test for parameter name changes. Refs #6733

No one is using this algorithm properly yet so the changes are managable.

Changeset: fdfd4dc071ac782e9caa06a6c53adaec474e4937

comment:23 Changed 8 years ago by Martyn Gigg

Allow zero analyzers in the parameter file. Refs #6733

Changeset: e21c11118d90a0c070020de14be57bc14503e935

comment:24 Changed 8 years ago by Martyn Gigg

Add Indirect Geometry Diffraction as technique for VESUVIO. Refs #6733

This means it only shows up in the diffraction GUI & not the convert to energy one.

Changeset: 72b7b21b1a16c87b2343e55f71d8f9a8b78a741a

comment:25 Changed 8 years ago by Martyn Gigg

Separate out file loading in indirect reduction steps. Refs #6733

Changeset: fd37e6d56c5bfb53d688bd9e36e0797091f1f77d

comment:26 Changed 8 years ago by Martyn Gigg

Allow loading mixed front/backward spectra. Refs #6733

Changeset: b077a56cbd2a67c58fd23d371a7266e6039d7cc0

comment:27 Changed 8 years ago by Martyn Gigg

LoadVesuvio now supports loading a single foil state. Refs #6733

Changeset: 44d851c05152ee7955ec28d2eb5bfdae830ea7db

comment:28 Changed 8 years ago by Martyn Gigg

Allow MSGReducer to pass on extra Load arguments. Refs #6733

Changeset: 44ef2e74821c2b58bffc5ffa96c328a30f5bd29c

comment:29 Changed 8 years ago by Martyn Gigg

Vesuvio will use the foil out from GUI for now. Refs #6733

Changeset: d963c0aa69e063e2753aaca486ee009c62b9bf19

comment:30 Changed 8 years ago by Martyn Gigg

Load all Vesuvio spectra in diffraction reduction. Refs #6733

If you don't load everything the resulting crop gives the wrong spectra since it goes by index not spectrum and assumes an off-by-one value.

Changeset: 115c3cb508eaff3d05f76381cd730f26d20f640b

comment:31 Changed 8 years ago by Martyn Gigg

Allow reduction without a parameter file. Refs #6733

Changeset: c44a5754e3886651e8123c037e8aa740749a2320

comment:32 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to closed

It is working, vesuvio is available.

comment:33 Changed 8 years ago by Martyn Gigg

Allow zero analyzers in the parameter file. Refs #6733

Changeset: e21c11118d90a0c070020de14be57bc14503e935

comment:34 Changed 8 years ago by Martyn Gigg

Add Indirect Geometry Diffraction as technique for VESUVIO. Refs #6733

This means it only shows up in the diffraction GUI & not the convert to energy one.

Changeset: 72b7b21b1a16c87b2343e55f71d8f9a8b78a741a

comment:35 Changed 8 years ago by Martyn Gigg

Separate out file loading in indirect reduction steps. Refs #6733

Changeset: fd37e6d56c5bfb53d688bd9e36e0797091f1f77d

comment:36 Changed 8 years ago by Martyn Gigg

Allow loading mixed front/backward spectra. Refs #6733

Changeset: b077a56cbd2a67c58fd23d371a7266e6039d7cc0

comment:37 Changed 8 years ago by Martyn Gigg

LoadVesuvio now supports loading a single foil state. Refs #6733

Changeset: 44d851c05152ee7955ec28d2eb5bfdae830ea7db

comment:38 Changed 8 years ago by Martyn Gigg

Allow MSGReducer to pass on extra Load arguments. Refs #6733

Changeset: 44ef2e74821c2b58bffc5ffa96c328a30f5bd29c

comment:39 Changed 8 years ago by Martyn Gigg

Vesuvio will use the foil out from GUI for now. Refs #6733

Changeset: d963c0aa69e063e2753aaca486ee009c62b9bf19

comment:40 Changed 8 years ago by Martyn Gigg

Load all Vesuvio spectra in diffraction reduction. Refs #6733

If you don't load everything the resulting crop gives the wrong spectra since it goes by index not spectrum and assumes an off-by-one value.

Changeset: 115c3cb508eaff3d05f76381cd730f26d20f640b

comment:41 Changed 8 years ago by Martyn Gigg

Allow reduction without a parameter file. Refs #6733

Changeset: c44a5754e3886651e8123c037e8aa740749a2320

comment:42 Changed 8 years ago by Martyn Gigg

Allow zero analyzers in the parameter file. Refs #6733

Changeset: e21c11118d90a0c070020de14be57bc14503e935

comment:43 Changed 8 years ago by Martyn Gigg

Add Indirect Geometry Diffraction as technique for VESUVIO. Refs #6733

This means it only shows up in the diffraction GUI & not the convert to energy one.

Changeset: 72b7b21b1a16c87b2343e55f71d8f9a8b78a741a

comment:44 Changed 8 years ago by Martyn Gigg

Separate out file loading in indirect reduction steps. Refs #6733

Changeset: fd37e6d56c5bfb53d688bd9e36e0797091f1f77d

comment:45 Changed 8 years ago by Martyn Gigg

Allow loading mixed front/backward spectra. Refs #6733

Changeset: b077a56cbd2a67c58fd23d371a7266e6039d7cc0

comment:46 Changed 8 years ago by Martyn Gigg

LoadVesuvio now supports loading a single foil state. Refs #6733

Changeset: 44d851c05152ee7955ec28d2eb5bfdae830ea7db

comment:47 Changed 8 years ago by Martyn Gigg

Allow MSGReducer to pass on extra Load arguments. Refs #6733

Changeset: 44ef2e74821c2b58bffc5ffa96c328a30f5bd29c

comment:48 Changed 8 years ago by Martyn Gigg

Vesuvio will use the foil out from GUI for now. Refs #6733

Changeset: d963c0aa69e063e2753aaca486ee009c62b9bf19

comment:49 Changed 8 years ago by Martyn Gigg

Load all Vesuvio spectra in diffraction reduction. Refs #6733

If you don't load everything the resulting crop gives the wrong spectra since it goes by index not spectrum and assumes an off-by-one value.

Changeset: 115c3cb508eaff3d05f76381cd730f26d20f640b

comment:50 Changed 8 years ago by Martyn Gigg

Allow reduction without a parameter file. Refs #6733

Changeset: c44a5754e3886651e8123c037e8aa740749a2320

comment:51 Changed 7 years ago by Martyn Gigg

Allow zero analyzers in the parameter file. Refs #6733

Changeset: e21c11118d90a0c070020de14be57bc14503e935

comment:52 Changed 7 years ago by Martyn Gigg

Add Indirect Geometry Diffraction as technique for VESUVIO. Refs #6733

This means it only shows up in the diffraction GUI & not the convert to energy one.

Changeset: 72b7b21b1a16c87b2343e55f71d8f9a8b78a741a

comment:53 Changed 7 years ago by Martyn Gigg

Separate out file loading in indirect reduction steps. Refs #6733

Changeset: fd37e6d56c5bfb53d688bd9e36e0797091f1f77d

comment:54 Changed 7 years ago by Martyn Gigg

Allow loading mixed front/backward spectra. Refs #6733

Changeset: b077a56cbd2a67c58fd23d371a7266e6039d7cc0

comment:55 Changed 7 years ago by Martyn Gigg

LoadVesuvio now supports loading a single foil state. Refs #6733

Changeset: 44d851c05152ee7955ec28d2eb5bfdae830ea7db

comment:56 Changed 7 years ago by Martyn Gigg

Allow MSGReducer to pass on extra Load arguments. Refs #6733

Changeset: 44ef2e74821c2b58bffc5ffa96c328a30f5bd29c

comment:57 Changed 7 years ago by Martyn Gigg

Vesuvio will use the foil out from GUI for now. Refs #6733

Changeset: d963c0aa69e063e2753aaca486ee009c62b9bf19

comment:58 Changed 7 years ago by Martyn Gigg

Load all Vesuvio spectra in diffraction reduction. Refs #6733

If you don't load everything the resulting crop gives the wrong spectra since it goes by index not spectrum and assumes an off-by-one value.

Changeset: 115c3cb508eaff3d05f76381cd730f26d20f640b

comment:59 Changed 7 years ago by Martyn Gigg

Allow reduction without a parameter file. Refs #6733

Changeset: c44a5754e3886651e8123c037e8aa740749a2320

comment:60 Changed 7 years ago by Martyn Gigg

Allow zero analyzers in the parameter file. Refs #6733

Changeset: e21c11118d90a0c070020de14be57bc14503e935

comment:61 Changed 7 years ago by Martyn Gigg

Add Indirect Geometry Diffraction as technique for VESUVIO. Refs #6733

This means it only shows up in the diffraction GUI & not the convert to energy one.

Changeset: 72b7b21b1a16c87b2343e55f71d8f9a8b78a741a

comment:62 Changed 7 years ago by Martyn Gigg

Separate out file loading in indirect reduction steps. Refs #6733

Changeset: fd37e6d56c5bfb53d688bd9e36e0797091f1f77d

comment:63 Changed 7 years ago by Martyn Gigg

Allow loading mixed front/backward spectra. Refs #6733

Changeset: b077a56cbd2a67c58fd23d371a7266e6039d7cc0

comment:64 Changed 7 years ago by Martyn Gigg

LoadVesuvio now supports loading a single foil state. Refs #6733

Changeset: 44d851c05152ee7955ec28d2eb5bfdae830ea7db

comment:65 Changed 7 years ago by Martyn Gigg

Allow MSGReducer to pass on extra Load arguments. Refs #6733

Changeset: 44ef2e74821c2b58bffc5ffa96c328a30f5bd29c

comment:66 Changed 7 years ago by Martyn Gigg

Vesuvio will use the foil out from GUI for now. Refs #6733

Changeset: d963c0aa69e063e2753aaca486ee009c62b9bf19

comment:67 Changed 7 years ago by Martyn Gigg

Load all Vesuvio spectra in diffraction reduction. Refs #6733

If you don't load everything the resulting crop gives the wrong spectra since it goes by index not spectrum and assumes an off-by-one value.

Changeset: 115c3cb508eaff3d05f76381cd730f26d20f640b

comment:68 Changed 7 years ago by Martyn Gigg

Allow reduction without a parameter file. Refs #6733

Changeset: c44a5754e3886651e8123c037e8aa740749a2320

comment:69 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7579

Note: See TracTickets for help on using tickets.