Ticket #6749 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Implement an algorithm to import Fullprof's irf file

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Peter Peterson

Description

Implement an algorithm to import Fullprof's irf file to a TableWorkspace. If there are multiple banks, parameters in different bank will be written to different TableWorkspaces.

Both CreateLeBailFitInput and ConvertInstrumentFile will use this new algorithm.

Attachments

2013A_HR60b1.irf​ (1002 bytes) - added by Wenduo Zhou 8 years ago.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

Implement LoadFullprofResolution. Refs #6749.

Changeset: 5258221904736a74f0f331f860516cbef0b66c2a

comment:2 Changed 8 years ago by Wenduo Zhou

Implement LoadFullprofResolution. Refs #6749.

Changeset: 5258221904736a74f0f331f860516cbef0b66c2a

comment:3 Changed 8 years ago by Wenduo Zhou

Fix the build on OSX. Refs #6749.

Changeset: 956698fa47c6c81a1ab244621c45f9cb0364d555

comment:4 Changed 8 years ago by Wenduo Zhou

Fix the build on OSX. Refs #6749.

Changeset: 956698fa47c6c81a1ab244621c45f9cb0364d555

comment:5 Changed 8 years ago by Wenduo Zhou

Declare the algorithm. Refs #6749.

Changeset: 0a0b48c535db3aad26322d8347ec03fd49387bdf

comment:6 Changed 8 years ago by Wenduo Zhou

Declare the algorithm. Refs #6749.

Changeset: 0a0b48c535db3aad26322d8347ec03fd49387bdf

comment:7 Changed 8 years ago by Wenduo Zhou

Fix the issue related to square root of sigs. Refs #6749.

Changeset: 702c9f81999b2d001d556f03d191f35fc7b17129

comment:8 Changed 8 years ago by Wenduo Zhou

Make it work with LoadFullprofResolution. Refs #6749."

  1. Make it work with the TableWorkspace generated by

LoadFullprofResolution()

  1. Fix a bug in outptu. Changeset: eb00fa1edbdc2b441df85c2ee9147b27cb3c5b31

comment:9 Changed 8 years ago by Wenduo Zhou

Fix the issue related to square root of sigs. Refs #6749.

Changeset: 702c9f81999b2d001d556f03d191f35fc7b17129

comment:10 Changed 8 years ago by Wenduo Zhou

Make it work with LoadFullprofResolution. Refs #6749."

  1. Make it work with the TableWorkspace generated by

LoadFullprofResolution()

  1. Fix a bug in outptu. Changeset: eb00fa1edbdc2b441df85c2ee9147b27cb3c5b31

comment:11 Changed 8 years ago by Wenduo Zhou

Test Instruction

  1. Download the attached .irf file;
  2. In MantidPlot, run LoadFullprofResolution()
  3. run SaveFullprofResolution to another file;
  4. Compare the original file and newly written file;
  5. Run LoadFullprofResolution() again to see whether 2 TableWorkspaces are same.

Changed 8 years ago by Wenduo Zhou

comment:12 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:13 Changed 8 years ago by Wenduo Zhou

Use LoadFullprofResolution(). Refs #6749.

Changeset: 384cfee90709681209ce48b45aae1601baf07458

comment:14 Changed 8 years ago by Wenduo Zhou

Add more output option. Refs #6749.

Changeset: d5f986504effa17f61e715cb86c4ddfa6264b706

comment:15 Changed 8 years ago by Wenduo Zhou

Use LoadFullprofResolution. Refs #6749.

Changeset: 1a245950095c9c266e8ecbc3486e38e991bfb0cf

comment:16 Changed 8 years ago by Wenduo Zhou

Fix doxygen error. Refs #6749.

Changeset: b61edb71aa5e3913f2994defc4c8f681f57b6aa8

comment:17 Changed 8 years ago by Wenduo Zhou

Use LoadFullprofResolution(). Refs #6749.

Changeset: 384cfee90709681209ce48b45aae1601baf07458

comment:18 Changed 8 years ago by Wenduo Zhou

Add more output option. Refs #6749.

Changeset: d5f986504effa17f61e715cb86c4ddfa6264b706

comment:19 Changed 8 years ago by Wenduo Zhou

Use LoadFullprofResolution. Refs #6749.

Changeset: 1a245950095c9c266e8ecbc3486e38e991bfb0cf

comment:20 Changed 8 years ago by Wenduo Zhou

Fix doxygen error. Refs #6749.

Changeset: b61edb71aa5e3913f2994defc4c8f681f57b6aa8

comment:21 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:22 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:23 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to closed

The round-trip test worked as advertised.

comment:24 Changed 8 years ago by Wenduo Zhou

Implement LoadFullprofResolution. Refs #6749.

Changeset: 5258221904736a74f0f331f860516cbef0b66c2a

comment:25 Changed 8 years ago by Wenduo Zhou

Fix the build on OSX. Refs #6749.

Changeset: 956698fa47c6c81a1ab244621c45f9cb0364d555

comment:26 Changed 8 years ago by Wenduo Zhou

Declare the algorithm. Refs #6749.

Changeset: 0a0b48c535db3aad26322d8347ec03fd49387bdf

comment:27 Changed 8 years ago by Wenduo Zhou

Fix the issue related to square root of sigs. Refs #6749.

Changeset: 702c9f81999b2d001d556f03d191f35fc7b17129

comment:28 Changed 8 years ago by Wenduo Zhou

Make it work with LoadFullprofResolution. Refs #6749."

  1. Make it work with the TableWorkspace generated by

LoadFullprofResolution()

  1. Fix a bug in outptu. Changeset: eb00fa1edbdc2b441df85c2ee9147b27cb3c5b31

comment:29 Changed 8 years ago by Wenduo Zhou

Use LoadFullprofResolution(). Refs #6749.

Changeset: 384cfee90709681209ce48b45aae1601baf07458

comment:30 Changed 8 years ago by Wenduo Zhou

Add more output option. Refs #6749.

Changeset: d5f986504effa17f61e715cb86c4ddfa6264b706

comment:31 Changed 8 years ago by Wenduo Zhou

Use LoadFullprofResolution. Refs #6749.

Changeset: 1a245950095c9c266e8ecbc3486e38e991bfb0cf

comment:32 Changed 8 years ago by Wenduo Zhou

Fix doxygen error. Refs #6749.

Changeset: b61edb71aa5e3913f2994defc4c8f681f57b6aa8

comment:33 Changed 8 years ago by Wenduo Zhou

Implement LoadFullprofResolution. Refs #6749.

Changeset: 5258221904736a74f0f331f860516cbef0b66c2a

comment:34 Changed 8 years ago by Wenduo Zhou

Fix the build on OSX. Refs #6749.

Changeset: 956698fa47c6c81a1ab244621c45f9cb0364d555

comment:35 Changed 8 years ago by Wenduo Zhou

Declare the algorithm. Refs #6749.

Changeset: 0a0b48c535db3aad26322d8347ec03fd49387bdf

comment:36 Changed 8 years ago by Wenduo Zhou

Fix the issue related to square root of sigs. Refs #6749.

Changeset: 702c9f81999b2d001d556f03d191f35fc7b17129

comment:37 Changed 8 years ago by Wenduo Zhou

Make it work with LoadFullprofResolution. Refs #6749."

  1. Make it work with the TableWorkspace generated by

LoadFullprofResolution()

  1. Fix a bug in outptu. Changeset: eb00fa1edbdc2b441df85c2ee9147b27cb3c5b31

comment:38 Changed 8 years ago by Wenduo Zhou

Use LoadFullprofResolution(). Refs #6749.

Changeset: 384cfee90709681209ce48b45aae1601baf07458

comment:39 Changed 8 years ago by Wenduo Zhou

Add more output option. Refs #6749.

Changeset: d5f986504effa17f61e715cb86c4ddfa6264b706

comment:40 Changed 8 years ago by Wenduo Zhou

Use LoadFullprofResolution. Refs #6749.

Changeset: 1a245950095c9c266e8ecbc3486e38e991bfb0cf

comment:41 Changed 8 years ago by Wenduo Zhou

Fix doxygen error. Refs #6749.

Changeset: b61edb71aa5e3913f2994defc4c8f681f57b6aa8

comment:42 Changed 8 years ago by Wenduo Zhou

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:43 Changed 8 years ago by Wenduo Zhou

Found a bug when modifying CreateLeBailFitInput() in order to use LoadFullprofResolution().

comment:44 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:45 Changed 8 years ago by Wenduo Zhou

Fixed the bug. Refs #6749.

Changeset: 6ea883015947e6c015b38821ba7673f2c2b03aab

comment:46 Changed 8 years ago by Wenduo Zhou

Test

  1. Call CreateLeBailFit() to create workspaces for Le bail fit.
  2. Call Le bail fit

comment:47 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

Code is branch feature/6749_import_fp_irf

Last edited 8 years ago by Wenduo Zhou (previous) (diff)

comment:48 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying

comment:49 Changed 8 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

CreateLeBailFitInput has a default value for the lattice constant (10 angstroms) which doesn't make sense. Make this a required parameter.

comment:50 Changed 8 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:51 Changed 8 years ago by Wenduo Zhou

Fixed the bug. Refs #6749.

Changeset: 6ea883015947e6c015b38821ba7673f2c2b03aab

comment:52 Changed 8 years ago by Wenduo Zhou

Make LatticeConstant a mandatory input. Refs #6749.

Changeset: bf1e665aadaabe8d89b0b06bc158553fb8abe702

comment:53 Changed 8 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:54 Changed 8 years ago by Peter Peterson

  • Status changed from verify to verifying

comment:55 Changed 7 years ago by Wenduo Zhou

Make LatticeConstant a mandatory input. Refs #6749.

Changeset: bf1e665aadaabe8d89b0b06bc158553fb8abe702

comment:56 Changed 7 years ago by Wenduo Zhou

Fixed the bug. Refs #6749.

Changeset: 6ea883015947e6c015b38821ba7673f2c2b03aab

comment:57 Changed 7 years ago by Wenduo Zhou

Make LatticeConstant a mandatory input. Refs #6749.

Changeset: bf1e665aadaabe8d89b0b06bc158553fb8abe702

comment:58 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

Now it is all good.

comment:59 Changed 7 years ago by Wenduo Zhou

Implement LoadFullprofResolution. Refs #6749.

Changeset: 5258221904736a74f0f331f860516cbef0b66c2a

comment:60 Changed 7 years ago by Wenduo Zhou

Fix the build on OSX. Refs #6749.

Changeset: 956698fa47c6c81a1ab244621c45f9cb0364d555

comment:61 Changed 7 years ago by Wenduo Zhou

Declare the algorithm. Refs #6749.

Changeset: 0a0b48c535db3aad26322d8347ec03fd49387bdf

comment:62 Changed 7 years ago by Wenduo Zhou

Fix the issue related to square root of sigs. Refs #6749.

Changeset: 702c9f81999b2d001d556f03d191f35fc7b17129

comment:63 Changed 7 years ago by Wenduo Zhou

Make it work with LoadFullprofResolution. Refs #6749."

  1. Make it work with the TableWorkspace generated by

LoadFullprofResolution()

  1. Fix a bug in outptu. Changeset: eb00fa1edbdc2b441df85c2ee9147b27cb3c5b31

comment:64 Changed 7 years ago by Wenduo Zhou

Use LoadFullprofResolution(). Refs #6749.

Changeset: 384cfee90709681209ce48b45aae1601baf07458

comment:65 Changed 7 years ago by Wenduo Zhou

Add more output option. Refs #6749.

Changeset: d5f986504effa17f61e715cb86c4ddfa6264b706

comment:66 Changed 7 years ago by Wenduo Zhou

Use LoadFullprofResolution. Refs #6749.

Changeset: 1a245950095c9c266e8ecbc3486e38e991bfb0cf

comment:67 Changed 7 years ago by Wenduo Zhou

Fix doxygen error. Refs #6749.

Changeset: b61edb71aa5e3913f2994defc4c8f681f57b6aa8

comment:68 Changed 7 years ago by Wenduo Zhou

Fixed the bug. Refs #6749.

Changeset: 6ea883015947e6c015b38821ba7673f2c2b03aab

comment:69 Changed 7 years ago by Wenduo Zhou

Make LatticeConstant a mandatory input. Refs #6749.

Changeset: bf1e665aadaabe8d89b0b06bc158553fb8abe702

comment:70 Changed 7 years ago by Wenduo Zhou

Implement LoadFullprofResolution. Refs #6749.

Changeset: 5258221904736a74f0f331f860516cbef0b66c2a

comment:71 Changed 7 years ago by Wenduo Zhou

Fix the build on OSX. Refs #6749.

Changeset: 956698fa47c6c81a1ab244621c45f9cb0364d555

comment:72 Changed 7 years ago by Wenduo Zhou

Declare the algorithm. Refs #6749.

Changeset: 0a0b48c535db3aad26322d8347ec03fd49387bdf

comment:73 Changed 7 years ago by Wenduo Zhou

Fix the issue related to square root of sigs. Refs #6749.

Changeset: 702c9f81999b2d001d556f03d191f35fc7b17129

comment:74 Changed 7 years ago by Wenduo Zhou

Make it work with LoadFullprofResolution. Refs #6749."

  1. Make it work with the TableWorkspace generated by

LoadFullprofResolution()

  1. Fix a bug in outptu. Changeset: eb00fa1edbdc2b441df85c2ee9147b27cb3c5b31

comment:75 Changed 7 years ago by Wenduo Zhou

Use LoadFullprofResolution(). Refs #6749.

Changeset: 384cfee90709681209ce48b45aae1601baf07458

comment:76 Changed 7 years ago by Wenduo Zhou

Add more output option. Refs #6749.

Changeset: d5f986504effa17f61e715cb86c4ddfa6264b706

comment:77 Changed 7 years ago by Wenduo Zhou

Use LoadFullprofResolution. Refs #6749.

Changeset: 1a245950095c9c266e8ecbc3486e38e991bfb0cf

comment:78 Changed 7 years ago by Wenduo Zhou

Fix doxygen error. Refs #6749.

Changeset: b61edb71aa5e3913f2994defc4c8f681f57b6aa8

comment:79 Changed 7 years ago by Wenduo Zhou

Fixed the bug. Refs #6749.

Changeset: 6ea883015947e6c015b38821ba7673f2c2b03aab

comment:80 Changed 7 years ago by Wenduo Zhou

Make LatticeConstant a mandatory input. Refs #6749.

Changeset: bf1e665aadaabe8d89b0b06bc158553fb8abe702

comment:81 Changed 7 years ago by Wenduo Zhou

Implement LoadFullprofResolution. Refs #6749.

Changeset: 5258221904736a74f0f331f860516cbef0b66c2a

comment:82 Changed 7 years ago by Wenduo Zhou

Fix the build on OSX. Refs #6749.

Changeset: 956698fa47c6c81a1ab244621c45f9cb0364d555

comment:83 Changed 7 years ago by Wenduo Zhou

Declare the algorithm. Refs #6749.

Changeset: 0a0b48c535db3aad26322d8347ec03fd49387bdf

comment:84 Changed 7 years ago by Wenduo Zhou

Fix the issue related to square root of sigs. Refs #6749.

Changeset: 702c9f81999b2d001d556f03d191f35fc7b17129

comment:85 Changed 7 years ago by Wenduo Zhou

Make it work with LoadFullprofResolution. Refs #6749."

  1. Make it work with the TableWorkspace generated by

LoadFullprofResolution()

  1. Fix a bug in outptu. Changeset: eb00fa1edbdc2b441df85c2ee9147b27cb3c5b31

comment:86 Changed 7 years ago by Wenduo Zhou

Use LoadFullprofResolution(). Refs #6749.

Changeset: 384cfee90709681209ce48b45aae1601baf07458

comment:87 Changed 7 years ago by Wenduo Zhou

Add more output option. Refs #6749.

Changeset: d5f986504effa17f61e715cb86c4ddfa6264b706

comment:88 Changed 7 years ago by Wenduo Zhou

Use LoadFullprofResolution. Refs #6749.

Changeset: 1a245950095c9c266e8ecbc3486e38e991bfb0cf

comment:89 Changed 7 years ago by Wenduo Zhou

Fix doxygen error. Refs #6749.

Changeset: b61edb71aa5e3913f2994defc4c8f681f57b6aa8

comment:90 Changed 7 years ago by Wenduo Zhou

Fixed the bug. Refs #6749.

Changeset: 6ea883015947e6c015b38821ba7673f2c2b03aab

comment:91 Changed 7 years ago by Wenduo Zhou

Make LatticeConstant a mandatory input. Refs #6749.

Changeset: bf1e665aadaabe8d89b0b06bc158553fb8abe702

comment:92 Changed 7 years ago by Wenduo Zhou

Implement LoadFullprofResolution. Refs #6749.

Changeset: 5258221904736a74f0f331f860516cbef0b66c2a

comment:93 Changed 7 years ago by Wenduo Zhou

Fix the build on OSX. Refs #6749.

Changeset: 956698fa47c6c81a1ab244621c45f9cb0364d555

comment:94 Changed 7 years ago by Wenduo Zhou

Declare the algorithm. Refs #6749.

Changeset: 0a0b48c535db3aad26322d8347ec03fd49387bdf

comment:95 Changed 7 years ago by Wenduo Zhou

Fix the issue related to square root of sigs. Refs #6749.

Changeset: 702c9f81999b2d001d556f03d191f35fc7b17129

comment:96 Changed 7 years ago by Wenduo Zhou

Make it work with LoadFullprofResolution. Refs #6749."

  1. Make it work with the TableWorkspace generated by

LoadFullprofResolution()

  1. Fix a bug in outptu. Changeset: eb00fa1edbdc2b441df85c2ee9147b27cb3c5b31

comment:97 Changed 7 years ago by Wenduo Zhou

Use LoadFullprofResolution(). Refs #6749.

Changeset: 384cfee90709681209ce48b45aae1601baf07458

comment:98 Changed 7 years ago by Wenduo Zhou

Add more output option. Refs #6749.

Changeset: d5f986504effa17f61e715cb86c4ddfa6264b706

comment:99 Changed 7 years ago by Wenduo Zhou

Use LoadFullprofResolution. Refs #6749.

Changeset: 1a245950095c9c266e8ecbc3486e38e991bfb0cf

comment:100 Changed 7 years ago by Wenduo Zhou

Fix doxygen error. Refs #6749.

Changeset: b61edb71aa5e3913f2994defc4c8f681f57b6aa8

comment:101 Changed 7 years ago by Wenduo Zhou

Fixed the bug. Refs #6749.

Changeset: 6ea883015947e6c015b38821ba7673f2c2b03aab

comment:102 Changed 7 years ago by Wenduo Zhou

Make LatticeConstant a mandatory input. Refs #6749.

Changeset: bf1e665aadaabe8d89b0b06bc158553fb8abe702

comment:103 Changed 7 years ago by Wenduo Zhou

Fixed the bug. Refs #6749.

Changeset: 6ea883015947e6c015b38821ba7673f2c2b03aab

comment:104 Changed 7 years ago by Wenduo Zhou

Make LatticeConstant a mandatory input. Refs #6749.

Changeset: bf1e665aadaabe8d89b0b06bc158553fb8abe702

comment:105 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7595

Note: See TracTickets for help on using tickets.