Ticket #6764 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create CalibrateWish and CalibrateMaps functions for tube calibration

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Alex Buts

Description

The example tube calibration scripts TubeCalibDemoMerlin_Simple.py and TubeCalibDemoMerlin_Adjustable.py have a CalibrateMerlin function, which takes the run number as the only argument.

This ticket is to create similar functions for the WISH and MAPS examples. Also optional argument could be added to these functions to control certain internally set parameters.

Change History

comment:1 Changed 8 years ago by Karl Palmen

  • Owner set to Karl Palmen
  • Status changed from new to assigned

comment:2 Changed 8 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:3 Changed 8 years ago by Karl Palmen

Add function for WISH re #6764

This function needs a second argument to specify the panel to calibration, because each calibration run deals with only one panel. Also the arguments are string rather than numbers.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b01b9bcf03cf07b6e99ed7f6f61a0fd4b86f0294

comment:4 Changed 8 years ago by Karl Palmen

Add CalibrateMaps function re #6764

This one has an integer argument and works with a five-digit run number

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e1183d8507715e5529e885618b206ef925d90a95

comment:5 Changed 8 years ago by Karl Palmen

Enable to run with integer run numbers re #6764

Previously a string with the correct number of digits was necessary

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3eb455c65f812d1f0a2d056d72bfd93016261604

comment:6 Changed 8 years ago by Karl Palmen

Add function for WISH re #6764

This function needs a second argument to specify the panel to calibration, because each calibration run deals with only one panel. Also the arguments are string rather than numbers.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b01b9bcf03cf07b6e99ed7f6f61a0fd4b86f0294

comment:7 Changed 8 years ago by Karl Palmen

Add CalibrateMaps function re #6764

This one has an integer argument and works with a five-digit run number

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e1183d8507715e5529e885618b206ef925d90a95

comment:8 Changed 8 years ago by Karl Palmen

Enable to run with integer run numbers re #6764

Previously a string with the correct number of digits was necessary

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3eb455c65f812d1f0a2d056d72bfd93016261604

comment:9 Changed 8 years ago by Karl Palmen

To test run the script TubeCalibDemoMaps_Simple.py and TubCalibDemoWish_Simple.py in ...\Code\Mantid\scripts\Calibration\Examples . The scripts should load the workspace successfully and run without error.

The files loaded are available in cycle_09_05 for MAPS and cycle_11_1 for WISH. MANTID needs to be configured to load the files for the folders they are situtuated. You may wish to copy the files to a local folder from which your Mantid will load to achieve this.

The branch is feature/6764_calibrate_inst_func .

comment:10 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:12 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:13 Changed 8 years ago by Martyn Gigg

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:14 Changed 8 years ago by Martyn Gigg

Sorry, I meant to return that to the testing pool but clicked close by accident. You can remark the ticket as fixed for someone else to pick up.

comment:15 Changed 8 years ago by Karl Palmen

  • Status changed from reopened to accepted

comment:16 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 8 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester changed from Martyn Gigg to Alex Buts

comment:18 Changed 8 years ago by Alex Buts

  • Status changed from verifying to closed

The sample files to calibrate MAPS and WISH available and run without problem. No function similar to CalibrateMerlin identified so I interpreting this ticket as the ticket to generate samples for MAPS and WISH calibration.

The description of the algorithms is sparse but can be decoded.

comment:19 Changed 8 years ago by Karl Palmen

Add function for WISH re #6764

This function needs a second argument to specify the panel to calibration, because each calibration run deals with only one panel. Also the arguments are string rather than numbers.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b01b9bcf03cf07b6e99ed7f6f61a0fd4b86f0294

comment:20 Changed 8 years ago by Karl Palmen

Add CalibrateMaps function re #6764

This one has an integer argument and works with a five-digit run number

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e1183d8507715e5529e885618b206ef925d90a95

comment:21 Changed 8 years ago by Karl Palmen

Enable to run with integer run numbers re #6764

Previously a string with the correct number of digits was necessary

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3eb455c65f812d1f0a2d056d72bfd93016261604

comment:22 Changed 8 years ago by Alex Buts

refs #6764 Windows compiler warnings (probably not ticket related)

Changeset: 6e544aa9d924a187df7f1d5a8cf87e517b59cbe6

comment:23 Changed 8 years ago by Alex Buts

refs #6764 Windows compiler warnings (probably not ticket related)

Changeset: 6e544aa9d924a187df7f1d5a8cf87e517b59cbe6

comment:24 Changed 8 years ago by Karl Palmen

Add function for WISH re #6764

This function needs a second argument to specify the panel to calibration, because each calibration run deals with only one panel. Also the arguments are string rather than numbers.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b01b9bcf03cf07b6e99ed7f6f61a0fd4b86f0294

comment:25 Changed 8 years ago by Karl Palmen

Add CalibrateMaps function re #6764

This one has an integer argument and works with a five-digit run number

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e1183d8507715e5529e885618b206ef925d90a95

comment:26 Changed 8 years ago by Karl Palmen

Enable to run with integer run numbers re #6764

Previously a string with the correct number of digits was necessary

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3eb455c65f812d1f0a2d056d72bfd93016261604

comment:27 Changed 8 years ago by Alex Buts

refs #6764 Windows compiler warnings (probably not ticket related)

Changeset: 6e544aa9d924a187df7f1d5a8cf87e517b59cbe6

comment:28 Changed 7 years ago by Karl Palmen

Add function for WISH re #6764

This function needs a second argument to specify the panel to calibration, because each calibration run deals with only one panel. Also the arguments are string rather than numbers.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b01b9bcf03cf07b6e99ed7f6f61a0fd4b86f0294

comment:29 Changed 7 years ago by Karl Palmen

Add CalibrateMaps function re #6764

This one has an integer argument and works with a five-digit run number

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e1183d8507715e5529e885618b206ef925d90a95

comment:30 Changed 7 years ago by Karl Palmen

Enable to run with integer run numbers re #6764

Previously a string with the correct number of digits was necessary

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3eb455c65f812d1f0a2d056d72bfd93016261604

comment:31 Changed 7 years ago by Alex Buts

refs #6764 Windows compiler warnings (probably not ticket related)

Changeset: 6e544aa9d924a187df7f1d5a8cf87e517b59cbe6

comment:32 Changed 7 years ago by Karl Palmen

Add function for WISH re #6764

This function needs a second argument to specify the panel to calibration, because each calibration run deals with only one panel. Also the arguments are string rather than numbers.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b01b9bcf03cf07b6e99ed7f6f61a0fd4b86f0294

comment:33 Changed 7 years ago by Karl Palmen

Add CalibrateMaps function re #6764

This one has an integer argument and works with a five-digit run number

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: e1183d8507715e5529e885618b206ef925d90a95

comment:34 Changed 7 years ago by Karl Palmen

Enable to run with integer run numbers re #6764

Previously a string with the correct number of digits was necessary

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3eb455c65f812d1f0a2d056d72bfd93016261604

comment:35 Changed 7 years ago by Alex Buts

refs #6764 Windows compiler warnings (probably not ticket related)

Changeset: 6e544aa9d924a187df7f1d5a8cf87e517b59cbe6

comment:36 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7610

Note: See TracTickets for help on using tickets.