Ticket #6804 (closed: fixed)
Clear a compiler warning & fix another category
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | trivial | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
There's a compiler warning in ConvertUnits in the Ubuntu build that was probably caused when I did some spectrum axis work. While I'm there I might sort some of the Windows ones as well.
Also, CheckWorkspacesMatch is in the 'Arithmetic' category. This doesn't seem sensible. I was thinking of hiding it by default, but actually the other category it's already in (Utility
Workspaces) seems OK.
Change History
comment:2 Changed 7 years ago by Russell Taylor
Re #6804. Remedy cppcheck warnings.
Changeset: 3027fd76b0bfb7c730d44998bb8f92f8964e02bc
comment:3 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variables and thus warning.
Changeset: 82abbe0fcf75cfbfa1b8a8033a88d69b309ea08b
comment:4 Changed 7 years ago by Russell Taylor
Re #6804. Remove strange categorization.
Changeset: 9d830dd919f4257afbf103ad6b47ded2a2dc1458
comment:5 Changed 7 years ago by Russell Taylor
Re #6804. cppcheck warning.
Changeset: 4be05e604708ec45c496e54f4bb9b19a3d85a37b
comment:6 Changed 7 years ago by Russell Taylor
Re #6804. Remove a comment that I don't want to see every time.
Changeset: 046d80df5cae7326061ce1635d80f07377a77646
comment:7 Changed 7 years ago by Russell Taylor
Re #6804. Fix indentation. No code changes.
Changeset: 7a9de71607f135929218b2a5211178b95ba4e324
comment:8 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variable.
Changeset: 741cccbeafb096610f369a5a53350be4b22c9a9d
comment:9 Changed 7 years ago by Russell Taylor
Re #6804. Remove deprecated header and its usage.
Changeset: 52b19972d74bd5c47fb46feabe9ba138cec0ff0a
comment:10 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: c3c9af5e4b0513368ed080e967ec720fcc6b3486
comment:11 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 1932463714856c6c8824765f4dfa7375244c9c10
comment:12 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 6d22b0062ddbe927f40a7efdd603cf22f03bf470
comment:13 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: ca820cfa6e374860b41d21860a17a1db3890b6e4
comment:14 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: e72ac371b97392dc1b168f5477c490e79f685af8
comment:15 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warnings.
Reordering the headers leads to the suppression of warning C4251 getting picked up from System.h via Algorithm.h
Changeset: 747c6643eaf606dcc29313e413b3e0486858a2b0
comment:16 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: c3c9af5e4b0513368ed080e967ec720fcc6b3486
comment:17 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 1932463714856c6c8824765f4dfa7375244c9c10
comment:18 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 6d22b0062ddbe927f40a7efdd603cf22f03bf470
comment:19 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: ca820cfa6e374860b41d21860a17a1db3890b6e4
comment:20 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: e72ac371b97392dc1b168f5477c490e79f685af8
comment:21 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warnings.
Reordering the headers leads to the suppression of warning C4251 getting picked up from System.h via Algorithm.h
Changeset: 747c6643eaf606dcc29313e413b3e0486858a2b0
comment:23 Changed 7 years ago by Russell Taylor
Re #6804. Remove unjustified warning suppression.
This caused an unrecognized pragma warning with the Intel compiler and is not how we deal with warnings anyway except as a last resort.
Changeset: 9f2a2d762fb171d0de87d2b5b840faba3eac9bc3
comment:24 Changed 7 years ago by Russell Taylor
Re #6804. Remove unjustified warning suppression.
This caused an unrecognized pragma warning with the Intel compiler and is not how we deal with warnings anyway except as a last resort.
Changeset: 9f2a2d762fb171d0de87d2b5b840faba3eac9bc3
comment:25 Changed 7 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
TESTING: Pretty simple changes really, so just look through them. All of the Windows 64 bit warnings that I have access to on this branch are fixed, along with the two specific things mentioned in the description regarding ConvertUnits & CheckWorkspacesMatch. A few other compiler & cppcheck warnings have been addressed.
comment:26 Changed 7 years ago by Russell Taylor
Re #6804. Add a missing test.
Changeset: 7a1399bdbfc1008cfe3694cc86b86bf304fcdb71
comment:27 Changed 7 years ago by Russell Taylor
Re #6804. Remedy cppcheck warnings.
Changeset: 3027fd76b0bfb7c730d44998bb8f92f8964e02bc
comment:28 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variables and thus warning.
Changeset: 82abbe0fcf75cfbfa1b8a8033a88d69b309ea08b
comment:29 Changed 7 years ago by Russell Taylor
Re #6804. Remove strange categorization.
Changeset: 9d830dd919f4257afbf103ad6b47ded2a2dc1458
comment:30 Changed 7 years ago by Russell Taylor
Re #6804. cppcheck warning.
Changeset: 4be05e604708ec45c496e54f4bb9b19a3d85a37b
comment:31 Changed 7 years ago by Russell Taylor
Re #6804. Remove a comment that I don't want to see every time.
Changeset: 046d80df5cae7326061ce1635d80f07377a77646
comment:32 Changed 7 years ago by Russell Taylor
Re #6804. Fix indentation. No code changes.
Changeset: 7a9de71607f135929218b2a5211178b95ba4e324
comment:33 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variable.
Changeset: 741cccbeafb096610f369a5a53350be4b22c9a9d
comment:34 Changed 7 years ago by Russell Taylor
Re #6804. Remove deprecated header and its usage.
Changeset: 52b19972d74bd5c47fb46feabe9ba138cec0ff0a
comment:35 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: c3c9af5e4b0513368ed080e967ec720fcc6b3486
comment:36 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 1932463714856c6c8824765f4dfa7375244c9c10
comment:37 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 6d22b0062ddbe927f40a7efdd603cf22f03bf470
comment:38 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: ca820cfa6e374860b41d21860a17a1db3890b6e4
comment:39 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: e72ac371b97392dc1b168f5477c490e79f685af8
comment:40 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warnings.
Reordering the headers leads to the suppression of warning C4251 getting picked up from System.h via Algorithm.h
Changeset: 747c6643eaf606dcc29313e413b3e0486858a2b0
comment:41 Changed 7 years ago by Russell Taylor
Re #6804. Remove unjustified warning suppression.
This caused an unrecognized pragma warning with the Intel compiler and is not how we deal with warnings anyway except as a last resort.
Changeset: 9f2a2d762fb171d0de87d2b5b840faba3eac9bc3
comment:42 Changed 7 years ago by Russell Taylor
Re #6804. Add a missing test.
Changeset: 7a1399bdbfc1008cfe3694cc86b86bf304fcdb71
comment:43 Changed 7 years ago by Russell Taylor
Re #6804. Remedy cppcheck warnings.
Changeset: 3027fd76b0bfb7c730d44998bb8f92f8964e02bc
comment:44 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variables and thus warning.
Changeset: 82abbe0fcf75cfbfa1b8a8033a88d69b309ea08b
comment:45 Changed 7 years ago by Russell Taylor
Re #6804. Remove strange categorization.
Changeset: 9d830dd919f4257afbf103ad6b47ded2a2dc1458
comment:46 Changed 7 years ago by Russell Taylor
Re #6804. cppcheck warning.
Changeset: 4be05e604708ec45c496e54f4bb9b19a3d85a37b
comment:47 Changed 7 years ago by Russell Taylor
Re #6804. Remove a comment that I don't want to see every time.
Changeset: 046d80df5cae7326061ce1635d80f07377a77646
comment:48 Changed 7 years ago by Russell Taylor
Re #6804. Fix indentation. No code changes.
Changeset: 7a9de71607f135929218b2a5211178b95ba4e324
comment:49 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variable.
Changeset: 741cccbeafb096610f369a5a53350be4b22c9a9d
comment:50 Changed 7 years ago by Russell Taylor
Re #6804. Remove deprecated header and its usage.
Changeset: 52b19972d74bd5c47fb46feabe9ba138cec0ff0a
comment:51 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: c3c9af5e4b0513368ed080e967ec720fcc6b3486
comment:52 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 1932463714856c6c8824765f4dfa7375244c9c10
comment:53 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 6d22b0062ddbe927f40a7efdd603cf22f03bf470
comment:54 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: ca820cfa6e374860b41d21860a17a1db3890b6e4
comment:55 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: e72ac371b97392dc1b168f5477c490e79f685af8
comment:56 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warnings.
Reordering the headers leads to the suppression of warning C4251 getting picked up from System.h via Algorithm.h
Changeset: 747c6643eaf606dcc29313e413b3e0486858a2b0
comment:57 Changed 7 years ago by Russell Taylor
Re #6804. Remove unjustified warning suppression.
This caused an unrecognized pragma warning with the Intel compiler and is not how we deal with warnings anyway except as a last resort.
Changeset: 9f2a2d762fb171d0de87d2b5b840faba3eac9bc3
comment:58 Changed 7 years ago by Russell Taylor
Re #6804. Add a missing test.
Changeset: 7a1399bdbfc1008cfe3694cc86b86bf304fcdb71
comment:59 Changed 7 years ago by Russell Taylor
Re #6804. Remedy cppcheck warnings.
Changeset: 3027fd76b0bfb7c730d44998bb8f92f8964e02bc
comment:60 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variables and thus warning.
Changeset: 82abbe0fcf75cfbfa1b8a8033a88d69b309ea08b
comment:61 Changed 7 years ago by Russell Taylor
Re #6804. Remove strange categorization.
Changeset: 9d830dd919f4257afbf103ad6b47ded2a2dc1458
comment:62 Changed 7 years ago by Russell Taylor
Re #6804. cppcheck warning.
Changeset: 4be05e604708ec45c496e54f4bb9b19a3d85a37b
comment:63 Changed 7 years ago by Russell Taylor
Re #6804. Remove a comment that I don't want to see every time.
Changeset: 046d80df5cae7326061ce1635d80f07377a77646
comment:64 Changed 7 years ago by Russell Taylor
Re #6804. Fix indentation. No code changes.
Changeset: 7a9de71607f135929218b2a5211178b95ba4e324
comment:65 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variable.
Changeset: 741cccbeafb096610f369a5a53350be4b22c9a9d
comment:66 Changed 7 years ago by Russell Taylor
Re #6804. Remove deprecated header and its usage.
Changeset: 52b19972d74bd5c47fb46feabe9ba138cec0ff0a
comment:67 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: c3c9af5e4b0513368ed080e967ec720fcc6b3486
comment:68 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 1932463714856c6c8824765f4dfa7375244c9c10
comment:69 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 6d22b0062ddbe927f40a7efdd603cf22f03bf470
comment:70 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: ca820cfa6e374860b41d21860a17a1db3890b6e4
comment:71 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: e72ac371b97392dc1b168f5477c490e79f685af8
comment:72 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warnings.
Reordering the headers leads to the suppression of warning C4251 getting picked up from System.h via Algorithm.h
Changeset: 747c6643eaf606dcc29313e413b3e0486858a2b0
comment:73 Changed 7 years ago by Russell Taylor
Re #6804. Remove unjustified warning suppression.
This caused an unrecognized pragma warning with the Intel compiler and is not how we deal with warnings anyway except as a last resort.
Changeset: 9f2a2d762fb171d0de87d2b5b840faba3eac9bc3
comment:74 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:75 Changed 7 years ago by Russell Taylor
Re #6804. Add a missing test.
Changeset: 7a1399bdbfc1008cfe3694cc86b86bf304fcdb71
comment:76 Changed 7 years ago by Russell Taylor
Re #6804. Remedy cppcheck warnings.
Changeset: 3027fd76b0bfb7c730d44998bb8f92f8964e02bc
comment:77 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variables and thus warning.
Changeset: 82abbe0fcf75cfbfa1b8a8033a88d69b309ea08b
comment:78 Changed 7 years ago by Russell Taylor
Re #6804. Remove strange categorization.
Changeset: 9d830dd919f4257afbf103ad6b47ded2a2dc1458
comment:79 Changed 7 years ago by Russell Taylor
Re #6804. cppcheck warning.
Changeset: 4be05e604708ec45c496e54f4bb9b19a3d85a37b
comment:80 Changed 7 years ago by Russell Taylor
Re #6804. Remove a comment that I don't want to see every time.
Changeset: 046d80df5cae7326061ce1635d80f07377a77646
comment:81 Changed 7 years ago by Russell Taylor
Re #6804. Fix indentation. No code changes.
Changeset: 7a9de71607f135929218b2a5211178b95ba4e324
comment:82 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variable.
Changeset: 741cccbeafb096610f369a5a53350be4b22c9a9d
comment:83 Changed 7 years ago by Russell Taylor
Re #6804. Remove deprecated header and its usage.
Changeset: 52b19972d74bd5c47fb46feabe9ba138cec0ff0a
comment:84 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: c3c9af5e4b0513368ed080e967ec720fcc6b3486
comment:85 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 1932463714856c6c8824765f4dfa7375244c9c10
comment:86 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 6d22b0062ddbe927f40a7efdd603cf22f03bf470
comment:87 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: ca820cfa6e374860b41d21860a17a1db3890b6e4
comment:88 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: e72ac371b97392dc1b168f5477c490e79f685af8
comment:89 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warnings.
Reordering the headers leads to the suppression of warning C4251 getting picked up from System.h via Algorithm.h
Changeset: 747c6643eaf606dcc29313e413b3e0486858a2b0
comment:90 Changed 7 years ago by Russell Taylor
Re #6804. Remove unjustified warning suppression.
This caused an unrecognized pragma warning with the Intel compiler and is not how we deal with warnings anyway except as a last resort.
Changeset: 9f2a2d762fb171d0de87d2b5b840faba3eac9bc3
comment:91 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
That caused a Lot to recompile. All ok though.
Good luck build servers ...
comment:92 Changed 7 years ago by Russell Taylor
Re #6804. Add a missing test.
Changeset: 7a1399bdbfc1008cfe3694cc86b86bf304fcdb71
comment:93 Changed 7 years ago by Russell Taylor
Re #6804. Remedy cppcheck warnings.
Changeset: 3027fd76b0bfb7c730d44998bb8f92f8964e02bc
comment:94 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variables and thus warning.
Changeset: 82abbe0fcf75cfbfa1b8a8033a88d69b309ea08b
comment:95 Changed 7 years ago by Russell Taylor
Re #6804. Remove strange categorization.
Changeset: 9d830dd919f4257afbf103ad6b47ded2a2dc1458
comment:96 Changed 7 years ago by Russell Taylor
Re #6804. cppcheck warning.
Changeset: 4be05e604708ec45c496e54f4bb9b19a3d85a37b
comment:97 Changed 7 years ago by Russell Taylor
Re #6804. Remove a comment that I don't want to see every time.
Changeset: 046d80df5cae7326061ce1635d80f07377a77646
comment:98 Changed 7 years ago by Russell Taylor
Re #6804. Fix indentation. No code changes.
Changeset: 7a9de71607f135929218b2a5211178b95ba4e324
comment:99 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variable.
Changeset: 741cccbeafb096610f369a5a53350be4b22c9a9d
comment:100 Changed 7 years ago by Russell Taylor
Re #6804. Remove deprecated header and its usage.
Changeset: 52b19972d74bd5c47fb46feabe9ba138cec0ff0a
comment:101 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: c3c9af5e4b0513368ed080e967ec720fcc6b3486
comment:102 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 1932463714856c6c8824765f4dfa7375244c9c10
comment:103 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 6d22b0062ddbe927f40a7efdd603cf22f03bf470
comment:104 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: ca820cfa6e374860b41d21860a17a1db3890b6e4
comment:105 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: e72ac371b97392dc1b168f5477c490e79f685af8
comment:106 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warnings.
Reordering the headers leads to the suppression of warning C4251 getting picked up from System.h via Algorithm.h
Changeset: 747c6643eaf606dcc29313e413b3e0486858a2b0
comment:107 Changed 7 years ago by Russell Taylor
Re #6804. Remove unjustified warning suppression.
This caused an unrecognized pragma warning with the Intel compiler and is not how we deal with warnings anyway except as a last resort.
Changeset: 9f2a2d762fb171d0de87d2b5b840faba3eac9bc3
comment:108 Changed 7 years ago by Russell Taylor
Re #6804. Add a missing test.
Changeset: 7a1399bdbfc1008cfe3694cc86b86bf304fcdb71
comment:109 Changed 7 years ago by Russell Taylor
Re #6804. Remedy cppcheck warnings.
Changeset: 3027fd76b0bfb7c730d44998bb8f92f8964e02bc
comment:110 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variables and thus warning.
Changeset: 82abbe0fcf75cfbfa1b8a8033a88d69b309ea08b
comment:111 Changed 7 years ago by Russell Taylor
Re #6804. Remove strange categorization.
Changeset: 9d830dd919f4257afbf103ad6b47ded2a2dc1458
comment:112 Changed 7 years ago by Russell Taylor
Re #6804. cppcheck warning.
Changeset: 4be05e604708ec45c496e54f4bb9b19a3d85a37b
comment:113 Changed 7 years ago by Russell Taylor
Re #6804. Remove a comment that I don't want to see every time.
Changeset: 046d80df5cae7326061ce1635d80f07377a77646
comment:114 Changed 7 years ago by Russell Taylor
Re #6804. Fix indentation. No code changes.
Changeset: 7a9de71607f135929218b2a5211178b95ba4e324
comment:115 Changed 7 years ago by Russell Taylor
Re #6804. Remove unused variable.
Changeset: 741cccbeafb096610f369a5a53350be4b22c9a9d
comment:116 Changed 7 years ago by Russell Taylor
Re #6804. Remove deprecated header and its usage.
Changeset: 52b19972d74bd5c47fb46feabe9ba138cec0ff0a
comment:117 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: c3c9af5e4b0513368ed080e967ec720fcc6b3486
comment:118 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 1932463714856c6c8824765f4dfa7375244c9c10
comment:119 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: 6d22b0062ddbe927f40a7efdd603cf22f03bf470
comment:120 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: ca820cfa6e374860b41d21860a17a1db3890b6e4
comment:121 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warning.
Changeset: e72ac371b97392dc1b168f5477c490e79f685af8
comment:122 Changed 7 years ago by Russell Taylor
Re #6804. MSVC compiler warnings.
Reordering the headers leads to the suppression of warning C4251 getting picked up from System.h via Algorithm.h
Changeset: 747c6643eaf606dcc29313e413b3e0486858a2b0
comment:123 Changed 7 years ago by Russell Taylor
Re #6804. Remove unjustified warning suppression.
This caused an unrecognized pragma warning with the Intel compiler and is not how we deal with warnings anyway except as a last resort.
Changeset: 9f2a2d762fb171d0de87d2b5b840faba3eac9bc3
comment:124 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7650
Re #6804. Add a missing test.