Ticket #6809 (closed: fixed)
New algorithm: ClearMaskFlag
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | minor | Milestone: | Release 2.5 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #6834 | Tester: | Owen Arnold |
Description
The SNAP instrument has a case where they need something to clear the masking flag from a workspace. This will not resurrect the data that has be deleted.
Change History
comment:2 Changed 8 years ago by Peter Peterson
Re #6809. Implemented ClearMaskFlag.
Changeset: 5edcbf0fa421045ccb7fa7159b201c728a64805e
comment:3 Changed 8 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
This is on feature/6809_ClearMaskFlag.
To test:
- Load some data
- Mask it via the instrument view or something else
- Extract the mask into a workspace (to make sure you did mask it)
- Run ClearMaskFlag on the workspace that was masked
- Extract the mask into a workspace to see that nothing is masked
comment:4 Changed 8 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:5 Changed 8 years ago by Peter Peterson
Re #6809. Implemented ClearMaskFlag.
Changeset: 5edcbf0fa421045ccb7fa7159b201c728a64805e
comment:6 Changed 8 years ago by Owen Arnold
- Status changed from verifying to closed
This algorithm does exactly what the ticket suggests it should. Code changes look sensibile. But there are are two problems.
- Code has no documentation, so '?' button is broken
- the header documentation template has not been completed, contains a TODO.
I'm going to open up a separate ticket up about these.
comment:8 Changed 7 years ago by Peter Peterson
Re #6809. Implemented ClearMaskFlag.
Changeset: 5edcbf0fa421045ccb7fa7159b201c728a64805e
comment:9 Changed 7 years ago by Peter Peterson
Re #6809. Implemented ClearMaskFlag.
Changeset: 5edcbf0fa421045ccb7fa7159b201c728a64805e
comment:10 Changed 7 years ago by Peter Peterson
Re #6809. Implemented ClearMaskFlag.
Changeset: 5edcbf0fa421045ccb7fa7159b201c728a64805e
comment:11 Changed 7 years ago by Peter Peterson
Re #6809. Implemented ClearMaskFlag.
Changeset: 5edcbf0fa421045ccb7fa7159b201c728a64805e
comment:12 Changed 7 years ago by Peter Peterson
Re #6809. Implemented ClearMaskFlag.
Changeset: 5edcbf0fa421045ccb7fa7159b201c728a64805e
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7655