Ticket #6825 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

ConvertUnits gives strange results using new "is" attribute in IDF

Reported by: Martyn Gigg Owned by: Anders Markvardsen
Priority: blocker Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

From Max Skoda:

Dear all,

I have noticed that the use of 'mark-as'=monitor is now deprecated. However, if I replace those tags by 'is', as suggested, the ConvertUnits algorithm (TOF->wavelength) does not work any more (see attached screen shots), i.e. old style works fine, labelling by 'is' does not!

Can you advise, please?

Many thanks,

Max

Attachments

ConvertUnitsOK.png (170.6 KB) - added by Martyn Gigg 8 years ago.
ConvertUnitsFail.png (148.0 KB) - added by Martyn Gigg 8 years ago.

Change History

Changed 8 years ago by Martyn Gigg

Changed 8 years ago by Martyn Gigg

comment:1 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to accepted

from meeting with Max turn out deprecated message could be improved, so that it directly refers to documentation on wiki

comment:2 Changed 7 years ago by Anders Markvardsen

Improve warning when mark-as is used. re #6825

I.e. taken out the line "For example instead of mark-as=\"monitor\" use instead is=\"monitor\"" and force user to look at wiki

Changeset: 1a219606f4fc23f960dcfaa518cc5646dc075bc3

comment:3 Changed 7 years ago by Anders Markvardsen

Improve warning when mark-as is used. re #6825

I.e. taken out the line "For example instead of mark-as=\"monitor\" use instead is=\"monitor\"" and force user to look at wiki

Changeset: 1a219606f4fc23f960dcfaa518cc5646dc075bc3

comment:4 Changed 7 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test simply Load HRP38362a in AutoTestData in MantidPlot and check that a warning message DIFFERENT from :

Attribute 'mark-as' is a depricated attribute in Instrument Definition File. For example instead of mark-as="monitor" use instead is="monitor". See www.mantidproject.org/IDF for more details

is outputted

comment:5 Changed 7 years ago by Anders Markvardsen

Improve warning when mark-as is used. re #6825

I.e. taken out the line "For example instead of mark-as=\"monitor\" use instead is=\"monitor\"" and force user to look at wiki

Changeset: 1a219606f4fc23f960dcfaa518cc5646dc075bc3

comment:6 Changed 7 years ago by Anders Markvardsen

Improve warning when mark-as is used. re #6825

I.e. taken out the line "For example instead of mark-as=\"monitor\" use instead is=\"monitor\"" and force user to look at wiki

Changeset: 1a219606f4fc23f960dcfaa518cc5646dc075bc3

comment:7 Changed 7 years ago by Anders Markvardsen

Improve warning when mark-as is used. re #6825

I.e. taken out the line "For example instead of mark-as=\"monitor\" use instead is=\"monitor\"" and force user to look at wiki

Changeset: 1a219606f4fc23f960dcfaa518cc5646dc075bc3

comment:8 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:9 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:10 Changed 7 years ago by Anders Markvardsen

Improve warning when mark-as is used. re #6825

I.e. taken out the line "For example instead of mark-as=\"monitor\" use instead is=\"monitor\"" and force user to look at wiki

Changeset: 1a219606f4fc23f960dcfaa518cc5646dc075bc3

comment:11 Changed 7 years ago by Anders Markvardsen

Improve warning when mark-as is used. re #6825

I.e. taken out the line "For example instead of mark-as=\"monitor\" use instead is=\"monitor\"" and force user to look at wiki

Changeset: 1a219606f4fc23f960dcfaa518cc5646dc075bc3

comment:12 Changed 7 years ago by Anders Markvardsen

Improve warning when mark-as is used. re #6825

I.e. taken out the line "For example instead of mark-as=\"monitor\" use instead is=\"monitor\"" and force user to look at wiki

Changeset: 1a219606f4fc23f960dcfaa518cc5646dc075bc3

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7671

Note: See TracTickets for help on using tickets.