Ticket #6835 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

History is lost after ConjoinWorkspaces

Reported by: Gesner Passos Owned by: Dan Nixon
Priority: major Milestone: Release 3.4
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Federico Montesino Pouzols

Description (last modified by Nick Draper) (diff)

ConjoinWorkspaces will get just part of the history necessary to construct the workspace. This will make the final result not 'reproducible' in the long term. 

Out1 = LoadNexus('16183',SpectrumMin=2,SpectrumMax=10)
Out2 = LoadNexus('16185',SpectrumMin=11,SpectrumMax=20)
ConjoinWorkspaces(Out1,Out2,False)

######################################################################
#Python Script Generated by GeneratePythonScript Algorithm
######################################################################
LoadNexus(Filename=r'/archive/ndxsans2d/Instrument/data/cycle_12_3/SANS2D00016185.nxs',OutputWorkspace='Out2',SpectrumMin='11',SpectrumMax='20')
ConjoinWorkspaces(InputWorkspace1='Out1',InputWorkspace2='Out2',CheckOverlapping='0')

There was some discussion on the History and to change its design, so I thought it would be worth to mention this problem as well.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:2 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:4 Changed 7 years ago by Nick Draper

  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.1

comment:5 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.1 to Backlog

Moved to backlog at the end of Release 3.1

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:7 Changed 5 years ago by Dan Nixon

  • Owner changed from Nick Draper to Dan Nixon
  • Milestone changed from Backlog to Release 3.4

comment:8 Changed 5 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Fix original issue Refs #6835

Changeset: 01f34bc980f210c195619aea7edca63ca35d9912

comment:9 Changed 5 years ago by Dan Nixon

Update unit test to check for history

Refs #6835

Changeset: da80969f6cbdb29dd321f653f4347e349323cb09

comment:10 Changed 5 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #577.

comment:11 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:12 Changed 5 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #577 from mantidproject/6835_fix_history_bug_on_conjoinworkspaces

Fix history issue on ConjoinWorkspaces

Full changeset: ​406cfc18a26b0ed2c77825eb9c3bdf546e349416

comment:13 Changed 5 years ago by Dan Nixon

Fix original issue Refs #6835

Changeset: b48c8c4583b2cd0130ccca660d25a546fce08e5b

comment:14 Changed 5 years ago by Dan Nixon

Update unit test to check for history

Refs #6835

Changeset: 311872daf4958ca5ed949fdc232d23f9a1cca926

comment:15 Changed 5 years ago by Nick Draper

Somehow these slipped through without a resolution. Set to Fixed.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7681

Note: See TracTickets for help on using tickets.