Allow W matrix retrieval from MDWorkspace

[Michael Reuter]

The W matrix, as defined in MDWSTransform::buildQTrahsf as the object Wmat, needs to be retrievable from any MDWorkspace (event or histo). This is important for the non-orthogonal axes viewing mechanism.

[Michael Reuter]

It should also be checked that the W matrix survives MergeMD too.

[Michael Reuter]

One other thing. This information needs to settable on a MD workspace as well since the W matrix will be stored in the MD files (#6849). Thanks.

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017

[Alex Buts]

refs #6852 A bit more tests

Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017

[Alex Buts]

refs #6852 A bit more tests

Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: fe91008945a43c9957cbe3f3324d619729843a77

[Alex Buts]

ok, up to here I am setting the W_Matrix as log value on Run for the target workspace and can retrieve it.

In theory, it should be saved as part of experiment info and retrieved from there automatically. But I have substantially overhaul the IO including saving/restoring experiment info in ticket #6449. All other tests/changes to this stuff would depend on #6449 merged to master

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 10eb402599da6fe268257bf5dde2b591507ee589

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955

[Alex Buts]

refs #6852 A bit more tests

Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad

[Alex Buts]

refs #6852 Unit test which checks that EI saved and loaded from NeXus

Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 10eb402599da6fe268257bf5dde2b591507ee589

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955

[Alex Buts]

refs #6852 A bit more tests

Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad

[Alex Buts]

refs #6852 Unit test which checks that EI saved and loaded from NeXus

Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029

[Alex Buts]

Here I introduced W_matrix as log value in the experiment info, added this log value to experiment info when converting to MD and verified that this value is loaded/saved properly.

The W-matrix log is actually vector, one has to make matrix from it to use it as a matrix. This is demonstrated in ConvertToMDComponentsTest.h, test testCopyMethadata.

I believe, unit tests cover requested functionality well. A tester may run ConvertToMD with different W-matrix (which is defined by non-trivial u,v,w vectors) and look at the logs, associated with resulting MD workspace. All W-matrices should be there.

[Michael Reuter]

This is setting the W transform matrix not the W matrix as specified by the following code:

  // if u,v us default, Wmat is unit transformation
  Kernel::DblMatrix  Wmat(3,3,true);
  // derive rotation from u0,v0 u0||ki to u,v
  if(!m_isUVdefault)
  {  
    Wmat[0][0]=m_UProj[0];
    Wmat[1][0]=m_UProj[1];
    Wmat[2][0]=m_UProj[2];
    Wmat[0][1]=m_VProj[0];
    Wmat[1][1]=m_VProj[1];
    Wmat[2][1]=m_VProj[2];
    Wmat[0][2]=m_WProj[0];
    Wmat[1][2]=m_WProj[1];
    Wmat[2][2]=m_WProj[2];
  }

in MDEvents::MDWSTransform::buildQTrahsf. I need the Wmat object NOT what is defined at the bottom of that function.

Also, what gets written into files is all messed up even if I use the identity transform in ConvertToMD. However, I think this is due to my expectation for the W matrix not being the above.

[Michael Reuter]

BTW, there was already a way to get the W transform matrix: API::MDGeometry::getWTransf().

[Alex Buts]

refs #6852 Small changes to unit tests

Changeset: 9ae30d2bbb8b2012c13333011123b91146949418

[Alex Buts]

refs #6852 Small changes to unit tests

Changeset: 9ae30d2bbb8b2012c13333011123b91146949418

[Alex Buts]

main commit to this ticket have erroneously gone under refs #6449.

Let's leave WTransf on Geometry alone -- The ticket #5982 should deal with different definitions of different transformations, bearing in mind that similar transformation is defined on MDGeometry using projection vectors. I would probably deal with this ticket after #6865 to understand/incorporate all changes introduced by it.

Meanwhile, correct W-transformation is added to logs as W_MATRIX. The previous matrix (which can also be useful) remaining in the experiment info as RUBW transformation.

[Michael Reuter]

This now does what I expect and I see sensible things in files that I write. I can see things coming back when I read them, but can't see the array property in python. I've opened a ticket (#6919) on this, but notice it is for next release. Thanks for getting this done.

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 10eb402599da6fe268257bf5dde2b591507ee589

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955

[Alex Buts]

refs #6852 A bit more tests

Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad

[Alex Buts]

refs #6852 Unit test which checks that EI saved and loaded from NeXus

Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029

[Alex Buts]

refs #6852 Small changes to unit tests

Changeset: 9ae30d2bbb8b2012c13333011123b91146949418

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017

[Alex Buts]

refs #6852 A bit more tests

Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: fe91008945a43c9957cbe3f3324d619729843a77

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 10eb402599da6fe268257bf5dde2b591507ee589

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955

[Alex Buts]

refs #6852 A bit more tests

Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad

[Alex Buts]

refs #6852 Unit test which checks that EI saved and loaded from NeXus

Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029

[Alex Buts]

refs #6852 Small changes to unit tests

Changeset: 9ae30d2bbb8b2012c13333011123b91146949418

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 10eb402599da6fe268257bf5dde2b591507ee589

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955

[Alex Buts]

refs #6852 A bit more tests

Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad

[Alex Buts]

refs #6852 Unit test which checks that EI saved and loaded from NeXus

Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029

[Alex Buts]

refs #6852 Small changes to unit tests

Changeset: 9ae30d2bbb8b2012c13333011123b91146949418

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017

[Alex Buts]

refs #6852 A bit more tests

Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: fe91008945a43c9957cbe3f3324d619729843a77

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017

[Alex Buts]

refs #6852 A bit more tests

Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: fe91008945a43c9957cbe3f3324d619729843a77

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 10eb402599da6fe268257bf5dde2b591507ee589

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955

[Alex Buts]

refs #6852 A bit more tests

Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad

[Alex Buts]

refs #6852 Unit test which checks that EI saved and loaded from NeXus

Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029

[Alex Buts]

refs #6852 Small changes to unit tests

Changeset: 9ae30d2bbb8b2012c13333011123b91146949418

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 10eb402599da6fe268257bf5dde2b591507ee589

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955

[Alex Buts]

refs #6852 A bit more tests

Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad

[Alex Buts]

refs #6852 Unit test which checks that EI saved and loaded from NeXus

Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029

[Alex Buts]

refs #6852 Small changes to unit tests

Changeset: 9ae30d2bbb8b2012c13333011123b91146949418

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017

[Alex Buts]

refs #6852 A bit more tests

Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: fe91008945a43c9957cbe3f3324d619729843a77

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017

[Alex Buts]

refs #6852 A bit more tests

Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: fe91008945a43c9957cbe3f3324d619729843a77

[Alex Buts]

refs #6852 Should solve the ticket

in theory. Test are still needed.

Changeset: 10eb402599da6fe268257bf5dde2b591507ee589

[Alex Buts]

refs #6852 Unit tests for exporting W-matrix

Does not compile yet as matrix property is not implemented properly yet.

Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4

[Alex Buts]

refs #6852 W_matrix is the workspace property and can be retrieved

tests show that.

Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955

[Alex Buts]

refs #6852 A bit more tests

Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d

[Alex Buts]

refs #6852 Stupid warning on Linux

Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad

[Alex Buts]

refs #6852 Unit test which checks that EI saved and loaded from NeXus

Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029

[Alex Buts]

refs #6852 Small changes to unit tests

Changeset: 9ae30d2bbb8b2012c13333011123b91146949418

[Andrei Savici]

Merge branch 'feature/6857_autoreduction_helpers' into develop into 6856_ConvertToDiffractionMDWS_v2

[Martyn Gigg]

Merge branch 'feature/6202_remove_script_console' into develop into 6856_ConvertToDiffractionMDWS_v2

[Owen Arnold]

Merge branch 'bugfix/6859_ignore_paths' into develop into 6856_ConvertToDiffractionMDWS_v2

[Alex Buts]

Merge branch 'feature/6852_WMatrixAvailibleOnWorkspace' into develop into 6856_ConvertToDiffractionMDWS_v2

[Alex Buts]

Merge branch 'feature/6852_WMatrixAvailibleOnWorkspace' into develop into 6856_ConvertToDiffractionMDWS_v2

[Andrei Savici]

Merge branch 'feature/6857_autoreduction_helpers' into develop into 6856_ConvertToDiffractionMDWS_v2

[Martyn Gigg]

Merge branch 'feature/6202_remove_script_console' into develop into 6856_ConvertToDiffractionMDWS_v2

[Owen Arnold]

Merge branch 'bugfix/6859_ignore_paths' into develop into 6856_ConvertToDiffractionMDWS_v2

[Alex Buts]

Merge branch 'feature/6852_WMatrixAvailibleOnWorkspace' into develop into 6856_ConvertToDiffractionMDWS_v2

[Alex Buts]

Merge branch 'feature/6852_WMatrixAvailibleOnWorkspace' into develop into 6856_ConvertToDiffractionMDWS_v2

[Stuart Campbell]

This ticket has been transferred to github issue ​7698