Ticket #6852 (closed: fixed)
Allow W matrix retrieval from MDWorkspace
Reported by: | Michael Reuter | Owned by: | Alex Buts |
---|---|---|---|
Priority: | critical | Milestone: | Release 2.5 |
Component: | VATES | Keywords: | |
Cc: | Blocked By: | #6449 | |
Blocking: | #6865 | Tester: | Michael Reuter |
Description
The W matrix, as defined in MDWSTransform::buildQTrahsf as the object Wmat, needs to be retrievable from any MDWorkspace (event or histo). This is important for the non-orthogonal axes viewing mechanism.
Change History
comment:3 Changed 7 years ago by Michael Reuter
One other thing. This information needs to settable on a MD workspace as well since the W matrix will be stored in the MD files (#6849). Thanks.
comment:4 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643
comment:5 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0
comment:6 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017
comment:7 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9
comment:8 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643
comment:9 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0
comment:10 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017
comment:11 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9
comment:12 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: fe91008945a43c9957cbe3f3324d619729843a77
comment:13 Changed 7 years ago by Alex Buts
- Blocked By 6449 added
ok, up to here I am setting the W_Matrix as log value on Run for the target workspace and can retrieve it.
In theory, it should be saved as part of experiment info and retrieved from there automatically. But I have substantially overhaul the IO including saving/restoring experiment info in ticket #6449. All other tests/changes to this stuff would depend on #6449 merged to master
comment:15 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 10eb402599da6fe268257bf5dde2b591507ee589
comment:16 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4
comment:17 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955
comment:18 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d
comment:19 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad
comment:20 Changed 7 years ago by Alex Buts
refs #6852 Unit test which checks that EI saved and loaded from NeXus
Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029
comment:21 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 10eb402599da6fe268257bf5dde2b591507ee589
comment:22 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4
comment:23 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955
comment:24 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d
comment:25 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad
comment:26 Changed 7 years ago by Alex Buts
refs #6852 Unit test which checks that EI saved and loaded from NeXus
Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029
comment:27 Changed 7 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
Here I introduced W_matrix as log value in the experiment info, added this log value to experiment info when converting to MD and verified that this value is loaded/saved properly.
The W-matrix log is actually vector, one has to make matrix from it to use it as a matrix. This is demonstrated in ConvertToMDComponentsTest.h, test testCopyMethadata.
I believe, unit tests cover requested functionality well. A tester may run ConvertToMD with different W-matrix (which is defined by non-trivial u,v,w vectors) and look at the logs, associated with resulting MD workspace. All W-matrices should be there.
comment:28 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:29 Changed 7 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
This is setting the W transform matrix not the W matrix as specified by the following code:
// if u,v us default, Wmat is unit transformation Kernel::DblMatrix Wmat(3,3,true); // derive rotation from u0,v0 u0||ki to u,v if(!m_isUVdefault) { Wmat[0][0]=m_UProj[0]; Wmat[1][0]=m_UProj[1]; Wmat[2][0]=m_UProj[2]; Wmat[0][1]=m_VProj[0]; Wmat[1][1]=m_VProj[1]; Wmat[2][1]=m_VProj[2]; Wmat[0][2]=m_WProj[0]; Wmat[1][2]=m_WProj[1]; Wmat[2][2]=m_WProj[2]; }
in MDEvents::MDWSTransform::buildQTrahsf. I need the Wmat object NOT what is defined at the bottom of that function.
Also, what gets written into files is all messed up even if I use the identity transform in ConvertToMD. However, I think this is due to my expectation for the W matrix not being the above.
comment:30 Changed 7 years ago by Michael Reuter
BTW, there was already a way to get the W transform matrix: API::MDGeometry::getWTransf().
comment:32 Changed 7 years ago by Alex Buts
refs #6852 Small changes to unit tests
Changeset: 9ae30d2bbb8b2012c13333011123b91146949418
comment:33 Changed 7 years ago by Alex Buts
refs #6852 Small changes to unit tests
Changeset: 9ae30d2bbb8b2012c13333011123b91146949418
comment:34 Changed 7 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
main commit to this ticket have erroneously gone under refs #6449.
Let's leave WTransf on Geometry alone -- The ticket #5982 should deal with different definitions of different transformations, bearing in mind that similar transformation is defined on MDGeometry using projection vectors. I would probably deal with this ticket after #6865 to understand/incorporate all changes introduced by it.
Meanwhile, correct W-transformation is added to logs as W_MATRIX. The previous matrix (which can also be useful) remaining in the experiment info as RUBW transformation.
comment:35 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
This now does what I expect and I see sensible things in files that I write. I can see things coming back when I read them, but can't see the array property in python. I've opened a ticket (#6919) on this, but notice it is for next release. Thanks for getting this done.
comment:36 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 10eb402599da6fe268257bf5dde2b591507ee589
comment:37 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4
comment:38 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955
comment:39 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d
comment:40 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad
comment:41 Changed 7 years ago by Alex Buts
refs #6852 Unit test which checks that EI saved and loaded from NeXus
Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029
comment:42 Changed 7 years ago by Alex Buts
refs #6852 Small changes to unit tests
Changeset: 9ae30d2bbb8b2012c13333011123b91146949418
comment:44 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643
comment:45 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0
comment:46 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017
comment:47 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9
comment:48 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: fe91008945a43c9957cbe3f3324d619729843a77
comment:49 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 10eb402599da6fe268257bf5dde2b591507ee589
comment:50 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4
comment:51 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955
comment:52 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d
comment:53 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad
comment:54 Changed 7 years ago by Alex Buts
refs #6852 Unit test which checks that EI saved and loaded from NeXus
Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029
comment:55 Changed 7 years ago by Alex Buts
refs #6852 Small changes to unit tests
Changeset: 9ae30d2bbb8b2012c13333011123b91146949418
comment:56 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 10eb402599da6fe268257bf5dde2b591507ee589
comment:57 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4
comment:58 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955
comment:59 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d
comment:60 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad
comment:61 Changed 7 years ago by Alex Buts
refs #6852 Unit test which checks that EI saved and loaded from NeXus
Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029
comment:62 Changed 7 years ago by Alex Buts
refs #6852 Small changes to unit tests
Changeset: 9ae30d2bbb8b2012c13333011123b91146949418
comment:63 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643
comment:64 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0
comment:65 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017
comment:66 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9
comment:67 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: fe91008945a43c9957cbe3f3324d619729843a77
comment:68 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643
comment:69 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0
comment:70 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017
comment:71 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9
comment:72 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: fe91008945a43c9957cbe3f3324d619729843a77
comment:73 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 10eb402599da6fe268257bf5dde2b591507ee589
comment:74 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4
comment:75 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955
comment:76 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d
comment:77 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad
comment:78 Changed 7 years ago by Alex Buts
refs #6852 Unit test which checks that EI saved and loaded from NeXus
Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029
comment:79 Changed 7 years ago by Alex Buts
refs #6852 Small changes to unit tests
Changeset: 9ae30d2bbb8b2012c13333011123b91146949418
comment:80 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 10eb402599da6fe268257bf5dde2b591507ee589
comment:81 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4
comment:82 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955
comment:83 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d
comment:84 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad
comment:85 Changed 7 years ago by Alex Buts
refs #6852 Unit test which checks that EI saved and loaded from NeXus
Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029
comment:86 Changed 7 years ago by Alex Buts
refs #6852 Small changes to unit tests
Changeset: 9ae30d2bbb8b2012c13333011123b91146949418
comment:87 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643
comment:88 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0
comment:89 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017
comment:90 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9
comment:91 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: fe91008945a43c9957cbe3f3324d619729843a77
comment:92 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 808078480cf1bcee19c264aec5cccb0a0da36643
comment:93 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 8d84141371439aa7de6c7a298955a657da40f5d0
comment:94 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: 6b0f6e886c9bcf105c5ef8e2697b00c80514f017
comment:95 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: f1074a2ce61888e5ba4d97a3cf050fe5f7cd95d9
comment:96 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: fe91008945a43c9957cbe3f3324d619729843a77
comment:97 Changed 7 years ago by Alex Buts
refs #6852 Should solve the ticket
in theory. Test are still needed.
Changeset: 10eb402599da6fe268257bf5dde2b591507ee589
comment:98 Changed 7 years ago by Alex Buts
refs #6852 Unit tests for exporting W-matrix
Does not compile yet as matrix property is not implemented properly yet.
Changeset: 26a833c26c4b81c050b9a9e7fb6a1ed1fbc439f4
comment:99 Changed 7 years ago by Alex Buts
refs #6852 W_matrix is the workspace property and can be retrieved
tests show that.
Changeset: f24d4e20eb7915bd4919c7a3815a543a71132955
comment:100 Changed 7 years ago by Alex Buts
refs #6852 A bit more tests
Changeset: 5d8038fa61aae922a785ce035fda5892fd8cc88d
comment:101 Changed 7 years ago by Alex Buts
refs #6852 Stupid warning on Linux
Changeset: e32e05bde3d2797bcb56e3c616f258bcebf219ad
comment:102 Changed 7 years ago by Alex Buts
refs #6852 Unit test which checks that EI saved and loaded from NeXus
Changeset: 6df695b2bb6497ddbeb64820a66f25f2012df029
comment:103 Changed 7 years ago by Alex Buts
refs #6852 Small changes to unit tests
Changeset: 9ae30d2bbb8b2012c13333011123b91146949418
comment:104 Changed 7 years ago by Andrei Savici
Merge branch 'feature/6857_autoreduction_helpers' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:105 Changed 7 years ago by Martyn Gigg
Merge branch 'feature/6202_remove_script_console' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:106 Changed 7 years ago by Owen Arnold
Merge branch 'bugfix/6859_ignore_paths' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:107 Changed 7 years ago by Alex Buts
Merge branch 'feature/6852_WMatrixAvailibleOnWorkspace' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:108 Changed 7 years ago by Alex Buts
Merge branch 'feature/6852_WMatrixAvailibleOnWorkspace' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:109 Changed 7 years ago by Andrei Savici
Merge branch 'feature/6857_autoreduction_helpers' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:110 Changed 7 years ago by Martyn Gigg
Merge branch 'feature/6202_remove_script_console' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:111 Changed 7 years ago by Owen Arnold
Merge branch 'bugfix/6859_ignore_paths' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:112 Changed 7 years ago by Alex Buts
Merge branch 'feature/6852_WMatrixAvailibleOnWorkspace' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:113 Changed 7 years ago by Alex Buts
Merge branch 'feature/6852_WMatrixAvailibleOnWorkspace' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:114 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7698
It should also be checked that the W matrix survives MergeMD too.