Ticket #6854 (closed: fixed)
Deprecate LoadDAE and replace gui options
Reported by: | Nick Draper | Owned by: | Roman Tolchenov |
---|---|---|---|
Priority: | critical | Milestone: | Release 2.5 |
Component: | Mantid | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Russell Taylor |
Description
We believe that LoadLive data is more trustworthy than LoadDAE now and going forward.
Mark LoadDAE as deprecated, and replace in GUI controls with a call to StartLiveData.
Places I can think of:
- The from DAE drop down from the load button (rename as Live Data)
- I'm not sure there are any others
Change History
comment:1 Changed 7 years ago by Nick Draper
- Summary changed from Deprecate LoadDAW and replace gui options to Deprecate LoadDAE and replace gui options
comment:3 Changed 7 years ago by Roman Tolchenov
Deprecated LoadDAE. Re #6854.
Changeset: b5315667821ae05d179bc07947f908b612873aba
comment:4 Changed 7 years ago by Roman Tolchenov
- Status changed from accepted to verify
- Resolution set to fixed
Branch
feature/6854_deprecate_loadDAE
comment:5 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from verifying to reopened
- Resolution fixed deleted
A couple of really easy additions would be good here, I think:
- A call to the DeprecatedAlgorithm::useAlgorithm method to say to use StartLiveData instead (and maybe one to the deprecatedDate method as well).
- A unit test that casts LoadDAE to DeprecatedAlgorithm to ensure that there's never an accidental regression.
comment:8 Changed 7 years ago by Roman Tolchenov
Added the deprecation message parameters and the unit test. Re #6854.
Changeset: 90cbfc87d7359212bde95bb99d70a2ef2c0e0e01
comment:9 Changed 7 years ago by Roman Tolchenov
Added the deprecation message parameters and the unit test. Re #6854.
Changeset: 90cbfc87d7359212bde95bb99d70a2ef2c0e0e01
comment:10 Changed 7 years ago by Roman Tolchenov
- Status changed from accepted to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Roman Tolchenov
Deprecated LoadDAE. Re #6854.
Changeset: b5315667821ae05d179bc07947f908b612873aba
comment:13 Changed 7 years ago by Roman Tolchenov
Added the deprecation message parameters and the unit test. Re #6854.
Changeset: 90cbfc87d7359212bde95bb99d70a2ef2c0e0e01
comment:14 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
Looks good. Deprecation message observed and the shortcut now correctly launches StartLiveData.
comment:15 Changed 7 years ago by Roman Tolchenov
Deprecated LoadDAE. Re #6854.
Changeset: b5315667821ae05d179bc07947f908b612873aba
comment:16 Changed 7 years ago by Roman Tolchenov
Added the deprecation message parameters and the unit test. Re #6854.
Changeset: 90cbfc87d7359212bde95bb99d70a2ef2c0e0e01
comment:17 Changed 7 years ago by Roman Tolchenov
Deprecated LoadDAE. Re #6854.
Changeset: b5315667821ae05d179bc07947f908b612873aba
comment:18 Changed 7 years ago by Roman Tolchenov
Added the deprecation message parameters and the unit test. Re #6854.
Changeset: 90cbfc87d7359212bde95bb99d70a2ef2c0e0e01
comment:19 Changed 7 years ago by Roman Tolchenov
Deprecated LoadDAE. Re #6854.
Changeset: b5315667821ae05d179bc07947f908b612873aba
comment:20 Changed 7 years ago by Roman Tolchenov
Added the deprecation message parameters and the unit test. Re #6854.
Changeset: 90cbfc87d7359212bde95bb99d70a2ef2c0e0e01
comment:21 Changed 7 years ago by Roman Tolchenov
Deprecated LoadDAE. Re #6854.
Changeset: b5315667821ae05d179bc07947f908b612873aba
comment:22 Changed 7 years ago by Roman Tolchenov
Added the deprecation message parameters and the unit test. Re #6854.
Changeset: 90cbfc87d7359212bde95bb99d70a2ef2c0e0e01
comment:23 Changed 7 years ago by Roman Tolchenov
Deprecated LoadDAE. Re #6854.
Changeset: b5315667821ae05d179bc07947f908b612873aba
comment:24 Changed 7 years ago by Roman Tolchenov
Added the deprecation message parameters and the unit test. Re #6854.
Changeset: 90cbfc87d7359212bde95bb99d70a2ef2c0e0e01
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7700