Ticket #6862 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add unit test to CreateLeBailFitInput and use LoadFullprofFile

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 3.0
Component: Diffraction Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description (last modified by Wenduo Zhou) (diff)

  1. Add unit test to python algorithm CreateLeBailFitInput.
  2. Use algorithm "LoadFullprofFile" to replace the codes to load and parse fullprof's .hkl file in CreateLeBailFitInput.

Attachments

2011B_HR60b2.irf (841 bytes) - added by Wenduo Zhou 7 years ago.
LB4853b2.hkl (22.1 KB) - added by Wenduo Zhou 7 years ago.
PG3_11486-2.dat (300.7 KB) - added by Wenduo Zhou 7 years ago.
verify_6862.py (6.3 KB) - added by Wenduo Zhou 7 years ago.

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:5 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:6 Changed 7 years ago by Nick Draper

  • Keywords Maintenance added
  • Priority changed from major to critical

comment:7 Changed 7 years ago by Wenduo Zhou

  • Description modified (diff)
  • Milestone changed from Release 2.6 to Release 3.0

comment:8 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to inprogress

comment:9 Changed 7 years ago by Wenduo Zhou

Implemented unit test of CreateLeBailFitInput. Refs #6862.

  1. Added the unit test files
  2. Added 2 files for unit test to AutoTestData

Changeset: 328c5b7a76176345b7d40a76a76a29c1181bc78c

comment:10 Changed 7 years ago by Wenduo Zhou

Called LoadFullprofFile instead. Refs #6862.

Changeset: fea28f68edc6c890f4701762a0191ced996e9016

comment:11 Changed 7 years ago by Wenduo Zhou

How to verify

  1. Download all the files attached in this ticket;
  2. Run script verify_6862.py before merging the branch to master;
  3. Check workspace 'BraggPeakParameterTable_Raw for number of rows. Take a look at the first 3 spectra of output workspace PG3_11486_Guessed;
  4. Merge the branch to master;
  5. Run script verify_6862.py again;
  6. Check whether the number of rows in workspace 'BraggPeakParameterTable_Raw' is the same as before. Look at the spectra 1 to 3 of 'PG3_11486_Guessed'. It should be same as the previous one. It is because the only change to the python algorithm is to use LoadFullprofFile() to replace a method, which does the same work.
  7. Check to see whether the unit test of CreateLeBailFitInput exists and passes.
Last edited 7 years ago by Wenduo Zhou (previous) (diff)

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

Changed 7 years ago by Wenduo Zhou

comment:12 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:13 Changed 7 years ago by Wenduo Zhou

Fixed the unit test for a more general case. Refs #6862.

Changeset: 0ce09021dff6b43075e36bac0e64bfa82d45a4df

comment:14 Changed 7 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:15 Changed 7 years ago by Jay Rainey

Testing

  1. CreateLeBailFitInput test exists and passes (As do all other tests).
  2. LoadFullprofFile is now used successfully to load and parse fullprof's .hkl file.
  3. Tested on Ununtu 12.04.

Code review

  • Clean, and well written code.

comment:16 Changed 7 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/6862_add_unit_test'

comment:17 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7708

Note: See TracTickets for help on using tickets.