Ticket #6862 (closed: fixed)
Add unit test to CreateLeBailFitInput and use LoadFullprofFile
Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.0 |
Component: | Diffraction | Keywords: | Maintenance |
Cc: | Blocked By: | ||
Blocking: | Tester: | Jay Rainey |
Description (last modified by Wenduo Zhou) (diff)
- Add unit test to python algorithm CreateLeBailFitInput.
- Use algorithm "LoadFullprofFile" to replace the codes to load and parse fullprof's .hkl file in CreateLeBailFitInput.
Attachments
Change History
comment:6 Changed 7 years ago by Nick Draper
- Keywords Maintenance added
- Priority changed from major to critical
comment:7 Changed 7 years ago by Wenduo Zhou
- Description modified (diff)
- Milestone changed from Release 2.6 to Release 3.0
comment:9 Changed 7 years ago by Wenduo Zhou
Implemented unit test of CreateLeBailFitInput. Refs #6862.
- Added the unit test files
- Added 2 files for unit test to AutoTestData
Changeset: 328c5b7a76176345b7d40a76a76a29c1181bc78c
comment:10 Changed 7 years ago by Wenduo Zhou
Called LoadFullprofFile instead. Refs #6862.
Changeset: fea28f68edc6c890f4701762a0191ced996e9016
comment:11 Changed 7 years ago by Wenduo Zhou
How to verify
- Download all the files attached in this ticket;
- Run script verify_6862.py before merging the branch to master;
- Check workspace 'BraggPeakParameterTable_Raw for number of rows. Take a look at the first 3 spectra of output workspace PG3_11486_Guessed;
- Merge the branch to master;
- Run script verify_6862.py again;
- Check whether the number of rows in workspace 'BraggPeakParameterTable_Raw' is the same as before. Look at the spectra 1 to 3 of 'PG3_11486_Guessed'. It should be same as the previous one. It is because the only change to the python algorithm is to use LoadFullprofFile() to replace a method, which does the same work.
- Check to see whether the unit test of CreateLeBailFitInput exists and passes.
comment:12 Changed 7 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:13 Changed 7 years ago by Wenduo Zhou
Fixed the unit test for a more general case. Refs #6862.
Changeset: 0ce09021dff6b43075e36bac0e64bfa82d45a4df
comment:14 Changed 7 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:15 Changed 7 years ago by Jay Rainey
Testing
- CreateLeBailFitInput test exists and passes (As do all other tests).
- LoadFullprofFile is now used successfully to load and parse fullprof's .hkl file.
- Tested on Ununtu 12.04.
Code review
- Clean, and well written code.
comment:16 Changed 7 years ago by Jay Rainey
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/6862_add_unit_test'
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7708
Note: See
TracTickets for help on using
tickets.