Ticket #6866 (closed: fixed)
Update MantidEV to use new parameter names for OptimizeCrystalPlacement
Reported by: | Dennis Mikkelson | Owned by: | Dennis Mikkelson |
---|---|---|---|
Priority: | major | Milestone: | Release 2.5 |
Component: | Mantid | Keywords: | |
Cc: | mikkelsonr@…, petersonpf@…, lynchve@… | Blocked By: | |
Blocking: | Tester: | Martyn Gigg |
Description
The names of several parameters to OptimizeCrystalPlacement were changed. As a result, the property names used by MantidEV when setting parameters to call OptimizeCrystalPlacement need to be updated to match, to avoid an exception when MantidEV trys to set those parameters.
Attachments
Change History
comment:2 Changed 7 years ago by Dennis Mikkelson
RE 6866, Update property names used in MantidEV
The property names of parameters passed to OptimizeCrystalPlacement are now updated to the new parameter names. Fixed some Doxygen warnings. Adjusted some labels on the GUI to be clearer, based on comments from potential users.
refs #6866
Changeset: a85a35972554348a2d6e6e1f6d2c05307964ca58
comment:3 Changed 7 years ago by Dennis Mikkelson
RE 6866, Update property names used in MantidEV
The property names of parameters passed to OptimizeCrystalPlacement are now updated to the new parameter names. Fixed some Doxygen warnings. Adjusted some labels on the GUI to be clearer, based on comments from potential users.
refs #6866
Changeset: a85a35972554348a2d6e6e1f6d2c05307964ca58
comment:4 Changed 7 years ago by Dennis Mikkelson
RE 6866, Fix MantidEV property names
Also fixed some errors in OptimizeCrystalPlacement, and tweaked parameters passed in from MantidEV.
refs #6866
Changeset: 7e439fa6ef61534ef7d316aa6b3573943f2be60c
comment:5 Changed 7 years ago by Dennis Mikkelson
RE 6866, Fix MantidEV property names
Also fixed some errors in OptimizeCrystalPlacement, and tweaked parameters passed in from MantidEV.
refs #6866
Changeset: 7e439fa6ef61534ef7d316aa6b3573943f2be60c
Changed 7 years ago by Dennis Mikkelson
- Attachment TOPAZ_3007_BROKEN.peaks added
Similar to TOPAZ_3007.peaks in AutoTestData, but goniometer angles altered
comment:6 Changed 7 years ago by Dennis Mikkelson
- Status changed from accepted to verify
- Resolution set to fixed
NOTES TO TESTER:
1.The branch is: feature/6866_FixMantidEVPropertyNames
2.The attached file, TOPAZ_3007_BROKEN.peaks is a modified version of the file TOPAZ_3007.peaks in the AutoTestData directory. The goniometer angles have all be altered slightly.
To Test:
--Bring up the "SCD Event Data Reduction" interface (aka. MantidEV).
--Switch to the second tab, Find Peaks, enter a name for the peaks workspace, select "Load ISAW Peaks(or Integrate) File, and select the attached TOPAZ_3007_BROKEN.peaks file. Press Apply.
--Switch to the third tab, Find UB, and select "Load Isaw UB" and select the file TOPAZ_3007.mat from the AutoTestData directory. Also, turn on the "Optimize Phi, Chi and Omega", and the "Index Peaks Using UB" options. Press Apply.
The results log should show that only 5 peaks were originally indexed by the matrix, with the bad goniometer angles, but after the optimization and indexing, all 43 peaks were indexed.
comment:7 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:8 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Tested steps and they work as advertised. Also then tried a few of the other methods on there for finding the UB and they also still work as promised.
comment:9 Changed 7 years ago by Dennis Mikkelson
RE 6866, Update property names used in MantidEV
The property names of parameters passed to OptimizeCrystalPlacement are now updated to the new parameter names. Fixed some Doxygen warnings. Adjusted some labels on the GUI to be clearer, based on comments from potential users.
refs #6866
Changeset: a85a35972554348a2d6e6e1f6d2c05307964ca58
comment:10 Changed 7 years ago by Dennis Mikkelson
RE 6866, Fix MantidEV property names
Also fixed some errors in OptimizeCrystalPlacement, and tweaked parameters passed in from MantidEV.
refs #6866
Changeset: 7e439fa6ef61534ef7d316aa6b3573943f2be60c
comment:11 Changed 7 years ago by Dennis Mikkelson
RE 6866, Update property names used in MantidEV
The property names of parameters passed to OptimizeCrystalPlacement are now updated to the new parameter names. Fixed some Doxygen warnings. Adjusted some labels on the GUI to be clearer, based on comments from potential users.
refs #6866
Changeset: a85a35972554348a2d6e6e1f6d2c05307964ca58
comment:12 Changed 7 years ago by Dennis Mikkelson
RE 6866, Fix MantidEV property names
Also fixed some errors in OptimizeCrystalPlacement, and tweaked parameters passed in from MantidEV.
refs #6866
Changeset: 7e439fa6ef61534ef7d316aa6b3573943f2be60c
comment:13 Changed 7 years ago by Dennis Mikkelson
RE 6866, Update property names used in MantidEV
The property names of parameters passed to OptimizeCrystalPlacement are now updated to the new parameter names. Fixed some Doxygen warnings. Adjusted some labels on the GUI to be clearer, based on comments from potential users.
refs #6866
Changeset: a85a35972554348a2d6e6e1f6d2c05307964ca58
comment:14 Changed 7 years ago by Dennis Mikkelson
RE 6866, Fix MantidEV property names
Also fixed some errors in OptimizeCrystalPlacement, and tweaked parameters passed in from MantidEV.
refs #6866
Changeset: 7e439fa6ef61534ef7d316aa6b3573943f2be60c
comment:15 Changed 7 years ago by Dennis Mikkelson
RE 6866, Update property names used in MantidEV
The property names of parameters passed to OptimizeCrystalPlacement are now updated to the new parameter names. Fixed some Doxygen warnings. Adjusted some labels on the GUI to be clearer, based on comments from potential users.
refs #6866
Changeset: a85a35972554348a2d6e6e1f6d2c05307964ca58
comment:16 Changed 7 years ago by Dennis Mikkelson
RE 6866, Fix MantidEV property names
Also fixed some errors in OptimizeCrystalPlacement, and tweaked parameters passed in from MantidEV.
refs #6866
Changeset: 7e439fa6ef61534ef7d316aa6b3573943f2be60c
comment:17 Changed 7 years ago by Dennis Mikkelson
RE 6866, Update property names used in MantidEV
The property names of parameters passed to OptimizeCrystalPlacement are now updated to the new parameter names. Fixed some Doxygen warnings. Adjusted some labels on the GUI to be clearer, based on comments from potential users.
refs #6866
Changeset: a85a35972554348a2d6e6e1f6d2c05307964ca58
comment:18 Changed 7 years ago by Dennis Mikkelson
RE 6866, Fix MantidEV property names
Also fixed some errors in OptimizeCrystalPlacement, and tweaked parameters passed in from MantidEV.
refs #6866
Changeset: 7e439fa6ef61534ef7d316aa6b3573943f2be60c
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7712