Ticket #6904 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Extract mask to a table workspace

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: petersonpf@… Blocked By:
Blocking: Tester: Vickie Lynch

Description (last modified by Wenduo Zhou) (diff)

SNAP needs one feature in the mask tab:

The option to generate a masking table workspace (using currently visable x-range). It will be used with MaskBinsFromTable.

The task includes 2 parts, including implementing an algorithm ExtractMaskToTable and adding this to instrument masking tab in MantidPlot.

Change History

comment:1 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to accepted
  • Description modified (diff)

comment:2 Changed 7 years ago by Wenduo Zhou

Implementing ExtractMaskToTable (in progress). Refs #6904.

Changeset: d0c51ffed83d873777f9f55b6dc3855935304571

comment:3 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6904.

Changeset: be9c03d88e182d0077685244368f46a26853b6f2

comment:4 Changed 7 years ago by Wenduo Zhou

Checkpointing Work. Refs #6904.

  1. Complete function addToTableWorkspace.
  2. Add 3 unit tests. Changeset: a23de05a265249a50dd874be8171487e8ecf4b47

comment:5 Changed 7 years ago by Wenduo Zhou

Implementing ExtractMaskToTable (in progress). Refs #6904.

Changeset: d0c51ffed83d873777f9f55b6dc3855935304571

comment:6 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6904.

Changeset: be9c03d88e182d0077685244368f46a26853b6f2

comment:7 Changed 7 years ago by Wenduo Zhou

Checkpointing Work. Refs #6904.

  1. Complete function addToTableWorkspace.
  2. Add 3 unit tests. Changeset: a23de05a265249a50dd874be8171487e8ecf4b47

comment:8 Changed 7 years ago by Wenduo Zhou

Complete implementing the algorithm and unit tests. Refs #6904.

Changeset: 22f0a624763d709936f5d7c240bf67625477756d

comment:9 Changed 7 years ago by Wenduo Zhou

Complete implementing the algorithm and unit tests. Refs #6904.

Changeset: 22f0a624763d709936f5d7c240bf67625477756d

comment:10 Changed 7 years ago by Wenduo Zhou

Add support to MaskWorkspace. Refs #6904.

Changeset: d71f0dbc05cd73bc29acca6759611e48c6820668

comment:11 Changed 7 years ago by Wenduo Zhou

Add 'save mask to table'. Refs #6904.

Changeset: a5c910375665be7042479e044da83c059fef6134

comment:12 Changed 7 years ago by Wenduo Zhou

Implementing ExtractMaskToTable (in progress). Refs #6904.

Changeset: d0c51ffed83d873777f9f55b6dc3855935304571

comment:13 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6904.

Changeset: be9c03d88e182d0077685244368f46a26853b6f2

comment:14 Changed 7 years ago by Wenduo Zhou

Checkpointing Work. Refs #6904.

  1. Complete function addToTableWorkspace.
  2. Add 3 unit tests. Changeset: a23de05a265249a50dd874be8171487e8ecf4b47

comment:15 Changed 7 years ago by Wenduo Zhou

Complete implementing the algorithm and unit tests. Refs #6904.

Changeset: 22f0a624763d709936f5d7c240bf67625477756d

comment:16 Changed 7 years ago by Wenduo Zhou

Implementing ExtractMaskToTable (in progress). Refs #6904.

Changeset: d0c51ffed83d873777f9f55b6dc3855935304571

comment:17 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6904.

Changeset: be9c03d88e182d0077685244368f46a26853b6f2

comment:18 Changed 7 years ago by Wenduo Zhou

Checkpointing Work. Refs #6904.

  1. Complete function addToTableWorkspace.
  2. Add 3 unit tests. Changeset: a23de05a265249a50dd874be8171487e8ecf4b47

comment:19 Changed 7 years ago by Wenduo Zhou

Complete implementing the algorithm and unit tests. Refs #6904.

Changeset: 22f0a624763d709936f5d7c240bf67625477756d

comment:20 Changed 7 years ago by Wenduo Zhou

Implementing ExtractMaskToTable (in progress). Refs #6904.

Changeset: d0c51ffed83d873777f9f55b6dc3855935304571

comment:21 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6904.

Changeset: be9c03d88e182d0077685244368f46a26853b6f2

comment:22 Changed 7 years ago by Wenduo Zhou

Checkpointing Work. Refs #6904.

  1. Complete function addToTableWorkspace.
  2. Add 3 unit tests. Changeset: a23de05a265249a50dd874be8171487e8ecf4b47

comment:23 Changed 7 years ago by Wenduo Zhou

Complete implementing the algorithm and unit tests. Refs #6904.

Changeset: 22f0a624763d709936f5d7c240bf67625477756d

comment:24 Changed 7 years ago by Wenduo Zhou

Make MaskBinsFromTable work with mask tab window. Refs #6904.

  1. Refactor the code to make it more flexible to read TableWorkspace.
  2. Enable the algorithm to read in DetectorID list other than

SpectraList

  1. Add unit test for new feature. Changeset: 50faff978d70ad379009767e1fc0ebc58e96e28d

comment:25 Changed 7 years ago by Wenduo Zhou

Change output workspace space column name. Refs #6904.

Changeset: 8d558366ad845b46d0d9ef12a81a1bbdc02abae2

comment:26 Changed 7 years ago by Wenduo Zhou

Add support to MaskWorkspace. Refs #6904.

Changeset: d71f0dbc05cd73bc29acca6759611e48c6820668

comment:27 Changed 7 years ago by Wenduo Zhou

Add 'save mask to table'. Refs #6904.

Changeset: a5c910375665be7042479e044da83c059fef6134

comment:28 Changed 7 years ago by Wenduo Zhou

Make MaskBinsFromTable work with mask tab window. Refs #6904.

  1. Refactor the code to make it more flexible to read TableWorkspace.
  2. Enable the algorithm to read in DetectorID list other than

SpectraList

  1. Add unit test for new feature. Changeset: 50faff978d70ad379009767e1fc0ebc58e96e28d

comment:29 Changed 7 years ago by Wenduo Zhou

Change output workspace space column name. Refs #6904.

Changeset: 8d558366ad845b46d0d9ef12a81a1bbdc02abae2

comment:30 Changed 7 years ago by Wenduo Zhou

Unit test failed on Mac. Use std::set_symmetric_difference to replace subtractVector() to avoid the failure.

comment:31 Changed 7 years ago by Russell Taylor

In fact, I think it's set_difference that you want.

comment:32 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6918_correct_error' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:33 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6802_first_time_setup_on_top' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:34 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6904_mask_to_table' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:35 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6904_mask_to_table' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:36 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6371_step_scan_gui' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:37 Changed 7 years ago by Dennis Mikkelson

Merge branch 'feature/6901_MantidEV_usability' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:38 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6904_mask_to_table' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:39 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6918_correct_error' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:40 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6802_first_time_setup_on_top' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:41 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6904_mask_to_table' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:42 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6904_mask_to_table' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:43 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6371_step_scan_gui' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:44 Changed 7 years ago by Dennis Mikkelson

Merge branch 'feature/6901_MantidEV_usability' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:45 Changed 7 years ago by Wenduo Zhou

Merge branch 'feature/6904_mask_to_table' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:46 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

Instruction for Verification

  1. Find CNCS_7860_event.nxs in Mantid/Test/AutoTestData
  2. Run the script as below Load(Filename=r'CNCS_7860_event.nxs',OutputWorkspace='CNCS_7860_event') SumNeighbours(InputWorkspace='CNCS_7860_event',OutputWorkspace='CNCS_7860_event',SumX='2',SumY='2')
  3. Show instrument of workspace CNCS_7860_event
  4. Pick an area to mask
  5. In button 'Apply and Save', choose 'As Mask To Table'. Then a table workspace "MaskBinTable" will be generated.
  6. You can also change the values for Time-of-flight range. The masked bin will use the value that you choose.
  7. Repeat step 4 to 6 to mask another region. A new row will be appended to TableWorkspace "MaskBinTable".
  8. You can also call "ExtractMaskToTable" to check whether GUI and command line give out same result.
Last edited 7 years ago by Wenduo Zhou (previous) (diff)

comment:47 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:48 Changed 7 years ago by Vickie Lynch

Will test after you run "git checkbuild"

comment:49 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I did run checkbuild and the tests are OK. I followed your instructions and somehow get a SegFault using ExtractMaskToTable on a workspace that has already been saved "As Mask To Table". Not sure if this is a problem for this ticket but am failing anyway for you to test.

comment:50 Changed 7 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:51 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

The problem reported cannot be reproduced.

comment:52 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying

comment:53 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

Verification steps work

comment:54 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:55 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7750

Note: See TracTickets for help on using tickets.