Ticket #6906 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove the mantid logo from QTI tables

Reported by: Anders Markvardsen Owned by: Nick Draper
Priority: critical Milestone: Release 2.6
Component: MantidPlot Keywords:
Cc: james.lord@… Blocked By:
Blocking: Tester: Russell Taylor

Description (last modified by Nick Draper) (diff)

  1. Open a QTI table
  1. Insert some numbers
  1. Execute Table -> 'Convert to TableWorkspace'

you are now left which nearly identical tables, where it is very hard to tell which one is which.

Here the suggestion is to remove the Mantid logo from the QTI table to give a user a better change to know which one is which.

Attachments

WrongNewIcon.png​ (8.4 KB) - added by Gesner Passos 7 years ago.

Change History

comment:1 Changed 7 years ago by Anders Markvardsen

  • Cc james.lord@… added

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Roman Tolchenov

comment:4 Changed 7 years ago by Roman Tolchenov

  • Status changed from assigned to accepted

comment:5 Changed 7 years ago by Roman Tolchenov

Set table icon to qtiplot table. Re #6906.

Changeset: 0572a9215327bda381e769ccd037d446444526b8

comment:6 Changed 7 years ago by Roman Tolchenov

Set table icon to qtiplot table. Re #6906.

Changeset: 0572a9215327bda381e769ccd037d446444526b8

comment:7 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Russell Taylor

Re #6906. Remove unused variable (gcc compiler warning).

Changeset: 64b9476dd9c01849df2be0ec39970249df1325ac

comment:9 Changed 7 years ago by Russell Taylor

Re #6906. Remove unused variable (gcc compiler warning).

Changeset: 64b9476dd9c01849df2be0ec39970249df1325ac

comment:10 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

Changed 7 years ago by Gesner Passos

comment:11 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

this also changes the icon for new->table which it should not. See the attached image.

comment:12 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:13 Changed 7 years ago by Roman Tolchenov

Forgot to change back my testing code. Re #6906.

Changeset: 1266054f0b70f5d7101146385d49c71cee6f38d3

comment:14 Changed 7 years ago by Roman Tolchenov

Getting back missing pixmap. Re #6906.

Changeset: d7fde2aba5b961896b1fa42054b5193167dab93f

comment:15 Changed 7 years ago by Roman Tolchenov

Getting back missing pixmap. Re #6906.

Changeset: d7fde2aba5b961896b1fa42054b5193167dab93f

comment:16 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:17 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Gesner Passos to Martyn Gigg

comment:18 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to reopened
  • Resolution fixed deleted

It looks like the change in comment 13, ​https://github.com/mantidproject/mantid/commit/1266054f0b70f5d7101146385d49c71cee6f38d3/, has gone to develop and not to the branch.

This will require a cherry-pick of the commit from develop and NOT a merge: git checkout feature/6906_remove_mantid_logo git cherry-pick 1266054f0b70f5d7101146385d49c71cee6f38d3 git check-build

then the ticket can be reclosed.

comment:19 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/7000_function_property_type_string' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:20 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6906_remove_mantid_logo' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:21 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6906_remove_mantid_logo' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:22 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6906_remove_mantid_logo' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:23 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/7000_function_property_type_string' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:24 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6906_remove_mantid_logo' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:25 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6906_remove_mantid_logo' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:26 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6906_remove_mantid_logo' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:27 Changed 7 years ago by Roman Tolchenov

Set table icon to qtiplot table. Re #6906.

Changeset: 104d1f44d0009c154af619bc095fe6fa6bf60b90

comment:28 Changed 7 years ago by Roman Tolchenov

Forgot to change back my testing code. Re #6906.

Changeset: f340e458c7093ee37dc40dc1c391ec6364a40c03

comment:29 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to accepted

comment:30 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:31 Changed 7 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester changed from Martyn Gigg to Stuart Campbell

comment:32 Changed 7 years ago by Stuart Campbell

One issue is that on the Mac there is no icon in the corner so both tables look identical.

comment:33 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed
  • Description modified (diff)

This has sat too long on Stuart's list.

Returned to the testing pool. If this is an improvement to most environments and does not harm others it should be passed.

comment:34 Changed 7 years ago by Nick Draper

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:35 Changed 7 years ago by Nick Draper

  • Status changed from reopened to verify
  • Owner changed from Roman Tolchenov to Nick Draper
  • Resolution set to fixed

Closed by mistake, I meant to return it to the testing pool, I'll mark it as resolved again to get it into the right state.

comment:36 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester changed from Stuart Campbell to Russell Taylor

comment:37 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Note that the icons appear next to the title on the Mac.

comment:38 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7752

Note: See TracTickets for help on using tickets.