Ticket #6922 (closed: fixed)
First Mcstas loader
Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | major | Milestone: | Release 2.5 |
Component: | Mantid | Keywords: | |
Cc: | martyn.gigg@… | Blocked By: | |
Blocking: | Tester: | Russell Taylor |
Description
During a visit by Torben, Martyn and Torben added first mcstas loader for loading 'processed' mcstas data such as (weighted) integrated counts in units of meters along dimensions of a rectangular detector bank
Attachments
Change History
comment:2 Changed 7 years ago by Anders Markvardsen
use newer nexus header. re #6922
Changeset: 2a295c3c84b6ff9481db680e4a427581fa1624da
comment:3 Changed 7 years ago by Anders-Markvardsen
Update LoadMcStasNexus.cpp
Improve docomentation. re #6922
Changeset: 8466eeda4bf68ff9deaaba06f96c6d4b677602a6
comment:4 Changed 7 years ago by Anders Markvardsen
use newer nexus header. re #6922
Changeset: 2a295c3c84b6ff9481db680e4a427581fa1624da
comment:5 Changed 7 years ago by Anders Markvardsen
- Status changed from new to accepted
To test
- in mantidplot load the attached file mcstas.h5
- if a workspace created then ok
Additional documentation will be added by tuesday to this algorithm
comment:6 Changed 7 years ago by Anders Markvardsen
- Status changed from accepted to verify
- Resolution set to fixed
comment:7 Changed 7 years ago by Gesner Passos
- Status changed from verify to verifying
- Tester set to Gesner Passos
comment:8 Changed 7 years ago by Gesner Passos
- Status changed from verifying to verify
- Tester Gesner Passos deleted
I will not be able to test it.
comment:9 Changed 7 years ago by Russell Taylor
- Status changed from verify to reopened
- Resolution fixed deleted
The mcstas loader has currently broken the linux & mac builds on develop.
comment:10 Changed 7 years ago by Russell Taylor
Plus I don't see any unit test.
comment:11 Changed 7 years ago by Anders Markvardsen
additional nexus header needed for linux. re #6922
Changeset: 041ac6ebd6f0e243c7915da360796c845b5173e7
comment:12 Changed 7 years ago by Anders Markvardsen
- Status changed from reopened to accepted
note is in the process of adding unit test and this will be added first think after release
comment:13 Changed 7 years ago by Anders Markvardsen
- Status changed from accepted to verify
- Resolution set to fixed
comment:14 Changed 7 years ago by Andrei Savici
comment:15 Changed 7 years ago by Andrei Savici
Add comments. Refs #6922
Changeset: 4b1fcce3a028face6db86507fa7da28da93d4eed
comment:16 Changed 7 years ago by Andrei Savici
Add comments. Refs #6922
Changeset: 4b1fcce3a028face6db86507fa7da28da93d4eed
comment:17 Changed 7 years ago by Russell Taylor
- Status changed from verify to reopened
- Resolution fixed deleted
I'm not picking on you Anders :), but I don't think that a new algorithm should go into the release without even a rudimentary unit test. The file attached to this ticket is not large so could be added to AutoTestData and a test based on that, which shouldn't take long at all to write.
There are also 2 compiler warnings on RHEL6 from this that should be fixed before merging to keep master clean.
If it doesn't matter whether this gets into the release then the easy way out is to move the ticket to 2.6 (and add the unit test under this ticket later).
comment:18 Changed 7 years ago by Anders Markvardsen
additional nexus header needed for linux. re #6922
Changeset: 041ac6ebd6f0e243c7915da360796c845b5173e7
comment:19 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.5 to Release 2.6
comment:20 Changed 7 years ago by Anders Markvardsen
Add unit test and wiki documentation. re #6922
Also removed compiler errors
Changeset: 729f2bf35f74a7950c976c07225ac994c0d78b03
comment:21 Changed 7 years ago by Anders Markvardsen
Add unit test and wiki documentation. re #6922
Also removed compiler errors
Changeset: 729f2bf35f74a7950c976c07225ac994c0d78b03
comment:22 Changed 7 years ago by Anders Markvardsen
- Milestone changed from Release 2.6 to Release 2.5
comment:23 Changed 7 years ago by Anders Markvardsen
- Status changed from reopened to accepted
Russell tx for the spotting of warnings etc. Warnings deleted, unit test added and wiki been updated (for the latter tx to Torben ESS/McStas for this).
Give this ticket another go for release by:
- In Mantidplot load from AutoTestData the file mcstas.h5
you should see that a workspacegroup is created containing 4 matrixworkspace
comment:24 Changed 7 years ago by Anders Markvardsen
- Status changed from accepted to verify
- Resolution set to fixed
comment:25 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:26 Changed 7 years ago by Nick Draper
Russell, you jumped in 71 seconds before me to test this ticket. That'll teach me to take time deciding whether to take it.
comment:27 Changed 7 years ago by Anders-Markvardsen
Update LoadMcStasNexus.cpp
Improve docomentation. re #6922
Changeset: 8466eeda4bf68ff9deaaba06f96c6d4b677602a6
comment:28 Changed 7 years ago by Anders Markvardsen
use newer nexus header. re #6922
Changeset: 2a295c3c84b6ff9481db680e4a427581fa1624da
comment:29 Changed 7 years ago by Anders Markvardsen
additional nexus header needed for linux. re #6922
Changeset: 041ac6ebd6f0e243c7915da360796c845b5173e7
comment:30 Changed 7 years ago by Anders Markvardsen
Add unit test and wiki documentation. re #6922
Also removed compiler errors
Changeset: 729f2bf35f74a7950c976c07225ac994c0d78b03
comment:31 Changed 7 years ago by Andrei Savici
Add comments. Refs #6922
Changeset: 4b1fcce3a028face6db86507fa7da28da93d4eed
comment:32 Changed 7 years ago by Russell Taylor
- Status changed from verifying to closed
It works on the 'happy path' (i.e. with the file provided), both via Load & directly calling LoadMcStasNexus. When calling it directly, the algorithm appears not to check that the file is really a McStas file, so adding that is probably in order. I threw a whole bunch of different files at it and none crashed Mantid, failing instead with all sorts of different error messages (usually Nexus ones). Interestingly, with one file type - new-style SNS event nexus (ADARA) files the algorithm claims to have run successfully and leaves you with an empty group workspace.
comment:33 Changed 7 years ago by Anders-Markvardsen
Update LoadMcStasNexus.cpp
Improve docomentation. re #6922
Changeset: 8466eeda4bf68ff9deaaba06f96c6d4b677602a6
comment:34 Changed 7 years ago by Anders Markvardsen
use newer nexus header. re #6922
Changeset: 2a295c3c84b6ff9481db680e4a427581fa1624da
comment:35 Changed 7 years ago by Anders Markvardsen
additional nexus header needed for linux. re #6922
Changeset: 041ac6ebd6f0e243c7915da360796c845b5173e7
comment:36 Changed 7 years ago by Andrei Savici
Add comments. Refs #6922
Changeset: 4b1fcce3a028face6db86507fa7da28da93d4eed
comment:37 Changed 7 years ago by Anders Markvardsen
Add unit test and wiki documentation. re #6922
Also removed compiler errors
Changeset: 729f2bf35f74a7950c976c07225ac994c0d78b03
comment:38 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7768
Update LoadMcStasNexus.cpp
Improve docomentation. re #6922