Ticket #6931 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Allow appending in PlotAsymmetryByLogValue

Reported by: Anders Markvardsen Owned by: Raquel Alvarez Banos
Priority: minor Milestone: Release 3.4
Component: Muon Keywords:
Cc: james.lord@… Blocked By:
Blocking: #9214 Tester: Karl Palmen

Description

If on FirstRun or LastRun is changed between calls of PlotAymmetryByLogValue add intelligence that only do new calculations for new runs or remove runs cut out

Attachments

run_plotasymmetry.py​ (2.4 KB) - added by Raquel Alvarez Banos 5 years ago.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:3 Changed 7 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Arturs Bekasovs
  • Component changed from Framework to Muon

comment:4 Changed 7 years ago by Arturs Bekasovs

  • Summary changed from MUON: Allow appending in PlotAsymmetryByLogValue to Allow appending in PlotAsymmetryByLogValue

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:6 Changed 7 years ago by Arturs Bekasovs

  • Keywords Clarify added

It can be done in 2 ways:

  1. Implement the functionality in the dialog: store previous last-run and first-run, and append/remove as necessary.
  1. Store first-run and last-run in the resulting workspace, and if specified OutputWorkspace exists the algorithm looks for them and adds/removes as necessary.

comment:7 Changed 7 years ago by Arturs Bekasovs

  • Keywords Clarify removed
  • Priority changed from major to minor

PlotAsymmetryByLogValue will be superseded by ALC interface, so shouldn't spend time on this unless raised up again.

comment:8 Changed 6 years ago by Anders Markvardsen

related to #9214

comment:9 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Arturs Bekasovs to Anders Markvardsen
  • Keywords ALC added

ALC uses PlotAsymmetryByLogValue

comment:10 Changed 6 years ago by Anders Markvardsen

  • Blocking 9214 added

comment:11 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Raquel Alvarez Banos
  • Keywords ALC removed

Note PlotAsymmetryByLogValue is used by ALC, hence check also changes made to this algorithm does not break ALC interface

comment:12 Changed 6 years ago by Raquel Alvarez Banos

Working on this ticket I have noticed another issue for which ticket #10886 has been created.

comment:13 Changed 6 years ago by Raquel Alvarez Banos

  • Blocked By 10894 added

comment:14 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

To allow appending, all the inputs to the algorithm should stay the same between calls, i.e.

  • Calculation type ('Integral' or 'Differential')
  • Red and Green periods
  • Time Min and Max
  • Dead time corrections to apply

The exception is LogValue. If that were the only property changing, we would just need to re-draw the X axis and all the computations could be avoided. However, I am not going to consider this case in this ticket (it would probably involve refactoring), I will create a new one if scientists really need to switch from one log value to another very often.

Last edited 5 years ago by Raquel Alvarez Banos (previous) (diff)

comment:15 Changed 6 years ago by Raquel Alvarez Banos

  • Blocked By 11319 added

comment:16 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Replace vectors by maps

Changeset: c381ab4ae319ac3eeb437de0de04a8a167ac192d

comment:17 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Forgot to use the correct vectors after copy-paste

Changeset: c4ad8789e635120052e5ccdb439f7a14f7f401ad

comment:18 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Rename maps to follow convention for static member variables

Changeset: 9bb785e219ba772ef8671f601f0a161e6e07adb1

comment:19 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Make maps static

Changeset: 04caa6f876c9cf15cb09d8cbcb8e3942b197c921

comment:20 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Load only new runs

Changeset: 7d0013a846dbe2186dcf1f85e15dc5077cbc59d9

comment:21 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Write new method to check input properties

Changeset: b9853e1b73969d2b06db29cef591d1973bc691fb

comment:22 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Make m_logName static and check if it changed its value

Changeset: 844a142e09efb39767b530d86d7dac5e13c41e65

comment:23 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Make m_logFunc static and check if it changed its value

Changeset: fb81ee1de2fa43a78bf3dd3dbf2a6e20ad2885d3

comment:24 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Make stype static and check if it changed its value

Changeset: 4a7eaa101b401dd21d49b9d06cf339bf192b21c7

comment:25 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Use temporary variables to get the properties

Changeset: e36c0f97c20c0938e522baa92e41e1ce43627d68

comment:26 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Make fw and bw grouping static and check if they changed

Changeset: 4087f3ada0d7adaea2d2c36e538d7cf656b71058

comment:27 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Make red and green periods static and check if they changed

Changeset: 8648f4114c44710fb83b1ef7a5ef62bc9194abca

comment:28 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Make dtcType static and check if it changed its value

Changeset: bc9208505617ad185a60c34b698303090b89605e

comment:29 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Make dtcFile static and check if it changed its value

Changeset: e4bf11be1d340def053ee47ed939e9945b4d022b

comment:30 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Make file basename, extension and number of zeros static

Changeset: b63868d979e572ab6105a5a288eb7b611fb0e8dd

comment:31 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Check file basename, extension and number of zeros

Changeset: 36e15fb647b14ea3259bfdd1bb30c41ab4ebe9b5

comment:32 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Pass first and last run by reference

Changeset: fde0fd04d85eb354ab1705f8578c36350bcc3831

comment:33 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Add method to clear previous results

Changeset: 673a681dd996568d53fdbecce0935cc4ea2ebf7a

comment:34 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Rename and update method

Changeset: 36fa16bd86f3c141931aeae46540ea5993be7de8

comment:35 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Check properties if previous results exist

Changeset: fe0027caf3cd3220e76fee449c90eaf5ed9b6120

comment:36 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Remove runs when necessary

Changeset: d00c17cd068105467094bd11ee617ec251e77cdb

comment:37 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Adding some comments

Changeset: 8d324bd60907ec449d1be364eec168d30a501c03

comment:38 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Forgot about TimeMin and TimeMax, they should also be static

Changeset: 7805a1d0bb11aebe233d03b7a01bf3c693275e3d

comment:39 Changed 5 years ago by Raquel Alvarez

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #641.

Changed 5 years ago by Raquel Alvarez Banos

comment:40 Changed 5 years ago by Raquel Alvarez Banos

  • Blocked By 10894, 11319 removed
  • Milestone changed from Backlog to Release 3.4

I have attached a script I have been using to test the changes, which the tester may find useful. It includes descriptions (comments) of what I would expect in each successive execution of the algorithm.

comment:41 Changed 5 years ago by Martyn Gigg

Some conflicts with master have arisen.

comment:42 Changed 5 years ago by Raquel Alvarez Banos

Re #6931 Fix conflicts with master

Changeset: 44c53b1b90c71732f5f1f805f9117a068a355e02

comment:43 Changed 5 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:44 Changed 5 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge pull request #641 from mantidproject/6931_Allow_appending_in_PlotAsymmetryByLogValue

Allow appending in PlotAsymmetryByLogValue

Full changeset: ​e07584d05e93ccea710cdc749f197903c0294c80

comment:45 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7777

Note: See TracTickets for help on using tickets.