Paraview Setup MantidPlot

[Owen Arnold]

For 3.10, we introduced a dialog into mantid plot that would allow the user to specify where mantid plot lived, and hence allow mantidplot to dynamically add paraview onto the path. This breaks for 3.98 because the library layout has changed.

This should be easy to fix, by having it look for paraview.exe rather than pqcore in SetupParaview.cpp line 35. This change should be compatible with both 3.10 and 3.98 so It can go straight into master. This should avoid the need for the user to follow special install instructions on windows.

[Owen Arnold]

These changes can go in without #6937, because it's not technically blocking it.

[Owen Arnold]

refs #6936. Made compatible with new and old PV.

Changeset: 4d18de87070731839514155361d5b1048ef795be

[Owen Arnold]

Tester:

Here are some suggestions for testing the ticket out. These tests must be done on windows.

• Look at the line containing Compatible_Paraview_Version in CommonSetup.cmake in /Build/CMake note the paraview version
• Checkout the branch build with MAKE_VATES On
• Download and install the version of paraview that is the same as the one in CommonSetup (either 3.10 or 3.98 at the time of writing) from the Mantid download page
• Open help -> 3D visualisation setup
• Hint on the dialog should give a path that matches the version in CommonSetup.cmake
• Setting the path should work.

• Now change CommonSetup.cmake to 3.98 if it was previously 3.10 or visa-versa
• Re-run the steps above and the hint should have changed.
• The dialog will accept the new path

[Michael Reuter]

This is being merged onto the ParaView 3.98 working branch. DO NOT TOUCH! Owen, can you move this to verify state please.

[Owen Arnold]

refs #6936. Made compatible with new and old PV.

Changeset: 4d18de87070731839514155361d5b1048ef795be

[Michael Reuter]

This is now merged into the ParaView 3.98 branch.

[Michael Reuter]

Refs #6315 and #6936. Fixing version number assembly.

Changeset: 3be48cc9875b0759ecc7f3ebc25c3eceef24765e

[Owen Arnold]

Moved to verify state as requested by Michael.

[Owen Arnold]

refs #6939. PATH changes don't propegate through.

Changeset: 6d4998391b4a65c3fd09a3d81c5fe07bf5a84b25

[Owen Arnold]

refs #6939. Unused include.

Changeset: 6c7374228ee422b78595dda30818feebed668767

[Owen Arnold]

Acciedently referenced #6939 in commit refs rather than #6936

[Owen Arnold]

Tester you should ensure that the original testing steps work. Also try these on Windows after installing.

1) Remove paraview.path entirely from your user properties file. Start MantidPlot and you should see the 3D visualisation setup dialog.

2) set paraview.path= in your user properties and you should get the same results as above.

3) Start MantidPlot and using the 3D visualisation setup dialog, set the correct path to ParaView. Then Load the SEQ md file in the auto test directory. Right click and open in the VSI. Should load without problems.

[Martyn Gigg]

This has broken things on the Mac. On the Mac we don't use the setup dialog so the paraview.path is empty therefore the quickParaViewCheck fails until you set the path correctly.

In DarwinSetup the removed line

set ( PARAVIEW_APP_BIN_DIR "${PARAVIEW_APP_DIR}/Contents/MacOS" )

was actually used to populate the default mantid properties file with the correct location of the PV executable. I think we need to put the string back in the properties file and change the check for the key to check whether it is empty or not.

Could we not avoid the setup dialog on windows too if we set the path for windows also and if it works, which for most people that take the default package it will, we don't need to pop up the dialog at all?

[Owen Arnold]

refs #6936. Fix broken mac package.

Changeset: 2589d577b38b8d240c7b2cf0f9f4e8aef5f613f0

[Owen Arnold]

We can look at removing the 3D visualisation setup dialog from the start-up later. I'm hesitant to do this, because it's not a major issue, and hard-coding a location, without checking it first, will cause the VSI to crash if it's not right.

Other modifications requested have been made.

[Martyn Gigg]

That's fair. I'm happy for this to be closed now.

[Owen Arnold]

refs #6936. Fix broken mac package.

Changeset: 2589d577b38b8d240c7b2cf0f9f4e8aef5f613f0

[Owen Arnold]

refs #6936. Made compatible with new and old PV.

Changeset: 4d18de87070731839514155361d5b1048ef795be

[Michael Reuter]

Refs #6315 and #6936. Fixing version number assembly.

Changeset: 3be48cc9875b0759ecc7f3ebc25c3eceef24765e

[Owen Arnold]

refs #6936. Fix broken mac package.

Changeset: 2589d577b38b8d240c7b2cf0f9f4e8aef5f613f0

[Owen Arnold]

refs #6936. Made compatible with new and old PV.

Changeset: 4d18de87070731839514155361d5b1048ef795be

[Michael Reuter]

Refs #6315 and #6936. Fixing version number assembly.

Changeset: 3be48cc9875b0759ecc7f3ebc25c3eceef24765e

[Owen Arnold]

refs #6936. Fix broken mac package.

Changeset: 2589d577b38b8d240c7b2cf0f9f4e8aef5f613f0

[Michael Reuter]

This was folded into the ParaView 3.98 branch and shown to work for both OSX and Windows. This is now on master as well.

[Owen Arnold]

refs #6936. Made compatible with new and old PV.

Changeset: 4d18de87070731839514155361d5b1048ef795be

[Michael Reuter]

Refs #6315 and #6936. Fixing version number assembly.

Changeset: 3be48cc9875b0759ecc7f3ebc25c3eceef24765e

[Owen Arnold]

refs #6936. Fix broken mac package.

Changeset: 2589d577b38b8d240c7b2cf0f9f4e8aef5f613f0

[Stuart Campbell]

This ticket has been transferred to github issue ​7782