Ticket #6941 (closed: fixed)
Compiler warnings
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | minor | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
There are only a few compiler warnings remaining in our supported-platform 64 bit builds. Let's have a release based on code that's warning free!
Change History
comment:2 Changed 7 years ago by Russell Taylor
Re #6941. Clear compiler warning when template type is short int.
A warning had been appeared because a PropertyWithValue<uint16_t> was being created. The reason for the warning is that the compiler turns variables of this type into ints prior to arithmetic operations, but then assigns back to the narrower type. In other cases the cast will have no effect.
Changeset: f5a2659211e34e77b12788827cf1d6b679077d8d
comment:3 Changed 7 years ago by Russell Taylor
Re #6941. Clear MSVC compiler warning.
Changeset: f0ef0b9f24f3ed3f45b986ca1869cc1039e41221
comment:4 Changed 7 years ago by Russell Taylor
Re #6941. Remove unused variables.
Changeset: 9012f153060f6018a502004c9108b28637c9f015
comment:5 Changed 7 years ago by Russell Taylor
Merge branch 'feature/6941_compiler_warnings' into develop
Re #6941. Conflicts:
Code/Mantid/Framework/DataHandling/src/SetSampleMaterial.cpp
Changeset: a448d5f6e1ce18e8e893f2db2825622acd2e913f
comment:6 Changed 7 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
Test by inspection of builds and code changes. Branch is feature/6941_compiler_warnings.
There should be no more warnings in the master builds on Red Hat, Ubuntu, Mac or Windows 7 once this branch is merged (so long as no-one lets any more in in the meantime).
comment:7 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:8 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
Visual test passed, just checking everything compiles
comment:9 Changed 7 years ago by Russell Taylor
Re #6941. Clear compiler warning when template type is short int.
A warning had been appeared because a PropertyWithValue<uint16_t> was being created. The reason for the warning is that the compiler turns variables of this type into ints prior to arithmetic operations, but then assigns back to the narrower type. In other cases the cast will have no effect.
Changeset: f5a2659211e34e77b12788827cf1d6b679077d8d
comment:10 Changed 7 years ago by Russell Taylor
Re #6941. Clear MSVC compiler warning.
Changeset: f0ef0b9f24f3ed3f45b986ca1869cc1039e41221
comment:11 Changed 7 years ago by Russell Taylor
Re #6941. Remove unused variables.
Changeset: 9012f153060f6018a502004c9108b28637c9f015
comment:12 Changed 7 years ago by Russell Taylor
Re #6941. Clear compiler warning when template type is short int.
A warning had been appeared because a PropertyWithValue<uint16_t> was being created. The reason for the warning is that the compiler turns variables of this type into ints prior to arithmetic operations, but then assigns back to the narrower type. In other cases the cast will have no effect.
Changeset: f5a2659211e34e77b12788827cf1d6b679077d8d
comment:13 Changed 7 years ago by Russell Taylor
Re #6941. Clear MSVC compiler warning.
Changeset: f0ef0b9f24f3ed3f45b986ca1869cc1039e41221
comment:14 Changed 7 years ago by Russell Taylor
Re #6941. Remove unused variables.
Changeset: 9012f153060f6018a502004c9108b28637c9f015
comment:15 Changed 7 years ago by Russell Taylor
Re #6941. Clear compiler warning when template type is short int.
A warning had been appeared because a PropertyWithValue<uint16_t> was being created. The reason for the warning is that the compiler turns variables of this type into ints prior to arithmetic operations, but then assigns back to the narrower type. In other cases the cast will have no effect.
Changeset: f5a2659211e34e77b12788827cf1d6b679077d8d
comment:16 Changed 7 years ago by Russell Taylor
Re #6941. Clear MSVC compiler warning.
Changeset: f0ef0b9f24f3ed3f45b986ca1869cc1039e41221
comment:17 Changed 7 years ago by Russell Taylor
Re #6941. Remove unused variables.
Changeset: 9012f153060f6018a502004c9108b28637c9f015
comment:18 Changed 7 years ago by Anders Markvardsen
Merge branch 'feature/6922_mcstas' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:19 Changed 7 years ago by Anders Markvardsen
Merge branch 'feature/6922_mcstas' into develop into 6856_ConvertToDiffractionMDWS_v2
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7787
