Ticket #6958 (assigned)

Opened 7 years ago

Last modified 5 years ago

Enhance ConvertToMD interface.

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Backlog
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester:


ConvertTo MD interface become complicated and overloaded.

It should be simplified either according to the agreed suggestions, offered by the letter below , or by the interface improvements, suggested in the ticket #6855

Change History

comment:1 in reply to: ↑ description Changed 7 years ago by Alex Buts

The missing letter suggesting the changes to MD interface:

This letter is inspired by simple ticket to expose lab frame and sample frame on ConvertToMD interface which is relatively simple one. It was not there in the first place as the ConvertToMD interface is already overcrowded but if somebody really wants something, it still can bear couple of more properties.

The tester made number of comments related to the ConvertToMD interface complexity, which I completely agree with. Unfortunately, one of the suggestions made to simplify things was

"Orthogonal HKL and Q in lattice units should go away"

I love orthogonal HKL and want to use it even when Mantid supports non-orthogonal system. In addition to that, it would be nice to add to the interface couple of more properties (e.g. the choice of non-default labels or coordinate system shift) but I would agree that adding anything to existing interface make it look even worse. Moreover, one can notice that there are 7 out of 20 properties on this interface which are related to Q3D mode only.

This is why I am suggesting to change the interface as follows:

1) The convertToMD interface would have only the properties, related to the workspace conversion and the plugin selection (input/output workspace, plugin, other dimensions, min/max & splitting parameters -- we will be able to hide/remove half of this in a future). 2) Each plugin (CopyToMD, ModQ, Q3D) would process two properties exposed to ConvertToMD interface -- the name of a table workspace with relevant properties and the string, which would allow to overwrite any property from this table workspace specifying key-value pair.

3) Three separate algorithms will be extracted from the ConverToMD code, which would prepare the table workspace with properties as in 2) from the input parameters. The algorithm for Q3D mode will build transformation matrix and other stuff needed (there are currently 7 parameters to process). All this is already there internally anyway.

There are no time to implement all this now. If I am not having real objections, I would write ticket to do that for the next release. Meanwhile, I would fix some minor things, noted by the tester for this release, but would mainly leave things as it is now.

comment:2 Changed 7 years ago by Nick Draper

  • Component changed from VATES to User Interface

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:5 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7804

Note: See TracTickets for help on using tickets.