Ticket #6977 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove FlatBackground Algorithm from release 3.0

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By: #5225
Blocking: Tester: Samuel Jackson

Description (last modified by Karl Palmen) (diff)

This is to complete the work started by ticket #5225 to ensure the name 'FlatBackround' refers only to the fitting function and not to the algorithm.

Work must not be done until ticket #5225 has be fixed and released.

Change History

comment:1 Changed 7 years ago by Karl Palmen

  • Owner set to Karl Palmen
  • Status changed from new to assigned

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.7 to Backlog

comment:4 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:5 Changed 7 years ago by Karl Palmen

  • Description modified (diff)
  • Summary changed from Remove FlatBackground Algorithm from release 2.7 to Remove FlatBackground Algorithm from release 3.0

comment:6 Changed 7 years ago by Karl Palmen

  • Milestone changed from Backlog to Release 3.0

comment:7 Changed 7 years ago by Karl Palmen

  • Status changed from new to inprogress

comment:8 Changed 7 years ago by Karl Palmen

Remove FlatBackground algorithm files re #6977

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: fb38f4d4ff1faaced7c3bd3c818656daa556aecc

comment:9 Changed 7 years ago by Karl Palmen

Merge branch 'feature/6977_remove_flatbackground_alg' into develop

Conflicts:

Code/Mantid/Framework/Algorithms/CMakeLists.txt

Refs #6977

Changeset: 2f0471baaf6b1eb85fa33bd4e35f7fe2c5a57a4c

comment:10 Changed 7 years ago by Martyn Gigg

There is a system test that uses FlatBackground and is now broken.

​https://builds.sns.gov/job/ornl_test_rhel6_develop/2078/testReport/junit/SystemTests/PolrefExample/PolrefExample/

I guess we just need to update the system test to use CalculateFlatBackground?

This is something that we will need to warn users about too.

comment:11 Changed 7 years ago by Karl Palmen

Change call of FlatBackground to CalculateFlatBackgound re #6977

This was done in PolrefExample.py.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 17b5e69adf2d2a9e348315b1e7105ed71416b328

comment:12 Changed 7 years ago by Karl Palmen

Update results reference file re #6977

This was necessary because of changes made to CalculateFlatBackground to ensure it did not use a deprecated child algorithm.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: eb39e611df6c6d3c1b223c16e6d6936554f4e031

comment:13 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:14 Changed 7 years ago by Karl Palmen

Tester wait for system tests have been run on develop or run them yourself. Also check that FlatBackgound algorithm has been completely removed from the code.

Both the mantid and systemtest repositories need the git test macros run.

comment:15 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:16 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/6977_remove_flatbackground_alg'

Full changeset: ​0a422345d44acfaebb30e480f36f3558ebdeee32

comment:17 Changed 7 years ago by Samuel Jackson

Searched through the code and couldn't find any reference to Flat Background the algorithm and the algorithm is no longer showing up in Mantid.

comment:18 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/6977_remove_flatbackgound_alg'

Full changeset: ​5966be4e54f51d31f8e57e49c84a88861d22912b

comment:19 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7823

Note: See TracTickets for help on using tickets.