Muon: need to refocus twice 'first good bin'

[Anders Markvardsen]

To reproduce

1. Open MuonAnalysis interface

2. In setting make sure for 'Plot Creation' selected to be 'Auto-Update + Overwrite'

3. and the 'Time axis' is selected to 'Start at First Good Data'

4. Go to Home tab and load any muon data, e.g. browse to AutoTestdata and select MUSR00015189.nxs

5. for 'First Good Data' change the value from 0.11 to day 1.11 and hit return or otherwise refocus out of the input box

What you see is that the plot is not updated this, that is the first data plotted should be at 1.11 rather than 0.11

If you go to this input box again and refocus or hit the plot button you get the correct result

[Nick Draper]

Moved to backlog at the code freeze for R2.6

[Arturs Bekasovs]

Changed the logic of First Good Bin box.

Now, instead of synchronizing boxes only when focus is lost, all of the text changes are synchronized, which means that the start time will always be up-to-date.

Additionally, I've added validator for the First Good Bin box.

Refs #6990

Changeset: 1bb2def8dd33710c0f1f3af10bd879daf12b5fe0

[Arturs Bekasovs]

Change the way start time box is validated.

Now we do it only when it is used. With validator in-place that should be fine. We are explicitly working with First Good Bin box if appropriate option is selected, and if it is wrong we reset it to default value.

Refs #6990

Changeset: 47b10d34a7071794e591bd0eb4d4316e526b81eb

[Arturs Bekasovs]

Tester:

The First Good Data box is more complicated in the way that when we selected "Start at First Good Data" it controls Start box on the Settings tab. This makes error-checking and auto-update a bit more tricky.

Anyway, it should all be fine now, though I had to change the logic behind this box for it to work correctly.

• Check that scenario described is not leading to wrong behavior anymore.

• Verify that it works correctly when Time axis combo-box on Settings tab is set to something other than "Start at First Good Data". In that case First Good Data box shouldn't affect Start time box and the value set in the Start Time box should be used for plotting.

• Alternatively, when "Start at First Good Data" is selected, Start time and First Good Data boxes should be synchronized and the value should be used when plotting.

• Additionally, there is a known bug with QDoubleValidator - ​https://bugreports.qt-project.org/browse/QTBUG-15588. Hence when implementing it's considered that the value could not be a valid double, so please check that if you use thousands separator inside First Good Data, appropriate error is thrown and value is reset to default of 0.3.

[Anders Markvardsen]

Merge remote-tracking branch 'origin/feature/6990_muon_first_bin_autoupdate'

Full changeset: ​b70f3c24201d2d768e0d458921915cd0c36f7c93

[Stuart Campbell]

This ticket has been transferred to github issue ​7836