Ticket #6992 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

CPPCheck errors

Reported by: Nick Draper Owned by: Nick Draper
Priority: critical Milestone: Release 2.6
Component: Framework Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by Nick Draper) (diff)

Address the following

  1. Error
  2. Warning
  3. Performance
  4. and make a start on style

​http://download.mantidproject.org/jenkins/view/Static%20Analysis/job/isis_cppcheck/

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Description modified (diff)
  • Summary changed from CPD errors to CPPCheck errors

comment:2 Changed 7 years ago by Nick Draper

  • Priority changed from major to critical

comment:3 Changed 7 years ago by Nick Draper

re #6992 fix attempt for severity level error

Changeset: 8ea9be1d596b61d26406ceb1fb0e8b7962701901

comment:4 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 1

Changeset: c5ef47fb01d35223c056ac3024909d03d5a4a994

comment:5 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 2

Changeset: 84b0d98ef2be2cb4dccec00181d5325235085b94

comment:6 Changed 7 years ago by Nick Draper

re #6992 fix attempt for severity level error

Changeset: 8ea9be1d596b61d26406ceb1fb0e8b7962701901

comment:7 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 1

Changeset: c5ef47fb01d35223c056ac3024909d03d5a4a994

comment:8 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 2

Changeset: 84b0d98ef2be2cb4dccec00181d5325235085b94

comment:9 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 3

Changeset: ee316653b384f6f9c3617c4de291cc450b4ffc87

comment:10 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 3

Changeset: ee316653b384f6f9c3617c4de291cc450b4ffc87

comment:11 Changed 7 years ago by Nick Draper

re #6992 fix attempt for style level, and a bug fix

Changeset: 02ae494f8a0bb23486f965aa6b5c7386a3702f1e

comment:12 Changed 7 years ago by Nick Draper

re #6992 fix attempt for style level, and a bug fix

Changeset: 02ae494f8a0bb23486f965aa6b5c7386a3702f1e

comment:13 Changed 7 years ago by Nick Draper

re #6992 more style level fixes, and a bug fix

Changeset: ae7a06ad85086aa05982b34c0fca035a9e3f3218

comment:14 Changed 7 years ago by Nick Draper

re #6992 more style level fixes, and a bug fix

Changeset: ae7a06ad85086aa05982b34c0fca035a9e3f3218

comment:15 Changed 7 years ago by Nick Draper

re #6992 revert chages to DetectoEfficiencyCorUser.cpp

Changeset: 22109d6e0e9ce5e0976b68fad529fea806c24f89

comment:16 Changed 7 years ago by Nick Draper

re #6992 revert chages to DetectoEfficiencyCorUser.cpp

Changeset: 22109d6e0e9ce5e0976b68fad529fea806c24f89

comment:17 Changed 7 years ago by Nick Draper

  • Status changed from new to accepted

Done for now. Further improvements will occur under a new ticket.

For Tester: Code is merged to develop, most importantly all tests must pass, and system tests pass. If that is fine you could look through with a code review.

Please do not reopen this ticket just because one of the error counts is not 0, as long as they have decreased that will do.

comment:18 Changed 7 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:19 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:20 Changed 7 years ago by Nick Draper

re #6992 fix attempt for severity level error

Changeset: 8ea9be1d596b61d26406ceb1fb0e8b7962701901

comment:21 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 1

Changeset: c5ef47fb01d35223c056ac3024909d03d5a4a994

comment:22 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 2

Changeset: 84b0d98ef2be2cb4dccec00181d5325235085b94

comment:23 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 3

Changeset: ee316653b384f6f9c3617c4de291cc450b4ffc87

comment:24 Changed 7 years ago by Nick Draper

re #6992 fix attempt for style level, and a bug fix

Changeset: 02ae494f8a0bb23486f965aa6b5c7386a3702f1e

comment:25 Changed 7 years ago by Nick Draper

re #6992 more style level fixes, and a bug fix

Changeset: ae7a06ad85086aa05982b34c0fca035a9e3f3218

comment:26 Changed 7 years ago by Nick Draper

re #6992 revert chages to DetectoEfficiencyCorUser.cpp

Changeset: 22109d6e0e9ce5e0976b68fad529fea806c24f89

comment:27 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Best through a number of the commits (from which I as a bonus learned a few things). Build server seems happy also

comment:28 Changed 7 years ago by Nick Draper

re #6992 fix attempt for severity level error

Changeset: 8ea9be1d596b61d26406ceb1fb0e8b7962701901

comment:29 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 1

Changeset: c5ef47fb01d35223c056ac3024909d03d5a4a994

comment:30 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 2

Changeset: 84b0d98ef2be2cb4dccec00181d5325235085b94

comment:31 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 3

Changeset: ee316653b384f6f9c3617c4de291cc450b4ffc87

comment:32 Changed 7 years ago by Nick Draper

re #6992 fix attempt for style level, and a bug fix

Changeset: 02ae494f8a0bb23486f965aa6b5c7386a3702f1e

comment:33 Changed 7 years ago by Nick Draper

re #6992 more style level fixes, and a bug fix

Changeset: ae7a06ad85086aa05982b34c0fca035a9e3f3218

comment:34 Changed 7 years ago by Nick Draper

re #6992 revert chages to DetectoEfficiencyCorUser.cpp

Changeset: 22109d6e0e9ce5e0976b68fad529fea806c24f89

comment:35 Changed 7 years ago by Nick Draper

re #6992 fix attempt for severity level error

Changeset: 8ea9be1d596b61d26406ceb1fb0e8b7962701901

comment:36 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 1

Changeset: c5ef47fb01d35223c056ac3024909d03d5a4a994

comment:37 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 2

Changeset: 84b0d98ef2be2cb4dccec00181d5325235085b94

comment:38 Changed 7 years ago by Nick Draper

re #6992 fix attempt for performance level error batch 3

Changeset: ee316653b384f6f9c3617c4de291cc450b4ffc87

comment:39 Changed 7 years ago by Nick Draper

re #6992 fix attempt for style level, and a bug fix

Changeset: 02ae494f8a0bb23486f965aa6b5c7386a3702f1e

comment:40 Changed 7 years ago by Nick Draper

re #6992 more style level fixes, and a bug fix

Changeset: ae7a06ad85086aa05982b34c0fca035a9e3f3218

comment:41 Changed 7 years ago by Nick Draper

re #6992 revert chages to DetectoEfficiencyCorUser.cpp

Changeset: 22109d6e0e9ce5e0976b68fad529fea806c24f89

comment:42 Changed 7 years ago by Ruth Mikkelson

Refs #6992 Wiki updates. Added Documentation, etc.

Changeset: 698993c986dd59b42f7340a466d0032dcce5372e

comment:43 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:44 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7838

Note: See TracTickets for help on using tickets.