Ticket #6998 (closed: fixed)
Muon: Crash if text in the time zero box
Reported by: | Nick Draper | Owned by: | Martyn Gigg |
---|---|---|---|
Priority: | blocker | Milestone: | Release 2.5 |
Component: | MantidPlot | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Nick Draper |
Description
if you add any text characters, as a user might by mistake and click plot -> Bang.
To solve -> don't go bang, report the error nicely.
Change History
comment:1 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
- Owner changed from Anders Markvardsen to Martyn Gigg
comment:2 Changed 7 years ago by Martyn Gigg
Fix MuonAnalysis crash with bad time zero entry. Refs #6998
Changeset: 63568775dd223fa7b900841bd2540ca812452aa3
comment:3 Changed 7 years ago by Martyn Gigg
Fix MuonAnalysis crash with bad time zero entry. Refs #6998
Changeset: 63568775dd223fa7b900841bd2540ca812452aa3
comment:5 Changed 7 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
- type changed from enhancement to defect
Branch: bugfix/6998_crash_muon_dialog
Tester:
- Load the Muon Analysis dialog
- Browse for a MUSR file (there are some in the AutoTest data directory)
- When the file has loaded & plotted clear the time zero box and try and enter letters, it should not be possible, only numbers and the letter e (to allow scientific notation) are accepted
- Click plot input once the time zero has been changed.
comment:6 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:7 Changed 7 years ago by Nick Draper
- Status changed from verifying to reopened
- Resolution fixed deleted
Spotted By the all seeing Russell:
there's a mistake in #6998 that I can see you just took for validation. The QDoubleValidator is not given 'this' as a parent. [14:44:25] Russell Taylor (Tessella): This stops it compiling with qt 4.6 (which I know is going away), but I think also means it leaks.
comment:8 Changed 7 years ago by Martyn Gigg
Set a parent for the validator. Refs #6998
Changeset: 2e029ad8cc2c67000c6fe0dae74e0411d86604ab
comment:9 Changed 7 years ago by Martyn Gigg
Set a parent for the validator. Refs #6998
Changeset: 2e029ad8cc2c67000c6fe0dae74e0411d86604ab
comment:11 Changed 7 years ago by Martyn Gigg
- Status changed from accepted to verify
- Resolution set to fixed
comment:13 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
great nice and robust, will not allow any letter other than e, and handles it nicely when you just enter e.
comment:14 Changed 7 years ago by Martyn Gigg
Fix MuonAnalysis crash with bad time zero entry. Refs #6998
Changeset: 63568775dd223fa7b900841bd2540ca812452aa3
comment:15 Changed 7 years ago by Martyn Gigg
Set a parent for the validator. Refs #6998
Changeset: 2e029ad8cc2c67000c6fe0dae74e0411d86604ab
comment:16 Changed 7 years ago by Martyn Gigg
Fix MuonAnalysis crash with bad time zero entry. Refs #6998
Changeset: 63568775dd223fa7b900841bd2540ca812452aa3
comment:17 Changed 7 years ago by Martyn Gigg
Set a parent for the validator. Refs #6998
Changeset: 2e029ad8cc2c67000c6fe0dae74e0411d86604ab
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7844