Ticket #7010 (closed: duplicate)
IDF: make getMangledName() not refer to m_xmlFile
| Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Russell Taylor |
Description (last modified by Anders Markvardsen) (diff)
In InstrumentDefinitionParser::getMangledName() make getMangledName() not refer to m_xmlFile where this is not needed.
When m_xmlFile does not exist do not try to use the name stored for this non existing file for the name mangling. Instead use the name given to the instrument.
Improve documentation.
Change History
comment:1 Changed 7 years ago by Anders Markvardsen
- Priority changed from blocker to critical
- Description modified (diff)
comment:4 Changed 7 years ago by Anders Markvardsen
- Milestone changed from Release 3.0 to Release 3.1
comment:5 Changed 7 years ago by Russell Taylor
There's a wider problem with InstrumentDefinitionParser - it shouldn't assume that there is any file at all since this is now not always the case (the XML text can be passed in directly from, e.g., a nexus file or a live stream).
If this isn't the place to sort this out properly, please create a separate ticket for this issue.
comment:6 Changed 7 years ago by Russell Taylor
Furthermore, even if there is a file, the last modified time should surely still come from within the IDF in preference to the file timestamp shouldn't it?
comment:7 Changed 7 years ago by Russell Taylor
In the end, I had to fix the main point of this in #8220 - getMangledName now returns the instrument name if the XML file does not exist.
comment:8 Changed 7 years ago by Nick Draper
- Milestone changed from Release 3.1 to Backlog
Moved to backlog at the end of Release 3.1
comment:10 Changed 7 years ago by Anders Markvardsen
- Status changed from new to verify
- Resolution set to duplicate
Russell has fixed this in 8220. GetMangledName now returns the instrument name if the XML file does not exist
comment:11 Changed 7 years ago by Russell Taylor
- Status changed from verify to verifying
- Tester set to Russell Taylor
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7856
