Ticket #7036 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Problems with changing axis limits on the Mac

Reported by: Russell Taylor Owned by: Martyn Gigg
Priority: critical Milestone: Release 2.5
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

To reproduce:

  • Plot something
  • Double click on one of the axes (x or y)
  • Change the axis minimum or maximum in the dialog box
  • Hit OK (and optionally Apply before that)
  • Nothing changes!

Replace the clicking on the OK button with just hitting Return after changing the value and the plot does update.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Owen Arnold

comment:2 Changed 7 years ago by Nick Draper

  • Owner changed from Owen Arnold to Martyn Gigg

comment:3 Changed 7 years ago by Martyn Gigg

  • Status changed from assigned to accepted

comment:4 Changed 7 years ago by Martyn Gigg

Fix plot axes not updating on OS X.

The issue seems to be with the 'from' and 'to' boxes. When you enter a value and click apply then the box does not lose focus like on the other platforms so the internal value does not get updated and when the dialog asks what the value is it returns the original and not the new one.

An old comment suggests that the fix used to cause a crash but it no longer seems to...

Refs #7036

Changeset: 4c6aa2f0373774639892a5b9304c93eaed857a2a

comment:5 Changed 7 years ago by Martyn Gigg

Fix so that axes are updated on clicking ok.

There was a bug on the Mac also that meant a user would have to click apply first and then okay to see any changes. Refs #7036

Changeset: 91aef62127927e4719a52dc2179014b23555ca87

comment:6 Changed 7 years ago by Martyn Gigg

Fix plot axes not updating on OS X.

The issue seems to be with the 'from' and 'to' boxes. When you enter a value and click apply then the box does not lose focus like on the other platforms so the internal value does not get updated and when the dialog asks what the value is it returns the original and not the new one.

An old comment suggests that the fix used to cause a crash but it no longer seems to...

Refs #7036

Changeset: 4c6aa2f0373774639892a5b9304c93eaed857a2a

comment:7 Changed 7 years ago by Martyn Gigg

Fix so that axes are updated on clicking ok.

There was a bug on the Mac also that meant a user would have to click apply first and then okay to see any changes. Refs #7036

Changeset: 91aef62127927e4719a52dc2179014b23555ca87

comment:8 Changed 7 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Branch: bugfix/7036_osx_plot_axes

Tester: MUST BE TESTED ON MAC

Follow the instructions above and make sure they work now. In addtion also try just clicking apply and also just pressing return when changing a value in the boxes. The plots should now update via all 3 methods.

There was a minor change to the error handling also so check that if you enter invalid input,i.e. min > max that it responds appropriately.

comment:9 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:10 Changed 7 years ago by Martyn Gigg

Fix plot axes not updating on OS X.

The issue seems to be with the 'from' and 'to' boxes. When you enter a value and click apply then the box does not lose focus like on the other platforms so the internal value does not get updated and when the dialog asks what the value is it returns the original and not the new one.

An old comment suggests that the fix used to cause a crash but it no longer seems to...

Refs #7036

Changeset: 4c6aa2f0373774639892a5b9304c93eaed857a2a

comment:11 Changed 7 years ago by Martyn Gigg

Fix so that axes are updated on clicking ok.

There was a bug on the Mac also that meant a user would have to click apply first and then okay to see any changes. Refs #7036

Changeset: 91aef62127927e4719a52dc2179014b23555ca87

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

It's good now. Tested on Mountain Lion including my original instructions and those in comment:8, plus things like trying to enter text.

comment:13 Changed 7 years ago by Martyn Gigg

Fix plot axes not updating on OS X.

The issue seems to be with the 'from' and 'to' boxes. When you enter a value and click apply then the box does not lose focus like on the other platforms so the internal value does not get updated and when the dialog asks what the value is it returns the original and not the new one.

An old comment suggests that the fix used to cause a crash but it no longer seems to...

Refs #7036

Changeset: 4c6aa2f0373774639892a5b9304c93eaed857a2a

comment:14 Changed 7 years ago by Martyn Gigg

Fix so that axes are updated on clicking ok.

There was a bug on the Mac also that meant a user would have to click apply first and then okay to see any changes. Refs #7036

Changeset: 91aef62127927e4719a52dc2179014b23555ca87

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7882

Note: See TracTickets for help on using tickets.