Ticket #7051 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

launch_mantidplot failing

Reported by: Owen Arnold Owned by: Stuart Campbell
Priority: blocker Milestone: Release 2.5
Component: Mantid Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Martyn Gigg

Description

Multiple arguments are not being processed properly. This is quite a big problem, with a simple fix.

launch_mantidplot.sh

#!/bin/sh
scl enable mantidlibs '/opt/Mantid/bin/MantidPlot_exe '$@ 

should be

#!/bin/sh
scl enable mantidlibs '/opt/Mantid/bin/MantidPlot_exe '$* 

see http://osr507doc.sco.com/en/OSUserG/_Passing_to_shell_script.html

This is currently causing the screenshot jenkins job to fail. http://download.mantidproject.org/jenkins/job/make_screenshots/

Change History

comment:1 Changed 7 years ago by Martyn Gigg

The fix suggested isn't quite right. The $* should be inside double quotes as single quotes will prevent shell expansion:

scl enable mantidlibs "/opt/Mantid/bin/MantidPlot_exe $*" 
Last edited 7 years ago by Martyn Gigg (previous) (diff)

comment:2 Changed 7 years ago by Stuart Campbell

  • Status changed from new to accepted

comment:3 Changed 7 years ago by Stuart Campbell

Treat multiple args as one rather than keeping as separate ones.

refs #7051

Changeset: 4966c2df2d5eef788e9605aa784dad3cf506dab2

comment:4 Changed 7 years ago by Stuart Campbell

Treat multiple args as one rather than keeping as separate ones.

refs #7051

Changeset: 4966c2df2d5eef788e9605aa784dad3cf506dab2

comment:5 Changed 7 years ago by Stuart Campbell

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 7 years ago by Stuart Campbell

Treat multiple args as one rather than keeping as separate ones.

refs #7051

Changeset: 4966c2df2d5eef788e9605aa784dad3cf506dab2

comment:8 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Tested running the screenshot maker script and it works now.

comment:9 Changed 7 years ago by Stuart Campbell

Treat multiple args as one rather than keeping as separate ones.

refs #7051

Changeset: 4966c2df2d5eef788e9605aa784dad3cf506dab2

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7897

Note: See TracTickets for help on using tickets.