Load Dialog: enter a new filename and hit enter too quick -> wrong loader

[Nick Draper]

If you enter a new filename (which would cause a change of loader). If you hit enter or click ok before the new loader has been assigned then it will try to use the old loader.

Improvement ideas:

1. Disable execution until the loader search has completed
2. Cache the execute request until the loader has been selected (probably better)
3. Possibly test with the previous loader (before the rest) quickcheck and filecheck first, as 90% of file will use the last loader.

[Nick Draper]

Moved to the Backlog after R2.6

[Martyn Gigg]

Do a manual file search when run is clicked on LoadDialog

If the text field got updated but didn't emit the filesFound signal then the dialog would load the old file. When run is clicked a search is forced but it only performs a new search if something has actually changed in the box. Refs #7055

Changeset: 0e59f569070c44711746b3f07601565076dcfabd

[Martyn Gigg]

Branch: bugfix/7055_loaddialog_invalid_input

Tester: This can be difficult to reproduce. Ticket #8062 has a set of instructions that should be checked although I could not reproduce the error with those. The best way I found was to browse an load a file first then run load again and edit the box using only the keyboard to point to a different file and immediately press return when but do NOT click outside of the field. The dialog should now load the new file.

[Michael Reuter]

I was able to reproduce the issue in #8062. After applying the fix, I see that the File widget has a star next to it, but no dialog appears. Once the file is found, the load automatically starts. I also performed the procedure requested in this ticket. No star is seen and the load starts when the file is found.

[Michael Reuter]

Merge remote branch 'origin/bugfix/7055_loaddialog_invalid_input'

Full changeset: ​1a3e35a91d2259e9bda8846b5d47d5a428e4ba89

[Stuart Campbell]

This ticket has been transferred to github issue ​7901