Ticket #7059 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Load SINQ (PSI). Only FOCUS instrument.

Reported by: Ricardo Leal Owned by: Ricardo Leal
Priority: major Milestone: Release 2.6
Component: Framework Keywords: psi focus
Cc: Blocked By:
Blocking: Tester: Nick Draper

Description

I'm creating a new loader for PSI and new IDF for the FOCUS instrument (time-of-flight spectrometer).

Details here: ​http://www.psi.ch/sinq/focus/

Change History

comment:1 Changed 7 years ago by Ricardo Leal

IDF and Loader for PSI FOCUS Refs #7059

Changeset: 4f3a8e1823fb46205155a8719a99d7789504ee60

comment:2 Changed 7 years ago by Ricardo Leal

EPP similar to ILL Refs #7059

Changeset: 363a6e194be6557883b81bf4b6b791e8435a4850

comment:3 Changed 7 years ago by Ricardo Leal

Time bins read from the file Refs #7059

Changeset: 5f136d021c4b8d9aaaa318184f74da4cddc67d31

comment:4 Changed 7 years ago by Ricardo Leal

Test for loading focus Refs #7059

Changeset: f55e4ee4ffcba744165630472c2bde9250e3ef79

comment:5 Changed 7 years ago by Ricardo Leal

Merge branch 'feature/7059_load_psi_focus_instrument' into develop

comment:6 Changed 7 years ago by Ricardo Leal

Bug fix : for range not supported Refs #7059

Changeset: 6c945f8e2b95dd4f925dc7da2787d53c47066aed

comment:7 Changed 7 years ago by Ricardo Leal

Merge branch 'feature/7059_load_psi_focus_instrument' into develop

comment:8 Changed 7 years ago by Ricardo Leal

changed name FOCUS at SINQ to FOCUS Refs #7059

Changeset: e7befbaf317a33c1502dfd0de6389da25f5886e6

comment:9 Changed 7 years ago by Ricardo Leal

changed LoadPSI to LoadSINQ Refs #7059

Changeset: edb6b9305475abdbf3fa015446e06fee9c582395

comment:10 Changed 7 years ago by Ricardo Leal

Merge branch 'feature/7059_load_psi_focus_instrument' into develop

comment:11 Changed 7 years ago by Ricardo Leal

This ticket might have to open in the future. I am still waiting for scientists at SINQ to test this. I would be nice though to have this in a nightly build.

To test, just load the data: Test/AutoTestData/focus2010n000468.hdf

comment:12 Changed 7 years ago by Ricardo Leal

  • Status changed from new to accepted

comment:13 Changed 7 years ago by Ricardo Leal

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 7 years ago by Ricardo Leal

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:15 Changed 7 years ago by Ricardo Leal

  • Summary changed from Load PSI and FOCUS instrument to Load SINQ (PSI). Only FOCUS instrument.

comment:16 Changed 7 years ago by Ricardo Leal

It should be done. People from SINQ will check this as soon as it is available.

To test, just load the data: Test/AutoTestData/focus2010n000468.hdf

comment:17 Changed 7 years ago by Ricardo Leal

  • Status changed from reopened to accepted

comment:18 Changed 7 years ago by Ricardo Leal

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:19 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:20 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The happy test is ok. But, I would suggest to add some features, please consider if they are worth:

There are some names confusion, example: MANTID_DATAHANDLING_LOADPSI_H_ for a file that is called Code/Mantid/Framework/DataHandling/inc/MantidDataHandling/LoadSINQ.h

If you try to load an invalid data (because is of other instrument). I tried LOQ49886.nxs

You get this exception. Maybe you could provide a better information. 

Error in execution of algorithm LoadSINQ:
Error opening data in group "name"

Facility SINQ is not available to setup as default facility - add it to Mantid.properties.template

The current implementation, requires that you provide the full path to open the file, no short cut as providing just the run number for example is accepted. This is different from the others loaders, and should be considered. These functionalities are provided through the options at facility.xml

  • zeropadding=
  • prefix=
  • delimiter=

comment:21 Changed 7 years ago by Ricardo Leal

Thanks for the comments. I really appreciate it. I will be happy to fix this next week.

comment:22 Changed 7 years ago by Ricardo Leal

Fixes related to G. Passos suggestions Re #7059

Changeset: 9a639aa112f5831b269edee48c0c04c5a7b1f1f7

comment:23 Changed 7 years ago by Ricardo Leal

  • Status changed from reopened to accepted

comment:24 Changed 7 years ago by Ricardo Leal

  • Status changed from accepted to verify
  • Resolution set to fixed

Changes made. Just didn't implement the open file by run number as there is no run_number fields inside the nexus file and the file name does not seem to follow a pattern.

comment:25 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester changed from Gesner Passos to Nick Draper

comment:26 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Tested with valid and invalid files.

comment:27 Changed 7 years ago by Nick Draper

re #7059 resolving conflict

Changeset: ce508547e177046cd6d52c1289a5deea45bc9937

comment:28 Changed 7 years ago by Nick Draper

re #7059 add file to system test data diretory.

For the load lots of files test

Changeset: d5cde6f987661c3040333635e26adc673cfccf6d

comment:29 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:30 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7905

Note: See TracTickets for help on using tickets.