Ticket #7069 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Migrate ConjoinSpectra

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.6
Component: Python Keywords: Maintenance
Cc: martyn.gigg@… Blocked By: #7101
Blocking: #6579 Tester: Gesner Passos

Description

Move ConjoinSpectra from v1 to v2 of the python API. Add a python unit test for this method.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Owen Arnold

refs #7069. Direct conversion.

Changeset: 73cdfa3e53686063e1b1f57e6147b58553411545

comment:3 Changed 7 years ago by Owen Arnold

refs #7069 move algorithm

Changeset: 1523195dee1584e10c716d3c47cf5c527e199679

comment:4 Changed 7 years ago by Owen Arnold

refs #7069. Add python unit test.

Changeset: 25d04022b7ef4c3986354aa84c6a9a8bd3bf5d04

comment:5 Changed 7 years ago by Owen Arnold

  • Cc martyn.gigg@… added

I'm having to pause at this point because the running this python algorithm is hitting an issue with an invalid workspace pointer. This seems to happen as part of the processing of the output workspace. Martyn has suggested that this might be an issue relating to having outputworkspaces replacing inputworkspaces. This issue will need to be resolved first.

comment:6 Changed 7 years ago by Owen Arnold

  • Blocked By 7101 added

comment:7 Changed 7 years ago by Owen Arnold

Should be able to continue now that #7101 is fixed

comment:8 Changed 7 years ago by Owen Arnold

refs #7069. Direct conversion.

Changeset: 73cdfa3e53686063e1b1f57e6147b58553411545

comment:9 Changed 7 years ago by Owen Arnold

refs #7069 move algorithm

Changeset: 1523195dee1584e10c716d3c47cf5c527e199679

comment:10 Changed 7 years ago by Owen Arnold

refs #7069. Add python unit test.

Changeset: 25d04022b7ef4c3986354aa84c6a9a8bd3bf5d04

comment:11 Changed 7 years ago by Owen Arnold

refs #7069. Conjoin spectra test.

Changeset: dd3192c98d46e6e91baf236952042fa758af2ee6

comment:12 Changed 7 years ago by Owen Arnold

refs #7069. Conjoin spectra test.

Changeset: dd3192c98d46e6e91baf236952042fa758af2ee6

comment:13 Changed 7 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

Verify that the ticket description has been satisfied. You might also like to try the algorithm out. Here's an example script: 

dataX = range(0,6)
dataY1 = range(0,5)

dataY2 =  [y for y in range(0,10) if y%2 ==0]
dataE = [1] * len(dataY)
 
u = CreateWorkspace(dataX, dataY1, dataE, NSpec=1,UnitX="Wavelength")
v = CreateWorkspace(dataX, dataY2, dataE, NSpec=1,UnitX="Wavelength")

ConjoinSpectra(InputWorkspaces="%s,%s" % ('u', 'v'), OutputWorkspace="conjoined")

comment:14 Changed 7 years ago by Owen Arnold

branch is feature/7069_conjoin_spectra

comment:15 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:16 Changed 7 years ago by Owen Arnold

refs #7069. Direct conversion.

Changeset: 73cdfa3e53686063e1b1f57e6147b58553411545

comment:17 Changed 7 years ago by Owen Arnold

refs #7069 move algorithm

Changeset: 1523195dee1584e10c716d3c47cf5c527e199679

comment:18 Changed 7 years ago by Owen Arnold

refs #7069. Add python unit test.

Changeset: 25d04022b7ef4c3986354aa84c6a9a8bd3bf5d04

comment:19 Changed 7 years ago by Owen Arnold

refs #7069. Conjoin spectra test.

Changeset: dd3192c98d46e6e91baf236952042fa758af2ee6

comment:20 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

I could not find anything inside ConjoinSpectra related to v1 python, and it is still working correctly using the v2.

comment:21 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:22 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Python API

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7915

Note: See TracTickets for help on using tickets.