Ticket #7088 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Alter local trac github plugin to only add novel commit comments

Reported by: Nick Draper Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.6
Component: Tools Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Nick Draper) (diff)

Create a custom version of the github trac plugin that only adds commit comments if they are novel (i.e. the text is different from a previous comment). This should reduce the vast majority of branch reppeats.

Also on looking the commit hook does know about the branches in github, so we may be able to include a single comment per merge or something like 

Merged to Master

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

This doesn't involve codes changes to the main repository.

There is a fork of the github-trac plugin here: ​https://github.com/mantidproject/github-trac and it is installed on mantidweb. It now does two things:

  • Allows duplicate commits to be suppressed, ticket #7057 is an example
  • Attempts to find the correct ticket to append a merge commit message to. Ticket #7114 is an example

comment:3 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:4 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

I observed the merge to master on my previous test #7152

comment:5 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Tools
  • Description modified (diff)

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7934

Note: See TracTickets for help on using tickets.