Ticket #7090 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

RunPythonScript should work with API v2

Reported by: Nick Draper Owned by: Owen Arnold
Priority: critical Milestone: Release 2.5.3
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

At the moment the following script in StartLoveData does not work. 

output=Rebin(input,"40000,100,50000")

While this one does 

output=Rebin(InputWorkspace=input,OutputWorkspace=output,Params="40000,100,50000")

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned
  • Keywords PatchCandidate added
  • Milestone changed from Release 2.6 to Release 2.5.3

comment:2 Changed 7 years ago by Nick Draper

  • Owner changed from Martyn Gigg to Owen Arnold

comment:3 Changed 7 years ago by Owen Arnold

  • Status changed from assigned to accepted

comment:4 Changed 7 years ago by Owen Arnold

refs #7090. RunPythonScript and Test moved to the new api.

Changeset: 8a81826b04c4756124e7051dc0acf3a1211706b9

comment:5 Changed 7 years ago by Owen Arnold

refs #7090. Move algorithm and test.

Changeset: e7e1b84ba1e4aed52f4a6a60a5bebedfd038058e

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Branch is feature/7090_runpythonscript

Last edited 7 years ago by Owen Arnold (previous) (diff)

comment:7 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/bugfix/6982_process_detectors_sans2d' into develop

comment:8 Changed 7 years ago by Owen Arnold

refs #7090. Solve merge conflict.

Changeset: cbccbe5a481bb005a122e19991036f4a7e49382e

comment:9 Changed 7 years ago by Owen Arnold

Merge branch 'feature/7090_runpythonscript' into develop

comment:10 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:11 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/7090_runpythonscript'

Refs #7090 Conflicts:

Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt

Changeset: 2de4057d6d870d51376c89ba3b71b8e9bd6502b2

comment:12 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:13 Changed 7 years ago by Owen Arnold

Reopened because the following fails: 

a = CreateSingleValuedWorkspace(DataValue='1')
b = RunPythonScript(InputWorkspace=a, Code="output = CloneWorkspace(InputWorkspace=input)")

# No need for input workspace
c = RunPythonScript(Code="output = CreateSingleValuedWorkspace(DataValue='1')")

Looks like the algorithm does not properly handle the lack of an input workspace, despite the input workspace being non-mandatory.

comment:14 Changed 7 years ago by Owen Arnold

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:15 Changed 7 years ago by Owen Arnold

Merge branch 'feature/7090_runpythonscript' into develop

comment:16 Changed 7 years ago by Owen Arnold

refs #7090. Fix input issue.

Changeset: bb35e69892ae1efb5bdbddb93c11dd693a908142

comment:17 Changed 7 years ago by Owen Arnold

  • Status changed from reopened to accepted

comment:18 Changed 7 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:19 Changed 7 years ago by Owen Arnold

Tester: Please check that the python snipped above works and that the unit tests are running and passing.

comment:20 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying

comment:21 Changed 7 years ago by Martyn Gigg

Unit test is okay and the new script produces the expected workspaces with no errors.

comment:22 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/7090_runpythonscript' into master

comment:23 Changed 7 years ago by Owen Arnold

refs #7090. RunPythonScript and Test moved to the new api.

Changeset: 828ed6fb3b2863268ac34850df2f35cc1b8bee3f

comment:24 Changed 7 years ago by Owen Arnold

refs #7090. Move algorithm and test.

Changeset: 58450c5e89a95947eb1f6f468ffbb0b7598f03e1

comment:25 Changed 7 years ago by Owen Arnold

refs #7090. Fix input issue.

Changeset: 87f250d73d0c5544697324ffb67dccf476958a3e

comment:26 Changed 7 years ago by Owen Arnold

  • Keywords PatchCandidate removed

This is no longer a Patch Candidate.

comment:27 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7936

Note: See TracTickets for help on using tickets.