Ticket #7108 (closed: fixed)
Migrate ConjoinFiles
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.6 |
| Component: | Python | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | #6579 | Tester: | Nick Draper |
Description (last modified by Nick Draper) (diff)
- Move to PythonInterface
- Migrate to version 2 of the python API
- Create a unit test for this algorithm
Change History
comment:2 Changed 7 years ago by Owen Arnold
refs #7108. Move algorithm.
Changeset: fd56080c41eb053771ab462d6e6b4260fb7dd690
comment:3 Changed 7 years ago by Owen Arnold
refs #7108. Port to V2.
Changeset: accd74887ec32304475af49d5a8097141d8797d1
comment:5 Changed 7 years ago by Owen Arnold
refs #7108. Missed old api calls.
Changeset: 841dffd58687adcff495f391cbbbe65eda86fca3
comment:6 Changed 7 years ago by Owen Arnold
refs #7108. Missed old api calls.
Changeset: 841dffd58687adcff495f391cbbbe65eda86fca3
comment:8 Changed 7 years ago by Owen Arnold
Tester: Look at SNSPowderRedux.py system test to determine how to run this algorithm if you wish to do so manually. However code changes are minor, and provided that the develop system tests are passing, I think you can be confident that no functionality was broken during the course of the migration.
comment:9 Changed 7 years ago by Owen Arnold
refs #7108. Fix array property usage.
Changeset: 5246d6727f0d91fb0a31e1b4dad63baff52071d6
comment:10 Changed 7 years ago by Owen Arnold
refs #7108. Fix array property usage.
Changeset: 5246d6727f0d91fb0a31e1b4dad63baff52071d6
comment:11 Changed 7 years ago by Owen Arnold
refs #7108. Fix system tests.
Changeset: 257c25615dbc885549966ad2c812a7ca3f0676ff
comment:12 Changed 7 years ago by Owen Arnold
refs #7108. Fix system tests.
Changeset: 257c25615dbc885549966ad2c812a7ca3f0676ff
comment:14 Changed 7 years ago by Owen Arnold
- Status changed from accepted to verify
- Resolution set to fixed
comment:15 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:16 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
Migration accepted by code review, the algorithm itself is too focussed on gsas files when it could be much more generic.
comment:17 Changed 7 years ago by Owen Arnold
refs #7108. Move algorithm.
Changeset: fd56080c41eb053771ab462d6e6b4260fb7dd690
comment:18 Changed 7 years ago by Owen Arnold
refs #7108. Port to V2.
Changeset: accd74887ec32304475af49d5a8097141d8797d1
comment:19 Changed 7 years ago by Owen Arnold
refs #7108. Missed old api calls.
Changeset: 841dffd58687adcff495f391cbbbe65eda86fca3
comment:20 Changed 7 years ago by Owen Arnold
refs #7108. Fix array property usage.
Changeset: 5246d6727f0d91fb0a31e1b4dad63baff52071d6
comment:21 Changed 7 years ago by Owen Arnold
refs #7108. Fix system tests.
Changeset: 257c25615dbc885549966ad2c812a7ca3f0676ff
comment:22 Changed 7 years ago by Owen Arnold
Merge branch 'master' into feature/7108_conjoin_files into 7090_runpythonscript
comment:24 Changed 7 years ago by Nick Draper
- Component changed from Framework to Python API
- Description modified (diff)
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7954
Update - This algorithm is heavily file-based, and is already used as part of a system test (SNSPowderRedux.py) so I'm not going to write a unit test for this algorithm.