Ticket #7116 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Update CanSAS1D XML header

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 2.5.3
Component: Mantid Keywords: PatchCandidate,Released
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

include an update to the CanSAS1D XML header?

At present it says (for the v1.1, as it did for v1.0):

<?xml-stylesheet type="text/xsl" href="cansasxml-html.xsl" ?>

It needs to say:

<?xml-stylesheet type="text/xsl" href="cansas1d.xsl" ?>

this one is causing compatibility problems (the latter is backwardly-compatible, the former is not forwardly-compatible)!

Change History

comment:1 Changed 7 years ago by Nick Draper

re #7116 Change xml header for Cansas1d v2

Changeset: 9fb87786ba16618427289589072a2dde62db5a97

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to accepted

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from accepted to verify
  • Resolution set to fixed

To test:

  1. Load the LOQ_cansas1d.xml file in autotestdata
  2. Save the workspace using savecansas1d
  3. open the file and check the stylesheet header is <?xml-stylesheet type="text/xsl" href="cansas1d.xsl" ?>
  4. load the file using Load
  5. check the two workspaces are the same.

comment:4 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 7 years ago by Nick Draper

re #7116 Change xml header for Cansas1d v2

Changeset: 9fb87786ba16618427289589072a2dde62db5a97

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

comment:7 Changed 7 years ago by Owen Arnold

Looking at this as part of the Patch Release code-review. While the changes are simple, the writeHeader could have been put under test.

comment:8 Changed 7 years ago by Nick Draper

re #7116 Change xml header for Cansas1d v2

Changeset: 1831daffb868762da887fb51ebf8e60a3c60988b

comment:9 Changed 7 years ago by Nick Draper

  • Keywords PatchCandidate,Released added; PatchCandidate removed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7962

Note: See TracTickets for help on using tickets.