Ticket #7122 (closed: fixed)
ScriptRepo Autoupdate should cascade the autoupdate setting for folders
Reported by: | Nick Draper | Owned by: | Gesner Passos |
---|---|---|---|
Priority: | critical | Milestone: | Release 3.0 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Arturs Bekasovs |
Description (last modified by Gesner Passos) (diff)
When you set a folder to autoupdate nothing happens.
It should as a minimum cascade the setting to all currently contained files.
Or you could also handle the addition of new files under that directory.
Change History
comment:2 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to the Backlog after R2.6
comment:3 Changed 7 years ago by Gesner Passos
- Description modified (diff)
- Milestone changed from Backlog to Release 3.0
comment:6 Changed 7 years ago by Gesner Passos
Cascade auto update option
It also hides the AutoUpdate option when it is not available (the user has not downloaded the elements).
re #7122
Changeset: 486d3fc1de10b6394feaad325152ffb193baebdf
comment:7 Changed 7 years ago by Gesner Passos
Tester:
Open ScriptRepository.
- Check that you will have the option to set AutoUpdate only for those files/folders that you have downloaded.
- Check that you can enable/disable folders to auto-update. Check that the option is cascaded through the files/folders under the selected one.
comment:8 Changed 7 years ago by Gesner Passos
ScriptRepository: Hide AutoUpdate for local only entries
re #7122
Changeset: 43c3d9b89c86b350203a6c653cda7796752efde1
comment:9 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 7 years ago by Arturs Bekasovs
- Status changed from verify to verifying
- Tester set to Arturs Bekasovs
comment:11 Changed 7 years ago by Arturs Bekasovs
- Status changed from verifying to reopened
- Resolution fixed deleted
All seems to work fine apart from one small issue:
- In script repository, download a folder and enable Auto-Update for it.
- Now go to the actual script repository folder on your PC and delete the folder you've downloaded.
- Back in script repository, click reload. Now download the same folder again. You will notice, that Auto-Update becomes enabled for the folder, but disabled for all its files.
comment:13 Changed 7 years ago by Gesner Passos
It is also better to add the option to cascade inside the ScriptRepositoryImpl class (framework) instead of in the GUI.
comment:14 Changed 7 years ago by Gesner Passos
Add some unit test to enforce the auto update cascade
re #7122
Changeset: 9417afc788988c9a0baca62b82fbbf253d3a269f
comment:15 Changed 7 years ago by Gesner Passos
Implementation of new signature of setAutoUpdate
re #7122
Changeset: e3e8c22a315ed232edbc9eba78ca8586589396f5
comment:16 Changed 7 years ago by Gesner Passos
ScriptRepository: clear AutoUpdate flag from folder that loose files
Now, if you have a folder set to auto update and you remove a local file, this folder will clear the flag of autoupdate, because, it will not update all the files anymore. (But, the files that were configured to be autupdate) will continue to support it.
re #7122
Changeset: 65b13b56c7244d9f91daab0ea90a39bd54315b86
comment:17 Changed 7 years ago by Gesner Passos
ScriptRepository: use auto update from the framework
The previous version tried to provide auto-cascade from the GUI, now, it has support in the API, so, it now uses the auto-cascade from the API.
re #7122
Changeset: 901a302bf781ee3a006a6f865bf038219ea73071
comment:18 Changed 7 years ago by Gesner Passos
comment:19 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:21 Changed 7 years ago by Arturs Bekasovs
It's great that cascade behavior was moved to framework part and can be tested properly. Tests seem to be rigorous enough.
Everything works as expected now, hence ticket is closed. The only thing which is a bit distracting - the necessity to click Reload all the time. But, I guess, that has some performance reasons and is clearly not within this ticket's scope.
comment:22 Changed 7 years ago by Arturs Bekasovs
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7122_autoupdate_cascade'
Full changeset: b2e58993043e45860a95b223a9ba3d62b72ac6fc
comment:23 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7968