Ticket #7126 (closed: duplicate)

Opened 7 years ago

Last modified 5 years ago

ConvertInstrumentFile has no testing

Reported by: Owen Arnold Owned by: Wenduo Zhou
Priority: critical Milestone: Release 3.0
Component: Framework Keywords: Maintenance
Cc: petersonpf@… Blocked By: #6968
Blocking: Tester: Russell Taylor

Description (last modified by Wenduo Zhou) (diff)

This algorithm is shipped with Mantid, but does not have a test harness. All algorithms shipped with Mantid should undergo frequent automated testing.

Create a Unit test, or a system test, or both, to cover the functionality of this algorithm.

Change History

comment:1 Changed 7 years ago by Stuart Campbell

  • Cc petersonpf@… added
  • Owner changed from Stuart Campbell to Wenduo Zhou
  • Status changed from new to assigned

Probably should have a more descriptive name as well.

comment:2 Changed 7 years ago by Wenduo Zhou

  • Status changed from assigned to accepted

comment:3 Changed 7 years ago by Wenduo Zhou

  • Blocked By 6968 added

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:7 Changed 7 years ago by Nick Draper

  • Keywords Maintenance added

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Release 3.0

Moved to R3.0 where this MUST BE COMLPETED

comment:9 Changed 7 years ago by Russell Taylor

  • Blocking 7696 added

comment:10 Changed 7 years ago by Wenduo Zhou

  • Description modified (diff)
  • Blocked By 6968 removed

comment:11 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to verify
  • Resolution set to duplicate

ConvertInstrumentFile is rewritten in C++ in ticket #6968. The C++ version will have its unit test implemented. And the Python version will be removed from Mantid. Therefore, there is no need to add a unit test for the Python algorithm. The ticket is thus resolved as 'duplicate'.

Last edited 7 years ago by Wenduo Zhou (previous) (diff)

comment:12 Changed 7 years ago by Wenduo Zhou

  • Blocking 7696 removed

(In #7696) Blocking ticket 7126 is deleted because 7126 is resolved as 'duplicate'.

comment:13 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:14 Changed 7 years ago by Russell Taylor

  • Blocked By 6968 added

This can't be passed until #6968 is done.

comment:15 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

ConvertInstrumentFile was removed in #7813.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7972

Note: See TracTickets for help on using tickets.