Ticket #7138 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Glob test failure

Reported by: Andrei Savici Owned by: Andrei Savici
Priority: trivial Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

If someone modifies CMakeLists.txt on unix, using say gedit, a new file is created CMakeLists.txt~. This will break the glob test. Solution: search for CMakeLists.*t instead of CMakeLists.*

Change History

comment:1 Changed 7 years ago by Andrei Savici

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Andrei Savici

Fix Glob test. Refs #7138

Also fix AnalysisDataServiceTest. It fails otherwise if one sets the Mantid preferences to show invisible workspaces

Changeset: fcb26d34dff7ee8929180f14f80c92b509c1ef99

comment:3 Changed 7 years ago by Andrei Savici

Fix Glob test. Refs #7138

Also fix AnalysisDataServiceTest. It fails otherwise if one sets the Mantid preferences to show invisible workspaces

Changeset: fcb26d34dff7ee8929180f14f80c92b509c1ef99

comment:4 Changed 7 years ago by Andrei Savici

  • Status changed from accepted to verify
  • Resolution set to fixed

To test:

  • before you build, start MantidPlot, delete the AutoTest data directory from your user directories
  • Set your user preferences to show hidden workspaces (this is for AnalysisDataServiceTest)
  • add in one of your code directories a CMakeLists.txt~ file
  • run unittests. GlobTest and AnalysisDataServiceTest should fail
  • build new mantid, then run unittests

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:6 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/bugfix/7138_globtestfix' into master

comment:7 Changed 7 years ago by Andrei Savici

Merge branch 'bugfix/7138_globtestfix' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:8 Changed 7 years ago by Andrei Savici

Merge branch 'bugfix/7138_globtestfix' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:9 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:10 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7984

Note: See TracTickets for help on using tickets.