MantidEV changes suggested by TOPAZ

[Vickie Lynch]

1) Index Peaks Using UB should be checked by default. 2) Add option to load DetCal file

[Dennis Mikkelson]

RE 7140_MantidEV_load_DetCal

Initial version. Added controls for entering .DetCal file names for two .DetCal files. (The second file is only needed for the second panel on SNAP.) Added code to enable/disable the new controls properly. Added code to save/restore the new controls' state properly. Added code to record/save/restore names of most recently used calibration files, so the file browsers for the .DetCal files can start in that directory. Factored out some common code for finding the directory in which to start, based on a file name, placing it in the method getFilePath().

refs #7140

Changeset: da73db76d7d6f71e09bbba5db81e92b45346a50f

[Dennis Mikkelson]

RE 7140_MantidEV_load_DetCal

Place new controls for loading .DetCal file before the controls for Max |Q| and selecting the Lorentz correction so the order is consistent with the order in which the algorithms are applied. Also resetting the default state using the option on the File menu will reset the .DetCal file names to blank.

refs #7140

Changeset: f887494d9ca000e6684bf09dbbf32231e3588d6b

[Dennis Mikkelson]

RE 7140_MantidEV_load_DetCal

Fix doxygen warning.

refs #7140

Changeset: 9c985902dac7c440d753d71c5092746a65355d87

[Dennis Mikkelson]

NOTES TO TESTER:

1. The option to "Index Peaks Using UB" at the bottom of the Find UB tab of MantidEV IS checked by default. To test this, start MantidEV from Interfaces->SCD_Event_Data_Reduction, go to the Find_UB tab and uncheck the the "Index Peaks Using UB" checkbox. Next, from the File menu on MantidEV, select "Reset Default Settings". The "Index Peaks Using UB" checkbox will now be checked. This problem was reported in error, and did not require fixing.

2. To test the option to load a .DetCal file:

a) Start MantidEV and use the Browse button for the event file on the "Select Data" tab to choose TOPAZ_3132_event.nxs from the systemtests/DATA/ directory. Uncheck the option to "Load ISAW Detector Calibration". Set "Max |Q| to Map to MD" to 25. Check the "Apply Lorentz Correction" option and press Apply to load and convert the data to MD.

b) Switch to the "Find Peaks" tab. Select "Find Peaks" and set "Estimated Max of a,b,c" to 15, "Number of Peaks to Find" to 500 and "Min Intensity(above ave)" to 100. Press Apply to actually find 500 peaks.

c) Switch to the "Find UB" tab. Select "Find UB Using FFT" and set "Estimated Lower Bound for a,b,c" to 3, "Estimated Upper Bound for a,b,c" to 15 and the "Tolerance" to 0.12. Press Apply to find and index the peaks. 491 peaks should index with an average error of 0.0207.

d) Go back to the first "Select Data". This time check the "Load ISAW Detector Calibration" option and use the Browse button for the first Filename to select the "BAD_DETCAL_FOR_TOPAZ_3132.DetCal" attached to this ticket. This .DetCal has been modified from the instrument data by adding 1 cm to each detector's width, subtracting 1 cm from each detector's height and subtracting 1 cm from each detector's distance. Using this .DetCal will make the mapping to Q less accurate.

e) Repeat the steps of loading, converting to MD, finding peaks and finding UB with this bad .DetCal. In this case there should be only 459 indexed peaks with an average error of 0.03198.

This verifies that the new (worse) calibration was loaded, so the modification to MantidEV works.

[Dennis Mikkelson]

IMPORTANT ADDITIONAL NOTE:

1. Before re-doing the steps using the bad .DetCal described in the previous comment, delete the workspaces that were created the first time.

2. The branch name is: feature/7140_MantidEV_load_DetCal

[Vickie Lynch]

Everything works. Most complete testing instructions I have seen.

[Stuart Campbell]

This ticket has been transferred to github issue ​7986