SANS I(Q) subtraction algorithm

[Mathieu Doucet]

Request from EQSANS. They need an algorithm to subtract a background distribution from the reduced I(Q). They input to the algorithm should be either reduced I(Q) workspaces or reduced data files.

[Mathieu Doucet]

Re #7159 First cut at subtraction algorithm

Changeset: e121a3a86e47907ea02d1365055a5288622aad35

[Mathieu Doucet]

Merge branch 'feature/7159_sans_iq_subtraction' into develop

[Mathieu Doucet]

Re #7159 Add unit test

Changeset: 5ce8fcec647f57f27240aa8fe72454f7a9f1f701

[Mathieu Doucet]

Merge branch 'feature/7159_sans_iq_subtraction' into develop

[Mathieu Doucet]

Merge branch 'feature/7159_sans_iq_subtraction' into develop into 6856_ConvertToDiffractionMDWS_v2

[Mathieu Doucet]

Merge branch 'feature/7159_sans_iq_subtraction' into develop into 6856_ConvertToDiffractionMDWS_v2

[Mathieu Doucet]

Merge branch 'feature/7159_sans_iq_subtraction' into develop into 6856_ConvertToDiffractionMDWS_v2

[Mathieu Doucet]

Merge branch 'feature/7159_sans_iq_subtraction' into develop into 6856_ConvertToDiffractionMDWS_v2

[Mathieu Doucet]

Re #7159 Make sure Dq is passed through

Changeset: e729adfea0cf1ce3db5eb6c35abd150b084d0932

[Mathieu Doucet]

Merge branch 'feature/7159_sans_iq_subtraction' into develop

[Mathieu Doucet]

To test:

• Test 1:
  1. Start the SANSSubtraction algorithm dialog.
  2. Enter a file path in the input data and background properties. The file should contain I(Q) data. A good example file can be found in the system tests: Data/SANS2D/reduced_center_by_hand.txt
  3. Pick an output directory.
  4. Pick an output workspace name.
  5. Hit run. The output workspace should be the difference between the two inputs. If the input data had Dx values, they should have been copied to the output workspace. Two files should be created in the output directory you picked. An xml file and an ascii file.

• Test 2:
  1. Load the reduced_center_by_hand.txt file above.
  2. Repeat the steps of Test 1 but replace the path of one of the inputs by the name of the workspace you just loaded.
  3. The algorithm should have the exact same behavior.

[Mathieu Doucet]

Re #7159 Added documentation

Changeset: 19019653b1da286c140a80e5bf908f2364d7bd97

[Mathieu Doucet]

Merge branch 'feature/7159_sans_iq_subtraction' into develop

[Martyn Gigg]

Test 2 as specified doesn't work for me. I used this script:

Load(Filename=r'reduced_center_by_hand.txt',OutputWorkspace='reduced_center_by_hand',Unit='MomentumTransfer')
SANSSubtract(DataDistribution='reduced_center_by_hand',Background=r'reduced_center_calculated.txt',OutputDirectory=r'/home/dmn58364/SavedData',OutputWorkspace='ws')

If I run ConvertToHistogram before the subtract it is fine. I assume this is intended but I wonder if we could make it clearer for users what they need to do, either in the documentation of within the algorithm?

[Mathieu Doucet]

Re #7159 Fix issue with data already loaded

Changeset: 3a53033299a508ff8de10ae72fc5b0996dee8cb8

[Mathieu Doucet]

Merge branch 'feature/7159_sans_iq_subtraction' into develop

[Mathieu Doucet]

Please try it again. The algorithm should now do the necessary transformation to produce data that is consistent with the requested functionality. Whatever data is loaded, the algorithm should treat it as I(Q) data. Test 2 should now be working.

[Martyn Gigg]

Merge remote-tracking branch 'origin/feature/7159_sans_iq_subtraction' into master

[Martyn Gigg]

Second test looks fine now.

[Martyn Gigg]

Merge remote-tracking branch 'origin/feature/7159_sans_iq_subtraction' into 7090_runpythonscript

[Nick Draper]

Moved to release 2.6 pending acceptance into the patch

[Mathieu Doucet]

Re #7159 First cut at subtraction algorithm

Changeset: 85218fd9fe7abf8866781f5a2be6021bb469ec9f

[Mathieu Doucet]

Re #7159 Add unit test

Changeset: 64e5c348846bb534eac77d20aff7232b1514e589

[Mathieu Doucet]

Re #7159 Make sure Dq is passed through

Changeset: e3065c45bd807317f2986943aedec4b67e3a71da

[Mathieu Doucet]

Re #7159 Added documentation

Changeset: bed2f87d836d40e4ee3fe342150281c0e6cec057

[Mathieu Doucet]

Re #7159 Fix issue with data already loaded

Changeset: 47a756bad81443ab72f4fa9e6f6695cacbb8796d

[Mathieu Doucet]

I want it in. I have users who are expecting it.

[Stuart Campbell]

This ticket has been transferred to github issue ​8005