Ticket #7173 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Memory hog & crash when plotting filtered sample time series logs

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.5.3
Component: Mantid Keywords: PatchCandidate,Released
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description (last modified by Martyn Gigg) (diff)

I think this only applies when you combine filters and it ends up being an invalid filter.

To reproduce (WARNING: the memory usage starts going throught the roof very quickly):

  • Start MantidPlot and load LOQ49886.nxs in the AutoTestData directory
  • Right-click and show sample logs
  • Find TEMP1 and double-click the log
  • Memory usage goes out of control and bang!

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Martyn Gigg

Fix memory leak when plotting sample logs using running+period filter.

If the combined filter ended up being invalid then the TimeSeriesProperty was returning the size as a value in a vector that had been previously cleared so it was returning whatever rubbish happened to be in memory. Refs #7173

Changeset: 958486bcff51ef6414434217b523e62d8be4f753

comment:3 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/7173_memory_leak_sample_logs' into develop

comment:4 Changed 7 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Description modified (diff)
  • Priority changed from critical to major
  • Milestone changed from Release 2.6 to Release 2.5.3
  • Keywords PatchCandidate added
  • Resolution set to fixed

Branch: feature/7173_memory_leak_sample_logs

Tester: Run the steps above and check that the time series logs can now be filtered by status+period and are plotted correctly.

comment:5 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:6 Changed 7 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/feature/7173_memory_leak_sample_logs' into master

comment:7 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Memory usage is OK and filtering seems to work.

comment:8 Changed 7 years ago by Martyn Gigg

Fix memory leak when plotting sample logs using running+period filter.

If the combined filter ended up being invalid then the TimeSeriesProperty was returning the size as a value in a vector that had been previously cleared so it was returning whatever rubbish happened to be in memory. Refs #7173

Changeset: 1982d74541f3455b1e548fb3720c0a380d85f596

comment:9 Changed 7 years ago by Nick Draper

  • Keywords PatchCandidate,Released added; PatchCandidate removed

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8019

Note: See TracTickets for help on using tickets.