Ticket #7200 (closed: fixed)
Move all demplated methods from MDBoxFlatTree to MDEventsFactory
Reported by: | Alex Buts | Owned by: | Alex Buts |
---|---|---|---|
Priority: | major | Milestone: | Release 2.6 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #6447 | Tester: | Nick Draper |
Description (last modified by Nick Draper) (diff)
MDEvents factory instantiates all code dependent on number of dimensions.
MDBoxFlatTree temporary instantiated the dimension-dependant code it needs.
All such code has to be generated in one place and the best place for that is MDEventsFactory.
Change History
comment:2 Changed 7 years ago by Alex Buts
refs #7200 initial modifications to MDEvent Factory to accept new
templates from MDFlatBoxTree class
Changeset: d6490bdab5af644dc17209e26f4309eabfebceab
comment:3 Changed 7 years ago by Alex Buts
refs #7200 rewritten old workspace factory as workspace metaloop
Changeset: ae103e9f7dd97c62f0590e26e90b0fcfb9403086
comment:4 Changed 7 years ago by Alex Buts
refs #7200 rewritten existing MDEventFactory using TMD as example
Changeset: 4bd6f1a96a2452e97d9f4996ead42aff1f6f7af0
comment:5 Changed 7 years ago by Alex Buts
refs #7200 Added MDBox factory to MD events factory
Changeset: 819bac0334683de05bd4a1b77eace42bd0fee8b1
comment:6 Changed 7 years ago by Alex Buts
refs #7200 Created proper factory method for MDBoxes/MDGridBoxes
Changeset: d0082f8067ee1aee92ccee027d9247ae9b0ce22e
comment:7 Changed 7 years ago by Alex Buts
refs #7200 MDBoxFlatTree is not templated class any more --
all code generation moved to MDEventFactory
Changeset: 9da5cb2d9ae09c10264354681e29f103b4243b2a
comment:8 Changed 7 years ago by Alex Buts
refs #7200 trying to resolve Unix differences.
Changeset: 7ffa3274ef166377d0f53b585cbf4b94f8930346
comment:9 Changed 7 years ago by Alex Buts
refs #7200 fixing dependencies on changed MDBoxFlatTree
Changeset: fe8994a722b32a699a6b7739788fd38e284eb01e
comment:10 Changed 7 years ago by Alex Buts
refs #7200 Unit tests for MDBoxFactory
Changeset: 31700d3bf272b944a38f2374ac71e93ff02e6df3
comment:11 Changed 7 years ago by Alex Buts
refs #7200 Fixed unit tests
Changeset: d1875dd8aec0badfb32a0c975d2197b49f6fe8e3
comment:12 Changed 7 years ago by Alex Buts
refs #7200 Modified genertate_mdevent_declarations.py
to work with new eventFactory properly
Changeset: c73c7442634bb5c25e5b5bf5abda11543859dd04
comment:13 Changed 7 years ago by Alex Buts
refs #7200 Doxygen comments and minor modifications
Changeset: cab2a97139180d09776312c6ad17487d4a970450
comment:14 Changed 7 years ago by Alex Buts
refs #7200 fixing mac build --
formatting MDEventFactory.h according to MAC requests.
Changeset: 9540a8f2665622f6855100827d4cd02fac3011c4
comment:15 Changed 7 years ago by Alex Buts
refs #7200 MDBoxBase code has to be generated after all
how weird, it is abstract class after all.
Changeset: 9eb2afec6eeb0629c522cd19b569c74308a3ef21
comment:16 Changed 7 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
This is part of the ticket #6447 and can be easy tested by code inspection, if all system and unit tests pass.
I modified existing MDEventWorkspace factory in the fashion of MDEventWorkspaceWrapper to add MDBox factory in the same fashion and be able easy add other factory methods. python code generator has been modified to cope with new code, so it generates only the parts not available for C++ code generator (or rather not known for me how to generate it).
No new functionality added to old code and the modified code should work exactly like the old one. The new code allowed me to remove templates from MDBoxFlatTree, which restores box tree using the factory rather then templated memory allocation.
comment:17 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:18 Changed 7 years ago by Nick Draper
All unit and system tests pass
comment:19 Changed 7 years ago by Nick Draper
re #7200 minor corrections
Changeset: dd4358b1b7c782032510f90d0d0529ef237c9863
comment:20 Changed 7 years ago by Nick Draper
needed to clean up some commented out code in MDBoxFlatTree
Corrected a spelling error in generate_mdevent_declarations.py method declaration parce_file -> parse_file
comment:22 Changed 7 years ago by Nick Draper
- Component changed from VATES to Framework
- Description modified (diff)
comment:23 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8046