Ticket #7202 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Clean up file saving in MDAlgorithm tests

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

There are a number of MDAlgorithms that write files, but do not clean up after themselves. This should be fixed.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Michael Reuter

Refs #7202. Cleaning up SaveMDTest files.

Changeset: e941a5d20231dca70f6286bf1a13da210326ed56

comment:3 Changed 7 years ago by Michael Reuter

Refs #7202. Cleaning up LoadMDTest files.

Changeset: a039ca61f659efe490aadd1bd4cfa1be1b24678a

comment:4 Changed 7 years ago by Michael Reuter

Refs #7202. Adding a helper function.

Changeset: 1e38da81acb3da8330575b14c32660faf196988b

comment:5 Changed 7 years ago by Michael Reuter

Refs #7202. Cleaning up MinusMDTest files.

Changeset: 6ace153f5f3d561ffc74e962b675675caedb0282

comment:6 Changed 7 years ago by Michael Reuter

Refs #7202. Cleaning up CloneMDWorkspaceTest files.

Changeset: 00527fb0c4457a68b306bebb927c9b0de4b7c55d

comment:7 Changed 7 years ago by Michael Reuter

Refs #7202. Cleaning up TransformMDTest files.

Changeset: ae137fbe3c7465b9f8e190331d8ad823edc459ce

comment:8 Changed 7 years ago by Michael Reuter

Refs #7202. Cleaning up SliceMDTest files.

Changeset: 2e4bbec920241d207c6537fa678626e50ff4e258

comment:9 Changed 7 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

Branch is ​here.

To test:

Run the unit tests for MDAlgorithms. None of the following files should not remain behind any more. It is advised to start with a clean save directory, but one can try with these files left behind from a previous run. 

CloneMDWorkspaceTest_ws_clone.nxs
CloneMDWorkspaceTest_ws_custom_cloned_name2.nxs
CloneMDWorkspaceTest_ws_custom_cloned_name.nxs
CloneMDWorkspaceTest_ws.nxs
MDAffineSaveTest.nxs
MinusMDTest_lhs_clone.nxs
MinusMDTest_lhs.nxs
MinusMDTest_rhs.nxs
MultiExperSaveTest.nxs
SaveMDAffineTest.nxs
SaveMDSpecialCoordinatesTest.nxs
SliceMDTest_output.nxs
TransformMDTest_ws_clone.nxs
TransformMDTest_ws.nxs

comment:10 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:11 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

comment:12 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8048

Note: See TracTickets for help on using tickets.