Ticket #7205 (closed: fixed)
Improve performance of peaks view in SliceViewer
Reported by: | Peter Peterson | Owned by: | Peter Peterson |
---|---|---|---|
Priority: | major | Milestone: | Release 2.6 |
Component: | GUI | Keywords: | |
Cc: | owen.arnold@… | Blocked By: | |
Blocking: | Tester: | Michael Reuter |
Change History
comment:2 Changed 7 years ago by Peter Peterson
Re #7205. Adding back in reasonable default values for column widths.
Changeset: 0dcde5e3c39160ec1cd188d3fe81e65fe83b16bb
comment:4 Changed 7 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
This is on feature/7205_sliceview_performance.
The fix submitted takes care of performance issues because of the table of peaks being slow, but does nothing for the raster image being slow. That will be addressed in #7217.
To test:
- generate a md-workspace (such as with the "SCD event reduction" interface)
- LoadIsawPeaks the file attached to #7217.
- Bring up the slice viewer and add the peaks workspace
- Use the scrollbar to view more of the peaks workspace
Note: Things that change the view in the raster image will still be very slow and are not a subject of this ticket.
comment:5 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:6 Changed 7 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
In the QPeaksTableModel::updateDataCache call, the peak intensity is added twice to the cache object. I think the last call should be for the peak sigma intensity.
comment:8 Changed 7 years ago by Peter Peterson
Re #7205. Added the missing 5 characters to fix the bug.
Thanks for catching this one.
Changeset: b0fcb8dc5fe9bf35073697525d0f30359f163965
comment:9 Changed 7 years ago by Peter Peterson
- Status changed from accepted to verify
- Resolution set to fixed
Same instructions for testing. Same branch too.
comment:11 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
The table of peaks is very responsive now as long as the raster image is not touched.
comment:13 Changed 7 years ago by Nick Draper
- Component changed from Framework to User Interface
- Description modified (diff)
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8051
Re #7205. Change the way column sizes are setup.
Since QTableView likes to look at all cells to calculate the width. Changed the hint for how to calculate column sizes to be "Interactive."
Changeset: e876ae16d8bf498282776f7cb2e44bcaca791877