MonitorLiveDataTest occasional failures

[Russell Taylor]

Even after the fixes in #6811, this test still fails sometimes.

There are two places:

• test_Allow_AnotherAlgo_IfTheOtherIsFinished: this is almost certainly because the threads don't behave nicely. It would be best to find a way that doesn't involve threads.

• test_EndRunBehavior_Rename: This one's a bit more worrying - pretty clearly a race condition.

  C:/jenkins/workspace/ornl_windows7_develop/Code/Mantid/Framework/DataHandling
  /test/MonitorLiveDataTest.h:216: Error: Expected (ws1->getNumberEvents() ==
  4*200), found (1600 != 800)
  

[Russell Taylor]

Made some commits against the wrong ticket number:

Re #7215. Change testing strategy to avoid occasional failures.

I think the sporadic failures of this test were because alg2 had not started up even after the sleep. Calling validateInputs() instead accomplishes the same testing goal and avoid having to execute this instance of the algorithm at all.

Changeset: 489709aecfada06d1e331eda7b4f201dd5818d08

---

Re #7215. Use the same simplification in other places.

I don't think I've seen these tests fail, but this is a simpler way to test the same thing so use it here as well.

Changeset: ba3b5b066e13419afe76e2a8a972c6a195f11ecf

---

Re #7215. Minor simplification.

Changeset: 27f76c6c87b80688d0bca3686accbc1868b931ce

[Russell Taylor]

Re #7218. Lock the workspace during the clone operation.

Changeset: 4f65381d336cf2d86c9e5e684433f82448a7fedb

[Russell Taylor]

Re #7218. Try to make tests more robust to slow thread startup.

Changeset: e1f19e71349405b09db4fc0d7667f7489afbefa1

[Russell Taylor]

Re #7218. Remove a redundant test.

Changeset: c0442dbc2930c6179a82bc6ca7f3cf50fb6ce68b

[Russell Taylor]

Re #7218. Use a unique workspace name for this test.

Although there's a setUp method that clears the ADS, I think it's possible for the previous test to still be running and to pop its workspace back in there, which could possibly be why this test occasionally fails.

Changeset: 5f97f619ec14d485bd5e63a30cc29bfd588978bf

[Russell Taylor]

Branch is feature/7218_monitorlivedata_occasional_test_failures

Test by checking for any failures of this test after today (4 June) ​here and ​here.

I'm pretty sure I've fixed the first problem in the description, but not so confident on the second one - my best guess is the last commit above. If one is fixed but not the other, please create a new ticket for the still-broken one so that we can get at least one fix into master.

[Alex Buts]

ORNL windows dead from 4th of June but ISIS works fine without problems with this test. Ok -- I can assume it may be considered fixed.

[Stuart Campbell]

This ticket has been transferred to github issue ​8064