Ticket #7222 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Inst view: Share "drawing tools between Pick and Mask/group tabs

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.6
Component: MantidPlot Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description (last modified by Roman Tolchenov) (diff)

The selection in the pick tab is somewhat lacking compared to the mask/group tab.

  • use the mask/group tab drawing tools on the pick tab.
    • Add the rubber box to the buttons for the mask/group it should remove a selection "box" if clicked on it, or if one not present remove peaks, or nothing.
    • The pick tab will also have the remaining 3 buttons (select single, bank,single crystal) as a second layer of buttons.
    • The image for move instrument in the mask/group controls needs to change.
    • Add the Tool:description label to the mask/group tab
    • Boxes created on one tab should remain and be functional on the other. You might want to pick another colour for the border for the pick tab.
  • "Boxes" on the pick tab should sum all of the spectra and show it on the miniplot.
    • The miniplot should update as frequently as is reasonable (while moving or resizing of boxes, of after).
    • The miniplot will need to refresh if the instrument is moved or zoomed
  • Remove the current rubber band functionality on the Pixel selection tool

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Description modified (diff)

comment:2 Changed 7 years ago by Alex Buts

See in the duplicate ticket #7191 for the picture describing parts of this functionality.

comment:3 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:4 Changed 7 years ago by Roman Tolchenov

Added drawing buttons to Pick tab. Rubber band shape selection.

Re #7222.

Changeset: f5493d330c04b2cfde2f0f9b9ea8bf204791eb5f

comment:5 Changed 7 years ago by Roman Tolchenov

Adding missing image file. Re #7222.

Changeset: d5bafca52839f64e1c7168d5a03d47699499fbf9

comment:6 Changed 7 years ago by Roman Tolchenov

Miniplot shows sum of counts in detectors covered by shapes.

Refactored 2d shape classes to work with multiple selections. Re #7222

Changeset: 116f83c2b866e7d47926b1bdde0c8e73e32ef713

comment:7 Changed 7 years ago by Roman Tolchenov

Adding shapes to selection by ctrl+click. Re #7222

Changeset: eb6aa733450196e3df620920c45b088c94a0bca9

comment:8 Changed 7 years ago by Roman Tolchenov

Added the ring shapes. Fixed ellipse's contains method. Re #7222

Changeset: c6936e90120fcd525ccb4cfe8392f48ce12f17b6

comment:9 Changed 7 years ago by Roman Tolchenov

Update miniplot when instrument moves in 3D view. Re #7222.

Changeset: cebc9049a93fda9231c56749b3f9d4cdfaed9930

comment:10 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:12 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Tested on MUSR data

mask/group tab drawing tools available in pick. Can pick multiple regions and e.g. see resulting sum plot. One minor thing which I have discussed with Roman is that, for example the case of the musr instrument, need to include the center point in masked area to include in sum plot. Roman gets the best performance doing it this way.

Rubber box added to the bottom

However if data plotted when selecting new values left and right of the rubber band the plot disappear. To get it to reappear have to click on one of the masked areas

comment:13 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to inprogress

Refresh the miniplot after change of x-range. Re #7222

Changeset: 92df6fa926feadd0bd243e8eacb9db01728ff1bc

comment:14 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:15 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester changed from Anders Markvardsen to Gesner Passos

comment:16 Changed 7 years ago by Gesner Passos

Nice new features implemented and working nicely. I have just couple of comments:

  • I did not particularly liked the image for the move instrument. Now it is a zoom.png image. When you are looking to the instrument in perspective, it allows you to zoom part of the instrument, when looking in 3D it moves the instrument. Besides, zoom.png does not means move anything. #7534
  • The miniplot disapears when you change the time-of-flight. If you move the selection again, it reappears (at least in UBUNTU) #7536

comment:17 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7222_share_drawing_tools'

comment:18 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8068

Note: See TracTickets for help on using tickets.